Skip to content

Commit 04d1ecd

Browse files
committed
Update snapshots p2
1 parent 627fe7a commit 04d1ecd

File tree

7 files changed

+20
-8
lines changed

7 files changed

+20
-8
lines changed

ui-tests/tests/voila.test.ts

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import { expect, test } from '@playwright/test';
55
import { addBenchmarkToTest } from './utils';
66

7-
const PREFIX =
8-
process.env.PROGRESSIVE_RENDERING === 'true' ? 'progressive_rendering_' : '';
7+
const PROGRESSIVE_RENDERING = process.env.PROGRESSIVE_RENDERING === 'true';
8+
const PREFIX = PROGRESSIVE_RENDERING ? '' : '';
99
test.describe('Voila performance Tests', () => {
1010
test.beforeEach(({ page }) => {
1111
page.setDefaultTimeout(120000);
@@ -310,19 +310,31 @@ test.describe('Voila performance Tests', () => {
310310
const notebookName = 'query-strings';
311311
const testFunction = async () => {
312312
await page.goto(`/voila/render/${notebookName}.ipynb`);
313-
await page.waitForSelector(
314-
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
315-
);
313+
if (PROGRESSIVE_RENDERING) {
314+
await page.waitForSelector(
315+
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
316+
);
317+
} else {
318+
await page.waitForSelector(
319+
'div.jp-OutputArea-output[data-mime-type="text/plain"]'
320+
);
321+
}
316322
const userName = await page.$$(
317323
'div.jp-RenderedText.jp-OutputArea-output > pre'
318324
);
319325
expect(await userName[1].innerHTML()).toContain('Hi Kim');
320326
};
321327
await addBenchmarkToTest(notebookName, testFunction, testInfo, browserName);
322328
await page.goto(`/voila/render/${notebookName}.ipynb?username=Riley`);
323-
await page.waitForSelector(
324-
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
325-
);
329+
if (PROGRESSIVE_RENDERING) {
330+
await page.waitForSelector(
331+
'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]'
332+
);
333+
} else {
334+
await page.waitForSelector(
335+
'div.jp-OutputArea-output[data-mime-type="text/plain"]'
336+
);
337+
}
326338
const userName = await page.$$(
327339
'div.jp-RenderedText.jp-OutputArea-output > pre'
328340
);
15.4 KB
Loading
615 Bytes
Loading
8.74 KB
Loading
26.1 KB
Loading
1.27 KB
Loading
1.88 KB
Loading

0 commit comments

Comments
 (0)