Skip to content

Commit 2d3c48b

Browse files
authored
Add missing react-dom module to Webpack shared scope (#67)
1 parent 2786aa6 commit 2d3c48b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/voici/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
"@lumino/virtualdom": "^1.11.2",
5151
"@lumino/widgets": "^1.26.2",
5252
"@voila-dashboards/voila": "^0.5.0-alpha.3",
53-
"react": "^17.0.1"
53+
"react": "^17.0.1",
54+
"react-dom": "^17.0.1"
5455
},
5556
"devDependencies": {
5657
"@babel/core": "^7.2.2",

packages/voici/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
****************************************************************************/
99
import '@jupyterlab/nbconvert-css/style/index.css';
1010

11+
import 'react-dom';
1112
import { PageConfig, URLExt } from '@jupyterlab/coreutils';
1213
import { JupyterLiteServer } from '@jupyterlite/server';
1314
import { IKernelSpecs } from '@jupyterlite/kernel';
1415

1516
import { VoilaShell } from '@voila-dashboards/voila';
16-
1717
import { VoiciApp } from './app';
1818
import plugins from './plugins';
1919
import { loadComponent, createModule, activePlugins } from './utils';

0 commit comments

Comments
 (0)