correct SetControlFlags and ClearControlFlags APIs

Author: divyenpatel

vslm/client_test.go

@@ -24,8 +24,10 @@ import (
 
 	"github.com/vmware/govmomi"
 	"github.com/vmware/govmomi/cns"
-	cnstypes "github.com/vmware/govmomi/cns/types"
 	"github.com/vmware/govmomi/vim25/soap"
+	"github.com/vmware/govmomi/vim25/types"
+
+	cnstypes "github.com/vmware/govmomi/cns/types"
 )
 
 func TestClient(t *testing.T) {
@@ -116,4 +118,15 @@ func TestClient(t *testing.T) {
 	volumeCreateResult := (createTaskResult).(*cnstypes.CnsVolumeCreateResult)
 	t.Logf("volumeCreateResult %+v", volumeCreateResult)
 	t.Logf("Volume created sucessfully. volumeId: %s", volumeId)
+
+	err = globalObjectManager.SetControlFlags(ctx, types.ID{Id: volumeId}, []string{"FCD_KEEP_AFTER_DELETE_VM"})
+	if err != nil {
+		t.Fatal(err)
+	}
+	t.Logf("Control flag: FCD_KEEP_AFTER_DELETE_VM set for the volumeId: %s", volumeId)
+	err = globalObjectManager.ClearControlFlags(ctx, types.ID{Id: volumeId})
+	if err != nil {
+		t.Fatal(err)
+	}
+	t.Logf("Control flags removed the volumeId: %s", volumeId)
 }

vslm/global_object_manager.go

@@ -345,9 +345,10 @@ func (this *GlobalObjectManager) Relocate(ct context.Context, id vim.ID, spec vi
 	return NewTask(this.c, res.Returnval), nil
 }
 
-func (this *GlobalObjectManager) SetControlFlags(ct context.Context, controlFlags []string) error {
+func (this *GlobalObjectManager) SetControlFlags(ct context.Context, id vim.ID, controlFlags []string) error {
 	req := types.VslmSetVStorageObjectControlFlags{
 		This:         this.Reference(),
+		Id:           id,
 		ControlFlags: controlFlags,
 	}
 
@@ -359,9 +360,10 @@ func (this *GlobalObjectManager) SetControlFlags(ct context.Context, controlFlag
 	return nil
 }
 
-func (this *GlobalObjectManager) ClearControlFlags(ct context.Context) error {
+func (this *GlobalObjectManager) ClearControlFlags(ct context.Context, id vim.ID) error {
 	req := types.VslmClearVStorageObjectControlFlags{
 		This: this.Reference(),
+		Id:   id,
 	}
 
 	_, err := methods.VslmClearVStorageObjectControlFlags(ct, this.c, &req)