Skip to content

[Model] support MiniMax-VL-01 model #16328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 291 commits into from
Apr 29, 2025
Merged

Conversation

qscqesze
Copy link
Contributor

@qscqesze qscqesze commented Apr 9, 2025

CLOSES #12073

This PR is intended to support the MiniMaxVL01 model inference.
It adopts the “ViT-MLP-LLM” framework, which is a commonly used technique in the field of multimodal large language models. Add the MiniMaxVL01 model inference implementation, and a image processer.

Copy link

github-actions bot commented Apr 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Apr 9, 2025
Copy link

mergify bot commented Apr 10, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @qscqesze.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

qscqesze added 23 commits April 16, 2025 20:29
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
@DarkLight1337
Copy link
Member

Why can't we test processing correctness for this model?

Signed-off-by: qingjun <[email protected]>
@DarkLight1337
Copy link
Member

Can you also add a get_language_model method to match the new interface since #16007?

qscqesze added 10 commits April 28, 2025 19:40
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Signed-off-by: qingjun <[email protected]>
Qingjun/vl0428
Signed-off-by: qingjun <[email protected]>
@qscqesze
Copy link
Contributor Author

Can you also add a get_language_model method to match the new interface since #16007?

Done.

Signed-off-by: qingjun <[email protected]>
@qscqesze
Copy link
Contributor Author

@DarkLight1337 Hi. If you have time, could you help us move this forward?

@DarkLight1337
Copy link
Member

Nice, it passes now. I'll take care of the processor test in another PR

@DarkLight1337 DarkLight1337 merged commit cde384c into vllm-project:main Apr 29, 2025
45 checks passed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Model]: support minimax-01
4 participants