fix: keep built-in id as is in bun and deno (#9117)

Author: sheremet-va

packages/vitest/src/node/pools/rpc.ts

@@ -2,9 +2,9 @@ import type { RuntimeRPC } from '../../types/rpc'
 import type { TestProject } from '../project'
 import type { ResolveSnapshotPathHandlerContext } from '../types/config'
 import { existsSync, mkdirSync } from 'node:fs'
-import { isBuiltin } from 'node:module'
 import { fileURLToPath } from 'node:url'
 import { cleanUrl } from '@vitest/utils/helpers'
+import { isBuiltin, toBuiltin } from '../../utils/modules'
 import { handleRollupError } from '../environments/fetchModule'
 import { normalizeResolvedIdToUrl } from '../environments/normalizeUrl'
 
@@ -69,9 +69,10 @@ export function createMethodsRPC(project: TestProject, methodsOptions: MethodsOp
       if (resolved.external) {
         return {
           file,
-          // TODO: use isBuiltin defined in the environment
-          url: !resolved.id.startsWith('node:') && isBuiltin(resolved.id)
-            ? `node:${resolved.id}`
+          // this is only used by the module mocker and it always
+          // standardizes the id to mock "node:url" and "url" at the same time
+          url: isBuiltin(resolved.id)
+            ? toBuiltin(resolved.id)
             : resolved.id,
           id: resolved.id,
         }

packages/vitest/src/runtime/moduleRunner/startModuleRunner.ts

@@ -5,8 +5,8 @@ import type { Traces } from '../../utils/traces'
 import type { ExternalModulesExecutor } from '../external-executor'
 import type { CreateImportMeta } from './moduleRunner'
 import fs from 'node:fs'
-import { isBuiltin } from 'node:module'
 import { isBareImport } from '@vitest/utils/helpers'
+import { isBrowserExternal, isBuiltin, toBuiltin } from '../../utils/modules'
 import { getCachedVitestImport } from './cachedResolver'
 import { listenForErrors } from './errorCatcher'
 import { unwrapId, VitestModuleEvaluator } from './moduleEvaluator'
@@ -15,9 +15,6 @@ import { VitestModuleRunner } from './moduleRunner'
 
 const { readFileSync } = fs
 
-const browserExternalId = '__vite-browser-external'
-const browserExternalLength = browserExternalId.length + 1 // 1 is ":"
-
 export const VITEST_VM_CONTEXT_SYMBOL: string = '__vitest_vm_context__'
 
 export interface ContextModuleRunnerOptions {
@@ -124,7 +121,11 @@ export function startVitestModuleRunner(options: ContextModuleRunnerOptions): Vi
             }
           }
 
-          if (isBuiltin(rawId) || rawId.startsWith(browserExternalId)) {
+          if (isBuiltin(rawId)) {
+            return { externalize: rawId, type: 'builtin' }
+          }
+
+          if (isBrowserExternal(rawId)) {
             return { externalize: toBuiltin(rawId), type: 'builtin' }
           }
 
@@ -184,14 +185,3 @@ export function startVitestModuleRunner(options: ContextModuleRunnerOptions): Vi
 
   return moduleRunner
 }
-
-export function toBuiltin(id: string): string {
-  if (id.startsWith(browserExternalId)) {
-    id = id.slice(browserExternalLength)
-  }
-
-  if (!id.startsWith('node:')) {
-    id = `node:${id}`
-  }
-  return id
-}

packages/vitest/src/utils/modules.ts

@@ -0,0 +1,54 @@
+// copied from vite
+// https://github.com/vitejs/vite/blob/814120f2ad387ca3d1e16c7dd403b04ca4b97f75/packages/vite/src/node/utils.ts#L106
+import { builtinModules } from 'node:module'
+
+// Supported by Node, Deno, Bun
+const NODE_BUILTIN_NAMESPACE = 'node:'
+// Supported by Deno
+const NPM_BUILTIN_NAMESPACE = 'npm:'
+// Supported by Bun
+const BUN_BUILTIN_NAMESPACE = 'bun:'
+// Some runtimes like Bun injects namespaced modules here, which is not a node builtin
+const nodeBuiltins = builtinModules.filter(id => !id.includes(':'))
+
+// TODO: Use `isBuiltin` from `node:module`, but Deno doesn't support it
+export function isBuiltin(id: string): boolean {
+  if (process.versions.deno && id.startsWith(NPM_BUILTIN_NAMESPACE)) {
+    return true
+  }
+  if (process.versions.bun && id.startsWith(BUN_BUILTIN_NAMESPACE)) {
+    return true
+  }
+  return isNodeBuiltin(id)
+}
+
+export function isNodeBuiltin(id: string): boolean {
+  if (id.startsWith(NODE_BUILTIN_NAMESPACE)) {
+    return true
+  }
+  return nodeBuiltins.includes(id)
+}
+
+const browserExternalId = '__vite-browser-external'
+const browserExternalLength = browserExternalId.length + 1 // 1 is ":"
+
+export function isBrowserExternal(id: string): boolean {
+  return id.startsWith(browserExternalId)
+}
+
+export function toBuiltin(id: string): string {
+  if (id.startsWith(browserExternalId)) {
+    id = id.slice(browserExternalLength)
+  }
+  if (
+    id.startsWith(NPM_BUILTIN_NAMESPACE)
+    || id.startsWith(BUN_BUILTIN_NAMESPACE)
+    || id.startsWith(NODE_BUILTIN_NAMESPACE)
+  ) {
+    return id
+  }
+  if (process.versions.deno || process.versions.bun) {
+    return id
+  }
+  return `node:${id}`
+}