Skip to content

refactor!: update MSCB to not use combo-box extension internally #9804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2025
Merged

refactor!: update MSCB to not use combo-box extension internally #9804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
120d6fb
refactor!: update MSCB to not use combo-box extension internally
web-padawan Jul 25, 2025
a1902b1
test: update base screenshot for auto-expand height
web-padawan Jul 25, 2025
0ecff9e
test: add test verifying Esc only clears selectedItems when closed
web-padawan Jul 28, 2025
8772cad
fix: align MSCB types to use combo-box mixin classes
web-padawan Jul 28, 2025
1effecb
refactor: remove no longer needed initScroller logic
web-padawan Jul 28, 2025
079fbc2
test: add missing test for Escape with autoOpenDisabled
web-padawan Jul 28, 2025
f54ff1f
test: revert not needed unit test changes
web-padawan Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/combo-box/src/vaadin-combo-box-base-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,14 +241,13 @@ export const ComboBoxBaseMixin = (superClass) =>

/**
* Create and initialize the scroller element.
* Override to provide custom host reference.
*
* @protected
* @private
*/
_initScroller(host) {
_initScroller() {
const scroller = document.createElement(`${this._tagNamePrefix}-scroller`);

scroller.owner = host || this;
scroller.owner = this;
scroller.getItemLabel = this._getItemLabel.bind(this);
scroller.addEventListener('selection-changed', this._boundOverlaySelectedItemChanged);

Expand Down
4 changes: 4 additions & 0 deletions packages/multi-select-combo-box/src/styles/vaadin-multi-select-combo-box-core-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ export const multiSelectComboBoxStyles = css`
--_chip-min-width: var(--vaadin-multi-select-combo-box-chip-min-width, 50px);
}

:host([opened]) {
pointer-events: auto;
Copy link
Member Author

@web-padawan web-padawan Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base styles for MSCB already have this as they extend combo-box base styles.

}

#chips {
display: flex;
align-items: center;
Expand Down
Loading