fix: check on parentElement instead of isConnected

vursen · vursen · commit 04a7c7fd960a · 2021-06-03T17:51:58.000+03:00
diff --git a/packages/vaadin-template-renderer/src/vaadin-template-renderer-templatizer.js b/packages/vaadin-template-renderer/src/vaadin-template-renderer-templatizer.js
@@ -73,7 +73,12 @@ export class Templatizer extends PolymerElement {
   }
 
   __isTemplateInstanceConnected(instance) {
-    return instance.children[0].isConnected;
+    // A workaround for the edge-case case when the template is empty
+    if (instance.children.length === 0) {
+      return false;
+    }
+
+    return instance.children[0].parentElement;
   }
 
   __createTemplateClass(properties) {

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,12 @@ export class Templatizer extends PolymerElement {`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`__isTemplateInstanceConnected(instance) {`
`76`		`- return instance.children[0].isConnected;`
	`76`	`+ // A workaround for the edge-case case when the template is empty`
	`77`	`+ if (instance.children.length === 0) {`
	`78`	`+ return false;`
	`79`	`+ }`
	`80`	`+`
	`81`	`+ return instance.children[0].parentElement;`
`77`	`82`	`}`
`78`	`83`
`79`	`84`	`__createTemplateClass(properties) {`