PPC: remove support for ppc 32-bit, part 1

ppc32 has been out of support for a long time now.
This CL removes the following from v8 codebase:
- V8_TARGET_ARCH_PPC_LE and V8_TARGET_ARCH_PPC_BE
- V8_TARGET_ARCH_PPC
- V8_HOST_ARCH_PPC
- v8_current_cpu == "ppc"
- arch == ppc

Change-Id: I452b9fc04b8fa7b7909c5a7cb4b12587ef5ccb7d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5796844
Reviewed-by: Jakob Kummerow <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#95773}

Author: Milad Fa

BUILD.bazel

@@ -490,8 +490,7 @@ v8_config(
             ],
             "@v8//bazel/config:v8_target_ppc64le": [
                 # NOTE: Bazel rules for ppc64le weren't tested on a real system.
-                "V8_TARGET_ARCH_PPC64",
-                "V8_TARGET_ARCH_PPC_LE",
+                "V8_TARGET_ARCH_PPC64"
             ],
         },
         no_match_error = "Please specify a target cpu supported by v8",

BUILD.gn

@@ -1422,27 +1422,18 @@ config("toolchain") {
       cflags += [ "-march=z196" ]
     }
   }
-  if (v8_current_cpu == "ppc" || v8_current_cpu == "ppc64") {
-    if (v8_current_cpu == "ppc") {
-      defines += [ "V8_TARGET_ARCH_PPC" ]
-    } else if (v8_current_cpu == "ppc64") {
-      defines += [ "V8_TARGET_ARCH_PPC64" ]
-      cflags += [ "-ffp-contract=off" ]
-    }
-    if (host_byteorder == "little") {
-      defines += [ "V8_TARGET_ARCH_PPC_LE" ]
-    } else if (host_byteorder == "big") {
-      defines += [ "V8_TARGET_ARCH_PPC_BE" ]
-      if (current_os == "aix") {
-        cflags += [
-          # Work around AIX ceil, trunc and round oddities.
-          "-mcpu=power5+",
-          "-mfprnd",
-
-          # Work around AIX assembler popcntb bug.
-          "-mno-popcntb",
-        ]
-      }
+  if (v8_current_cpu == "ppc64") {
+    defines += [ "V8_TARGET_ARCH_PPC64" ]
+    cflags += [ "-ffp-contract=off" ]
+    if (current_os == "aix") {
+      cflags += [
+        # Work around AIX ceil, trunc and round oddities.
+        "-mcpu=power5+",
+        "-mfprnd",
+
+        # Work around AIX assembler popcntb bug.
+        "-mno-popcntb",
+      ]
     }
   }
 
@@ -3029,11 +3020,6 @@ v8_source_set("v8_initializers") {
       ### gcmole(loong64) ###
       "src/builtins/loong64/builtins-loong64.cc",
     ]
-  } else if (v8_current_cpu == "ppc") {
-    sources += [
-      ### gcmole(ppc) ###
-      "src/builtins/ppc/builtins-ppc.cc",
-    ]
   } else if (v8_current_cpu == "ppc64") {
     sources += [
       ### gcmole(ppc64) ###
@@ -4706,23 +4692,6 @@ v8_header_set("v8_internal_headers") {
         sources += [ "src/trap-handler/trap-handler-simulator.h" ]
       }
     }
-  } else if (v8_current_cpu == "ppc") {
-    sources += [
-      ### gcmole(ppc) ###
-      "src/codegen/ppc/assembler-ppc-inl.h",
-      "src/codegen/ppc/assembler-ppc.h",
-      "src/codegen/ppc/constants-ppc.h",
-      "src/codegen/ppc/interface-descriptors-ppc-inl.h",
-      "src/codegen/ppc/macro-assembler-ppc.h",
-      "src/codegen/ppc/register-ppc.h",
-      "src/codegen/ppc/reglist-ppc.h",
-      "src/compiler/backend/ppc/instruction-codes-ppc.h",
-      "src/compiler/backend/ppc/unwinding-info-writer-ppc.h",
-      "src/execution/ppc/frame-constants-ppc.h",
-      "src/execution/ppc/simulator-ppc.h",
-      "src/regexp/ppc/regexp-macro-assembler-ppc.h",
-      "src/wasm/baseline/ppc/liftoff-assembler-ppc-inl.h",
-    ]
   } else if (v8_current_cpu == "ppc64") {
     sources += [
       ### gcmole(ppc64) ###
@@ -5060,14 +5029,6 @@ if (v8_current_cpu == "x86") {
     "src/compiler/backend/loong64/instruction-scheduler-loong64.cc",
     "src/compiler/backend/loong64/instruction-selector-loong64.cc",
   ]
-} else if (v8_current_cpu == "ppc") {
-  v8_compiler_sources += [
-    ### gcmole(ppc) ###
-    "src/compiler/backend/ppc/code-generator-ppc.cc",
-    "src/compiler/backend/ppc/instruction-scheduler-ppc.cc",
-    "src/compiler/backend/ppc/instruction-selector-ppc.cc",
-    "src/compiler/backend/ppc/unwinding-info-writer-ppc.cc",
-  ]
 } else if (v8_current_cpu == "ppc64") {
   v8_compiler_sources += [
     ### gcmole(ppc64) ###
@@ -6094,21 +6055,6 @@ v8_source_set("v8_base_without_compiler") {
         sources += [ "src/trap-handler/handler-outside-simulator.cc" ]
       }
     }
-  } else if (v8_current_cpu == "ppc") {
-    sources += [
-      ### gcmole(ppc) ###
-      "src/codegen/ppc/assembler-ppc.cc",
-      "src/codegen/ppc/constants-ppc.cc",
-      "src/codegen/ppc/cpu-ppc.cc",
-      "src/codegen/ppc/macro-assembler-ppc.cc",
-      "src/deoptimizer/ppc/deoptimizer-ppc.cc",
-      "src/diagnostics/ppc/disasm-ppc.cc",
-      "src/diagnostics/ppc/eh-frame-ppc.cc",
-      "src/diagnostics/ppc/unwinder-ppc.cc",
-      "src/execution/ppc/frame-constants-ppc.cc",
-      "src/execution/ppc/simulator-ppc.cc",
-      "src/regexp/ppc/regexp-macro-assembler-ppc.cc",
-    ]
   } else if (v8_current_cpu == "ppc64") {
     sources += [
       ### gcmole(ppc64) ###
@@ -6299,7 +6245,7 @@ v8_source_set("v8_base_without_compiler") {
   # Platforms that don't have CAS support need to link atomic library
   # to implement atomic memory access
   if (v8_current_cpu == "mips64" || v8_current_cpu == "mips64el" ||
-      v8_current_cpu == "ppc" || v8_current_cpu == "ppc64" ||
+      v8_current_cpu == "ppc64" ||
       (current_os != "zos" &&
        (v8_current_cpu == "s390" || v8_current_cpu == "s390x")) ||
       v8_current_cpu == "riscv64" || v8_current_cpu == "riscv32") {

include/v8-unwinder-state.h

@@ -18,9 +18,8 @@ struct CalleeSavedRegisters {
   void* arm_r10;
 };
 #elif V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_ARM64 ||     \
-    V8_TARGET_ARCH_MIPS64 || V8_TARGET_ARCH_PPC || V8_TARGET_ARCH_PPC64 ||     \
-    V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_S390 || V8_TARGET_ARCH_LOONG64 || \
-    V8_TARGET_ARCH_RISCV32
+    V8_TARGET_ARCH_MIPS64 || V8_TARGET_ARCH_PPC64 || V8_TARGET_ARCH_RISCV64 || \
+    V8_TARGET_ARCH_S390 || V8_TARGET_ARCH_LOONG64 || V8_TARGET_ARCH_RISCV32
 struct CalleeSavedRegisters {};
 #else
 #error Target architecture was not detected as supported by v8

include/v8config.h

@@ -829,9 +829,6 @@ V8 shared library set USING_V8_SHARED.
 #elif defined(__PPC64__) || defined(_ARCH_PPC64)
 #define V8_HOST_ARCH_PPC64 1
 #define V8_HOST_ARCH_64_BIT 1
-#elif defined(__PPC__) || defined(_ARCH_PPC)
-#define V8_HOST_ARCH_PPC 1
-#define V8_HOST_ARCH_32_BIT 1
 #elif defined(__s390__) || defined(__s390x__)
 #define V8_HOST_ARCH_S390 1
 #if defined(__s390x__)
@@ -858,10 +855,10 @@ V8 shared library set USING_V8_SHARED.
 // The macros may be set externally. If not, detect in the same way as the host
 // architecture, that is, target the native environment as presented by the
 // compiler.
-#if !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_ARM &&     \
-    !V8_TARGET_ARCH_ARM64 && !V8_TARGET_ARCH_MIPS64 && !V8_TARGET_ARCH_PPC && \
-    !V8_TARGET_ARCH_PPC64 && !V8_TARGET_ARCH_S390 &&                          \
-    !V8_TARGET_ARCH_RISCV64 && !V8_TARGET_ARCH_LOONG64 &&                     \
+#if !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_ARM && \
+    !V8_TARGET_ARCH_ARM64 && !V8_TARGET_ARCH_MIPS64 &&                    \
+    !V8_TARGET_ARCH_PPC64 && !V8_TARGET_ARCH_S390 &&                      \
+    !V8_TARGET_ARCH_RISCV64 && !V8_TARGET_ARCH_LOONG64 &&                 \
     !V8_TARGET_ARCH_RISCV32
 #if defined(_M_X64) || defined(__x86_64__)
 #define V8_TARGET_ARCH_X64 1
@@ -877,8 +874,6 @@ V8 shared library set USING_V8_SHARED.
 #define V8_TARGET_ARCH_LOONG64 1
 #elif defined(_ARCH_PPC64)
 #define V8_TARGET_ARCH_PPC64 1
-#elif defined(_ARCH_PPC)
-#define V8_TARGET_ARCH_PPC 1
 #elif defined(__s390__)
 #define V8_TARGET_ARCH_S390 1
 #if defined(__s390x__)
@@ -916,8 +911,6 @@ V8 shared library set USING_V8_SHARED.
 #define V8_TARGET_ARCH_64_BIT 1
 #elif V8_TARGET_ARCH_LOONG64
 #define V8_TARGET_ARCH_64_BIT 1
-#elif V8_TARGET_ARCH_PPC
-#define V8_TARGET_ARCH_32_BIT 1
 #elif V8_TARGET_ARCH_PPC64
 #define V8_TARGET_ARCH_64_BIT 1
 #elif V8_TARGET_ARCH_S390
@@ -982,12 +975,12 @@ V8 shared library set USING_V8_SHARED.
 #else
 #define V8_TARGET_LITTLE_ENDIAN 1
 #endif
-#elif defined(__BIG_ENDIAN__)  // FOR PPCGR on AIX
+#elif V8_TARGET_ARCH_PPC64
+#if V8_OS_AIX
 #define V8_TARGET_BIG_ENDIAN 1
-#elif V8_TARGET_ARCH_PPC_LE
+#else
 #define V8_TARGET_LITTLE_ENDIAN 1
-#elif V8_TARGET_ARCH_PPC_BE
-#define V8_TARGET_BIG_ENDIAN 1
+#endif
 #elif V8_TARGET_ARCH_S390
 #if V8_TARGET_ARCH_S390_LE_SIM
 #define V8_TARGET_LITTLE_ENDIAN 1

src/base/build_config.h

@@ -58,7 +58,7 @@ constexpr int kReturnAddressStackSlotCount =
     V8_TARGET_ARCH_STORES_RETURN_ADDRESS_ON_STACK ? 1 : 0;
 
 // Number of bits to represent the page size for paged spaces.
-#if (defined(V8_HOST_ARCH_PPC) || defined(V8_HOST_ARCH_PPC64)) && !defined(_AIX)
+#if defined(V8_HOST_ARCH_PPC64) && !defined(V8_OS_AIX)
 // Native PPC linux has large (64KB) physical pages.
 // Simulator (and Aix) need to use the same value as x64.
 constexpr int kPageSizeBits = 19;

src/base/compiler-specific.h

@@ -98,10 +98,9 @@
 // do not support adding noexcept to default members.
 // Disabled on MSVC because constructors of standard containers are not noexcept
 // there.
-#if ((!defined(V8_CC_GNU) && !defined(V8_CC_MSVC) &&                        \
-      !defined(V8_TARGET_ARCH_MIPS64) && !defined(V8_TARGET_ARCH_PPC) &&    \
-      !defined(V8_TARGET_ARCH_PPC64) && !defined(V8_TARGET_ARCH_RISCV64) && \
-      !defined(V8_TARGET_ARCH_RISCV32)) ||                                  \
+#if ((!defined(V8_CC_GNU) && !defined(V8_CC_MSVC) &&                           \
+      !defined(V8_TARGET_ARCH_MIPS64) && !defined(V8_TARGET_ARCH_PPC64) &&     \
+      !defined(V8_TARGET_ARCH_RISCV64) && !defined(V8_TARGET_ARCH_RISCV32)) || \
      defined(__clang__))
 #define V8_NOEXCEPT noexcept
 #else

src/base/cpu.cc

@@ -20,7 +20,7 @@
 #if V8_OS_QNX
 #include <sys/syspage.h>  // cpuinfo
 #endif
-#if V8_OS_LINUX && (V8_HOST_ARCH_PPC || V8_HOST_ARCH_PPC64)
+#if V8_OS_LINUX && V8_HOST_ARCH_PPC64
 #include <elf.h>
 #endif
 #if V8_OS_AIX
@@ -900,7 +900,7 @@ CPU::CPU()
 #endif  // V8_OS_IOS
 #endif  // V8_OS_WIN
 
-#elif V8_HOST_ARCH_PPC || V8_HOST_ARCH_PPC64
+#elif V8_HOST_ARCH_PPC64
 
 #ifndef USE_SIMULATOR
 #if V8_OS_LINUX

src/base/platform/platform-posix.cc

@@ -745,7 +745,7 @@ void OS::DebugBreak() {
   asm("break");
 #elif V8_HOST_ARCH_LOONG64
   asm("break 0");
-#elif V8_HOST_ARCH_PPC || V8_HOST_ARCH_PPC64
+#elif V8_HOST_ARCH_PPC64
   asm("twge 2,2");
 #elif V8_HOST_ARCH_IA32
   asm("int $3");

src/builtins/ppc/builtins-ppc.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#if V8_TARGET_ARCH_PPC || V8_TARGET_ARCH_PPC64
+#if V8_TARGET_ARCH_PPC64
 
 #include "src/api/api-arguments.h"
 #include "src/builtins/builtins-inl.h"
@@ -4263,4 +4263,4 @@ void Builtins::Generate_RestartFrameTrampoline(MacroAssembler* masm) {
 }  // namespace internal
 }  // namespace v8
 
-#endif  // V8_TARGET_ARCH_PPC64 || V8_TARGET_ARCH_PPC64
+#endif  // V8_TARGET_ARCH_PPC64

src/codegen/assembler-arch.h

@@ -15,7 +15,7 @@
 #include "src/codegen/arm64/assembler-arm64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "src/codegen/arm/assembler-arm.h"
-#elif V8_TARGET_ARCH_PPC || V8_TARGET_ARCH_PPC64
+#elif V8_TARGET_ARCH_PPC64
 #include "src/codegen/ppc/assembler-ppc.h"
 #elif V8_TARGET_ARCH_MIPS64
 #include "src/codegen/mips64/assembler-mips64.h"