Skip to content

Commit 3b8c624

Browse files
Jose Dapena PazCommit Bot
authored andcommitted
GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary
elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template parameter. But the declaration of the template method is in js-object.cc, so nobody can actually compile the version for number dictionary. This is fixed requesting explicit instantiation for NumberDictionary. This was breaking GCC build. Bug: chromium:819294 Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: José Dapena Paz <[email protected]> Cr-Commit-Position: refs/heads/master@{#62097}
1 parent bf3202c commit 3b8c624

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ NVIDIA Corporation <*@nvidia.com>
1515
BlackBerry Limited <*@blackberry.com>
1616
Opera Software ASA <*@opera.com>
1717
Intel Corporation <*@intel.com>
18+
LG Electronics, Inc. <*@lge.com>
1819
Microsoft <*@microsoft.com>
1920
MIPS Technologies, Inc. <*@mips.com>
2021
Imagination Technologies, LLC <*@imgtec.com>

src/objects/js-objects.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3753,6 +3753,10 @@ void JSObject::ApplyAttributesToDictionary(
37533753
}
37543754
}
37553755

3756+
template void JSObject::ApplyAttributesToDictionary(
3757+
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
3758+
const PropertyAttributes attributes);
3759+
37563760
template <PropertyAttributes attrs>
37573761
Maybe<bool> JSObject::PreventExtensionsWithTransition(
37583762
Handle<JSObject> object, ShouldThrow should_throw) {

0 commit comments

Comments
 (0)