Skip to content

Commit 1b51dca

Browse files
tzikCommit Bot
authored andcommitted
Add MicrotasksPolicy parameter on MicrotaskQueue constructor
MicrotasksPolicy was a missing functionality of MicrotaskQueue that was available on the per-Isolate MicrotaskQueue. This expose that as a construction time option. Change-Id: I22bcc8082ca64552d107ee6db138011654047861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559677 Reviewed-by: Ulan Degenbaev <[email protected]> Commit-Queue: Taiju Tsuiki <[email protected]> Cr-Commit-Position: refs/heads/master@{#60858}
1 parent 4269f23 commit 1b51dca

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

include/v8.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6768,7 +6768,8 @@ class V8_EXPORT MicrotaskQueue {
67686768
/**
67696769
* Creates an empty MicrotaskQueue instance.
67706770
*/
6771-
static std::unique_ptr<MicrotaskQueue> New(Isolate* isolate);
6771+
static std::unique_ptr<MicrotaskQueue> New(
6772+
Isolate* isolate, MicrotasksPolicy policy = MicrotasksPolicy::kAuto);
67726773

67736774
virtual ~MicrotaskQueue() = default;
67746775

src/api.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8935,8 +8935,12 @@ void v8::Isolate::LocaleConfigurationChangeNotification() {
89358935
}
89368936

89378937
// static
8938-
std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate) {
8939-
return i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));
8938+
std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate,
8939+
MicrotasksPolicy policy) {
8940+
auto microtask_queue =
8941+
i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));
8942+
microtask_queue->set_microtasks_policy(policy);
8943+
return microtask_queue;
89408944
}
89418945

89428946
MicrotasksScope::MicrotasksScope(Isolate* isolate, MicrotasksScope::Type type)

0 commit comments

Comments
 (0)