Made check on duplicate constructors more strict

PaulKlint · PaulKlint · commit ccafcef30512 · 2025-07-30T22:42:12.000+02:00
diff --git a/src/org/rascalmpl/compiler/lang/rascalcore/check/RascalConfig.rsc b/src/org/rascalmpl/compiler/lang/rascalcore/check/RascalConfig.rsc
@@ -479,7 +479,7 @@ void checkOverloading(map[str,Tree] namedTrees, Solver s){
             comparableList(t1.fields, t2.fields),
             ! (isSyntaxType(t1) && isSyntaxType(t2))){
 
-            if(t1.adt == t2.adt/*&& d1.scope == d2.scope*/){
+            if(t1.adt == t2.adt  && d1.scope.path == d2.scope.path){
                 s.addMessages([error("Constructor `<id>` overlaps with other declaration for type `<prettyAType(t1.adt)>`, see <allDefs - d.defined>", d.defined) | d <- defs ]);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,7 @@ void checkOverloading(map[str,Tree] namedTrees, Solver s){`
`479`	`479`	`comparableList(t1.fields, t2.fields),`
`480`	`480`	`! (isSyntaxType(t1) && isSyntaxType(t2))){`
`481`	`481`
`482`		`- if(t1.adt == t2.adt/&& d1.scope == d2.scope/){`
	`482`	`+ if(t1.adt == t2.adt && d1.scope.path == d2.scope.path){`
`483`	`483`	s.addMessages([error("Constructor `<id>` overlaps with other declaration for type `<prettyAType(t1.adt)>`, see <allDefs - d.defined>", d.defined) \| d <- defs ]);
`484`	`484`	`}`
`485`	`485`	`}`