Skip to content

Commit c46e755

Browse files
committed
Correct review comments.
1 parent aed0f0a commit c46e755

File tree

4 files changed

+41
-45
lines changed

4 files changed

+41
-45
lines changed

README.rst

Lines changed: 33 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -37,51 +37,49 @@ ticket list at https://github.com/uqfoundation/dill/issues.
3737
Major Features
3838
==============
3939

40-
`dill` can pickle the following standard types::
40+
`dill` can pickle the following standard types:
4141

42-
- none, type, bool, int, long, float, complex, str, unicode,
43-
- tuple, list, dict, file, buffer, builtin,
44-
- both old and new style classes,
45-
- instances of old and new style classes,
46-
- set, frozenset, array, functions, exceptions
42+
* none, type, bool, int, long, float, complex, str, unicode,
43+
* tuple, list, dict, file, buffer, builtin,
44+
* both old and new style classes,
45+
* instances of old and new style classes,
46+
* set, frozenset, array, functions, exceptions
4747

48-
`dill` can also pickle more 'exotic' standard types::
48+
`dill` can also pickle more 'exotic' standard types:
4949

50-
- functions with yields, nested functions, lambdas,
51-
- cell, method, unboundmethod, module, code, methodwrapper,
52-
- dictproxy, methoddescriptor, getsetdescriptor, memberdescriptor,
53-
- wrapperdescriptor, xrange, slice,
54-
- notimplemented, ellipsis, quit
50+
* functions with yields, nested functions, lambdas,
51+
* cell, method, unboundmethod, module, code, methodwrapper,
52+
* dictproxy, methoddescriptor, getsetdescriptor, memberdescriptor,
53+
* wrapperdescriptor, xrange, slice,
54+
* notimplemented, ellipsis, quit
5555

56-
`dill` cannot yet pickle these standard types::
56+
`dill` cannot yet pickle these standard types:
5757

58-
- frame, generator, traceback
58+
* frame, generator, traceback
5959

60-
`dill` also provides the capability to::
60+
`dill` also provides the capability to:
6161

62-
- save and load python interpreter sessions
63-
- save and extract the source code from functions and classes
64-
- interactively diagnose pickling errors
62+
* save and load python interpreter sessions
63+
* save and extract the source code from functions and classes
64+
* interactively diagnose pickling errors
6565

6666

6767
Current Release
6868
===============
6969

70-
This version is `dill-%(relver)s`.
70+
The latest released version of `dill` is available from:
7171

72-
The latest released version of `dill` is available from::
72+
* http://trac.mystic.cacr.caltech.edu/project/pathos
7373

74-
http://trac.mystic.cacr.caltech.edu/project/pathos
75-
76-
or::
74+
or:
7775

78-
https://github.com/uqfoundation/dill/releases
76+
* https://github.com/uqfoundation/dill/releases
7977

80-
or also::
78+
or also:
8179

82-
https://pypi.python.org/pypi/dill
80+
* https://pypi.python.org/pypi/dill
8381

84-
`dill` is distributed under a 3-clause BSD license.
82+
`dill` is distributed under a 3-clause BSD license::
8583

8684
>>> import dill
8785
>>> print (dill.license())
@@ -90,9 +88,9 @@ or also::
9088
Development Version
9189
===================
9290

93-
You can get the latest development version with all the shiny new features at::
91+
You can get the latest development version with all the shiny new features at:
9492

95-
https://github.com/uqfoundation
93+
* https://github.com/uqfoundation/dill/
9694

9795
If you have a new contribution, please submit a pull request.
9896

@@ -120,15 +118,15 @@ Alternately, `dill` can be installed with `pip` or `easy_install`::
120118
Requirements
121119
============
122120

123-
`dill` requires::
121+
`dill` requires:
124122

125-
- python2, version >= 2.5 *or* python3, version >= 3.1
126-
- pyreadline, version >= 1.7.1 (on windows)
123+
* python2, version >= 2.5 *or* python3, version >= 3.1
124+
* pyreadline, version >= 1.7.1 (on windows)
127125

128-
Optional requirements::
126+
Optional requirements:
129127

130-
- setuptools, version >= 0.6
131-
- objgraph, version >= 1.7.2
128+
* setuptools, version >= 0.6
129+
* objgraph, version >= 1.7.2
132130

133131

134132
More Information

dill/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ def extend(use_dill=True):
8282

8383
def license():
8484
"""print license"""
85-
print (__license__)
85+
print(__license__)
8686

8787
def citation():
8888
"""print citation"""
89-
print (__doc__[-501:-123])
89+
print(__doc__[-501:-123])
9090

9191
del odict

dill/unpickle.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@
55
# License: 3-clause BSD. The full license text is available at:
66
# - http://trac.mystic.cacr.caltech.edu/project/pathos/browser/dill/LICENSE
77

8+
from __future__ import print_function
9+
810
def main():
911
import sys
1012
from . import load
1113
for file in sys.argv[1:]:
12-
print load(open(file,'r'))
14+
print(load(open(file,'r')))
1315

1416
if __name__ == '__main__':
1517
main()

setup.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
with open(path.join(_here, 'README.rst')) as f:
2020
long_description = f.read()
2121

22-
install_requires = []
23-
2422
# build the 'setup' call
2523
setup(
2624
name='dill',
@@ -29,16 +27,13 @@
2927
'local_scheme': 'dirty-tag',
3028
'write_to': 'dill/_version.py'
3129
},
32-
setup_requires=['setuptools-scm>=1.6.0'],
3330
description='serialize all of python',
3431
long_description = long_description,
3532
author_email = 'mmckerns at uqfoundation dot org',
3633
maintainer = 'Mike McKerns',
3734
maintainer_email = 'mmckerns at uqfoundation dot org',
3835
license = '3-clause BSD',
39-
platforms = ['Linux', 'Windows', 'Mac'],
40-
url = 'http://www.cacr.caltech.edu/~mmckerns/dill.htm',
41-
download_url = 'http://dev.danse.us/packages',
36+
url = 'http://trac.mystic.cacr.caltech.edu/project/pathos/wiki/dill.html',
4237
classifiers = (
4338
'Development Status :: 5 - Production/Stable',
4439
'Intended Audience :: Developers',
@@ -54,7 +49,8 @@
5449
include_package_data=True,
5550
package_data={'': ['LICENSE', '*.rst']},
5651
zip_safe=False,
57-
install_requires=install_requires,
52+
install_requires=[],
53+
setup_requires=['setuptools-scm>=1.6.0'],
5854
extras_require={
5955
'optional': [
6056
'objgraph>=1.7.2',

0 commit comments

Comments
 (0)