tests: Use snprintf() instead of sprintf()

rootkea · rootkea · commit b71b80f7d18d · 2021-09-16T02:03:53.000+05:30
`man sprintf` suggests using snprintf() instead of sprintf()
diff --git a/tests/test-api-tagsOpen.c b/tests/test-api-tagsOpen.c
@@ -276,9 +276,9 @@ main (void)
 	for (int i = 0; i < 6; i++)
 	{
 		char tagf_name_tmpl [] = "./api-tagsOpen-incomplete-program-author-%d.tags";
-		char tagf_name [sizeof (tagf_name_tmpl)];
+		char tagf_name [sizeof (tagf_name_tmpl) - 1];
 		fprintf (stderr, "opening a tags file with incomplete PROGRAM_AUTHOR field [trimming level: %d]...", i);
-		sprintf (tagf_name, tagf_name_tmpl, i);
+		snprintf (tagf_name, sizeof (tagf_name), tagf_name_tmpl, i);
 		t = tagsOpen (tagf_name, &info);
 		if (t == NULL)
 		{

Original file line number	Diff line number	Diff line change
`@@ -276,9 +276,9 @@ main (void)`
`276`	`276`	`for (int i = 0; i < 6; i++)`
`277`	`277`	`{`
`278`	`278`	`char tagf_name_tmpl [] = "./api-tagsOpen-incomplete-program-author-%d.tags";`
`279`		`- char tagf_name [sizeof (tagf_name_tmpl)];`
	`279`	`+ char tagf_name [sizeof (tagf_name_tmpl) - 1];`
`280`	`280`	`fprintf (stderr, "opening a tags file with incomplete PROGRAM_AUTHOR field [trimming level: %d]...", i);`
`281`		`- sprintf (tagf_name, tagf_name_tmpl, i);`
	`281`	`+ snprintf (tagf_name, sizeof (tagf_name), tagf_name_tmpl, i);`
`282`	`282`	`t = tagsOpen (tagf_name, &info);`
`283`	`283`	`if (t == NULL)`
`284`	`284`	`{`