More Copy arguments (#2654)

Author: sffc

components/timezone/src/time_zone.rs

@@ -148,10 +148,10 @@ impl FromStr for CustomTimeZone {
     /// let tz3: CustomTimeZone =
     ///     "+02:30".parse().expect("Failed to parse a time zone.");
     ///
-    /// assert_eq!(tz0.gmt_offset.as_ref().map(GmtOffset::offset_seconds), Some(0));
-    /// assert_eq!(tz1.gmt_offset.as_ref().map(GmtOffset::offset_seconds), Some(7200));
-    /// assert_eq!(tz2.gmt_offset.as_ref().map(GmtOffset::offset_seconds), Some(-9000));
-    /// assert_eq!(tz3.gmt_offset.as_ref().map(GmtOffset::offset_seconds), Some(9000));
+    /// assert_eq!(tz0.gmt_offset.map(GmtOffset::offset_seconds), Some(0));
+    /// assert_eq!(tz1.gmt_offset.map(GmtOffset::offset_seconds), Some(7200));
+    /// assert_eq!(tz2.gmt_offset.map(GmtOffset::offset_seconds), Some(-9000));
+    /// assert_eq!(tz3.gmt_offset.map(GmtOffset::offset_seconds), Some(9000));
     /// ```
     fn from_str(input: &str) -> Result<Self, Self::Err> {
         let gmt_offset = input.parse::<GmtOffset>()?;

components/timezone/src/types.rs

@@ -46,27 +46,27 @@ impl GmtOffset {
     }
 
     /// Returns the raw offset value in seconds.
-    pub fn offset_seconds(&self) -> i32 {
+    pub fn offset_seconds(self) -> i32 {
         self.0
     }
 
     /// Returns `true` if the [`GmtOffset`] is positive, otherwise `false`.
-    pub fn is_positive(&self) -> bool {
+    pub fn is_positive(self) -> bool {
         self.0 >= 0
     }
 
     /// Returns `true` if the [`GmtOffset`] is zero, otherwise `false`.
-    pub fn is_zero(&self) -> bool {
+    pub fn is_zero(self) -> bool {
         self.0 == 0
     }
 
     /// Returns `true` if the [`GmtOffset`] has non-zero minutes, otherwise `false`.
-    pub fn has_minutes(&self) -> bool {
+    pub fn has_minutes(self) -> bool {
         self.0 % 3600 / 60 > 0
     }
 
     /// Returns `true` if the [`GmtOffset`] has non-zero seconds, otherwise `false`.
-    pub fn has_seconds(&self) -> bool {
+    pub fn has_seconds(self) -> bool {
         self.0 % 3600 % 60 > 0
     }
 }

provider/core/src/key.rs

@@ -49,7 +49,7 @@ macro_rules! tagged {
 pub struct DataKeyHash([u8; 4]);
 
 impl DataKeyHash {
-    const fn compute_from_path(path: &DataKeyPath) -> Self {
+    const fn compute_from_path(path: DataKeyPath) -> Self {
         let hash = helpers::fxhash_32(
             path.tagged.as_bytes(),
             leading_tag!().len(),
@@ -59,7 +59,7 @@ impl DataKeyHash {
     }
 
     /// Gets the hash value as a byte array.
-    pub const fn to_bytes(&self) -> [u8; 4] {
+    pub const fn to_bytes(self) -> [u8; 4] {
         self.0
     }
 }
@@ -139,7 +139,7 @@ pub struct DataKeyPath {
 impl DataKeyPath {
     /// Gets the path as a static string slice.
     #[inline]
-    pub const fn get(&self) -> &'static str {
+    pub const fn get(self) -> &'static str {
         /// core::slice::from_raw_parts(a, b) = core::mem::transmute((a, b)) hack
         /// ```compile_fail
         /// const unsafe fn canary() { core::slice::from_raw_parts(0 as *const u8, 0); }
@@ -277,7 +277,7 @@ impl DataKey {
     ///
     /// Useful for reading and writing data to a file system.
     #[inline]
-    pub const fn path(&self) -> DataKeyPath {
+    pub const fn path(self) -> DataKeyPath {
         self.path
     }
 
@@ -297,13 +297,13 @@ impl DataKey {
     /// assert_eq!(KEY_HASH.to_bytes(), [0xe2, 0xb6, 0x17, 0x71]);
     /// ```
     #[inline]
-    pub const fn hashed(&self) -> DataKeyHash {
+    pub const fn hashed(self) -> DataKeyHash {
         self.hash
     }
 
     /// Gets the metadata associated with this [`DataKey`].
     #[inline]
-    pub const fn metadata(&self) -> DataKeyMetadata {
+    pub const fn metadata(self) -> DataKeyMetadata {
         self.metadata
     }
 
@@ -328,7 +328,7 @@ impl DataKey {
     pub const fn from_path_and_metadata(path: DataKeyPath, metadata: DataKeyMetadata) -> Self {
         Self {
             path,
-            hash: DataKeyHash::compute_from_path(&path),
+            hash: DataKeyHash::compute_from_path(path),
             metadata,
         }
     }
@@ -373,7 +373,7 @@ impl DataKey {
 
         Ok(Self {
             path,
-            hash: DataKeyHash::compute_from_path(&path),
+            hash: DataKeyHash::compute_from_path(path),
             metadata,
         })
     }
@@ -453,8 +453,8 @@ impl DataKey {
     /// // The error context contains the argument:
     /// assert_eq!(FOO_BAR.match_key(BAR_BAZ).unwrap_err().key, Some(BAR_BAZ));
     /// ```
-    pub fn match_key(&self, key: Self) -> Result<(), DataError> {
-        if *self == key {
+    pub fn match_key(self, key: Self) -> Result<(), DataError> {
+        if self == key {
             Ok(())
         } else {
             Err(DataErrorKind::MissingDataKey.with_key(key))