List Classic: Todo List and Toggle List

[calebpitan]

I noticed that todo list was not included in the ListKit for list-classic plugin even though the plugin comes with a TodoListPlugin. However I tried to manually include the TodoListPlugin and configured it. While I could get it to work, it didn't work as the other lists.

• I observed that each item of the todo list were not grouped together and are being split into individual blocks
• And since that was the case, insertBreak on empty todo list item didn't exit the list block but instead added a new list block
• I also noticed that there's no implementation for toggle list in the list-classic kit, hence no KEYS.toggleClassic too

My questions are:

1. Is there any reason why todo list is not preconfigured in the list-classic kit
2. If we were to configure it manually, how could we go about it, to ensure it works as expected as this didn't work as expected:

TodoListPlugin.configure({
  node: { component: TodoListElement },
  shortcuts: { toggle: { keys: 'mod+alt+7' } },
}),

3. Is there any reason why toggle list can't be supported in list-classic

[zbeyens]

@dosu analyze how TodoListPlugin is incomplete yet

[calebpitan]

Okay. Understood. TodoList for list-classic is incomplete. Are there specifically any technical challenges that has hindered its development or it's just not prioritized right now? From where I stand, I think a todo list shouldn't be much different from an unordered list. I took a look at GH dom structure for it and it's just an unordered list with a list item with a checkbox input inside it and the text node. Maybe we can reuse ulClassic just with a different component that renders the checkbox inside of the list item.

What do you think?

Let me know if I'm missing anything.

Thank you!

[zbeyens]

Just not prioritized by Felix and I since we're using list, but it's open to contributions. Yes, it should be an alternative to lic component.

[calebpitan]

while i understand that list-classic has a more complex implementation and it’s hard to maintain complexity, i personally do not think list is a replacement for list-classic. i think they are both unique features to choose from based on needs. list can be too flexible. sometimes you don’t want that much power in the hands of product users, and you need to enforce certain style constraints, that’s where list-classic comes in.

i won’t mind contributing to ensure support for todo list classic too. could you point me in the direction to get started from for that feature?

[zbeyens]

@dosu Can you help?

[calebpitan]

Hi @zbeyens, this is the data structure I found in the editor:

I was hoping it would be wrapped in a list and probably a list item too. Meanwhile the DS for list is an lic wrapped in an li wrapped in an ol/ul

Is the action_item supposed to serve as the ul or li or lic itself?