Skip to content

Commit 3073f1b

Browse files
Googlercopybara-github
authored andcommitted
Remove should_lipo argument from the Starlark interface apple_common.link_multi_arch_binary.
This feature is already a no-op, and rules_apple no longer references this argument. PiperOrigin-RevId: 433056780
1 parent 8d92330 commit 3073f1b

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

src/main/java/com/google/devtools/build/lib/rules/objc/AppleStarlarkCommon.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,6 @@ public StructImpl linkMultiArchBinary(
261261
Sequence<?> extraLinkopts,
262262
Sequence<?> extraLinkInputs,
263263
StarlarkInt stamp,
264-
Boolean shouldLipo,
265264
StarlarkThread thread)
266265
throws EvalException, InterruptedException {
267266
try {

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/apple/AppleCommonApi.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -404,15 +404,6 @@ AppleExecutableBinaryApi newExecutableBinaryProvider(
404404
+ "If -1 (the default), then the behavior is determined by the --[no]stamp "
405405
+ "flag. This should be set to 0 when generating the executable output for "
406406
+ "test rules."),
407-
// TODO(b/63092114): Remove should_lipo when the Apple BUILD rules no longer use it.
408-
@Param(
409-
name = "should_lipo",
410-
named = true,
411-
positional = false,
412-
defaultValue = "False",
413-
doc =
414-
"No-op. Kept here for backwards compatibility. This field will be removed in a "
415-
+ "future release.")
416407
},
417408
useStarlarkThread = true)
418409
// TODO(b/70937317): Iterate on, improve, and solidify this API.
@@ -422,7 +413,6 @@ StructApi linkMultiArchBinary(
422413
Sequence<?> extraLinkopts, // <String> expected.
423414
Sequence<?> extraLinkInputs, // <? extends FileApi> expected.
424415
StarlarkInt stamp,
425-
Boolean shouldLipo,
426416
StarlarkThread thread)
427417
throws EvalException, InterruptedException;
428418

0 commit comments

Comments
 (0)