You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Loglens] Add overrideFatalWithError flag to LoglensAppender
**Problem**: There is an inconsistency in the way a `FileAppender` and a `LoglensHandler` produce levels for log records.
- LoglensHandler and LoglensFormatter use the `java.util.logging` package to build log records and transform them to `com.twitter.logging`, where the level `ERROR`/`SEVERE` is enumerated to be equivalent to level `FATAL`.
- Conversely, a FileAppender uses the `ch.qos.logback` package to produce records, where events with level `ERROR` are not transformed, and are written directly.
**Solution**: Add a flag for users to include in their `logback.xml` file to optionally override `FATAL` logs with the `ERROR` level, so that records sent to file and those sent to ClickHouse are consistent.
Differential Revision: https://phabricator.twitter.biz/D1250623
0 commit comments