Fix

Author: charlesBochet

packages/twenty-front/src/modules/object-metadata/utils/mapObjectMetadataToGraphQLQuery.ts

@@ -43,7 +43,7 @@ export const mapObjectMetadataToGraphQLQuery = ({
       return '';
     }
   }
-  // if (objectMetadataItem.nameSingular === 'pet') debugger;
+
   const manyToOneRelationFields = objectMetadataItem?.readableFields
     .filter((field) => field.isActive)
     .filter(
@@ -118,17 +118,10 @@ export const mapObjectMetadataToGraphQLQuery = ({
     }));
   });
 
-  const gqlFieldSet = new Set();
   const gqlFieldsWithFieldMetadata = [
     ...activeReadableFields,
     ...manyToOneRelationGqlFieldWithFieldMetadata,
-  ].filter((item) => {
-    if (gqlFieldSet.has(item.gqlField)) {
-      return false;
-    }
-    gqlFieldSet.add(item.gqlField);
-    return true;
-  });
+  ];
 
   const gqlFieldWithFieldMetadataThatCouldBeQueried =
     gqlFieldsWithFieldMetadata.sort(

packages/twenty-front/src/modules/object-record/hooks/useAttachMorphRelatedRecordFromRecord.ts

@@ -9,7 +9,6 @@ import { FieldContext } from '@/object-record/record-field/ui/contexts/FieldCont
 import { isFieldMorphRelation } from '@/object-record/record-field/ui/types/guards/isFieldMorphRelation';
 import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
 import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
-import { getMorphRelatedRecordFieldDefinition } from '@/object-record/utils/getMorphRelatedRecordFieldDefinition';
 import { useContext } from 'react';
 import { useRecoilCallback } from 'recoil';
 import { computeMorphRelationFieldName, isDefined } from 'twenty-shared/utils';
@@ -180,16 +179,6 @@ export const useAttachMorphRelatedRecordFromRecord = () => {
           fieldDefinition.metadata.morphRelations[0].sourceObjectMetadata
             .nameSingular;
 
-        const relatedRecordFieldDefinition =
-          getMorphRelatedRecordFieldDefinition({
-            fieldDefinition,
-            relatedObjectMetadataItem,
-          });
-
-        if (!isDefined(relatedRecordFieldDefinition)) {
-          throw new Error('Could not find related record field definition');
-        }
-
         const updatedManyRecordsArgs = [
           {
             idToUpdate: relatedRecordId,

packages/twenty-front/src/modules/object-record/hooks/useAttachRelatedRecordFromRecord.ts

@@ -10,7 +10,6 @@ import { useUpdateMultipleRecordsManyToOneObjects } from '@/object-record/hooks/
 import { FieldContext } from '@/object-record/record-field/ui/contexts/FieldContext';
 import { assertFieldMetadata } from '@/object-record/record-field/ui/types/guards/assertFieldMetadata';
 import { isFieldRelation } from '@/object-record/record-field/ui/types/guards/isFieldRelation';
-import { getRelatedRecordFieldDefinition } from '@/object-record/utils/getRelatedRecordFieldDefinition';
 import { useContext } from 'react';
 import { FieldMetadataType } from 'twenty-shared/types';
 import { CustomError, isDefined } from 'twenty-shared/utils';
@@ -128,15 +127,6 @@ export const useAttachRelatedRecordFromRecord = ({
       fieldDefinition,
     );
 
-    const relatedRecordFieldDefinition = getRelatedRecordFieldDefinition({
-      fieldDefinition: fieldDefinition,
-      relatedObjectMetadataItem,
-    });
-
-    if (!isDefined(relatedRecordFieldDefinition)) {
-      throw new Error('Could not find related record field definition');
-    }
-
     const updatedManyRecordsArgs = [
       {
         idToUpdate: relatedRecordId,

packages/twenty-front/src/modules/object-record/hooks/useDetachMorphRelatedRecordFromRecord.ts

@@ -11,7 +11,6 @@ import { FieldContext } from '@/object-record/record-field/ui/contexts/FieldCont
 import { isFieldMorphRelation } from '@/object-record/record-field/ui/types/guards/isFieldMorphRelation';
 import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
 import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
-import { getMorphRelatedRecordFieldDefinition } from '@/object-record/utils/getMorphRelatedRecordFieldDefinition';
 import { useContext } from 'react';
 import { useRecoilCallback } from 'recoil';
 import { computeMorphRelationFieldName, isDefined } from 'twenty-shared/utils';
@@ -167,16 +166,6 @@ export const useDetachMorphRelatedRecordFromRecord = () => {
           fieldDefinition.metadata.morphRelations[0].sourceObjectMetadata
             .nameSingular;
 
-        const relatedRecordFieldDefinition =
-          getMorphRelatedRecordFieldDefinition({
-            fieldDefinition,
-            relatedObjectMetadataItem,
-          });
-
-        if (!isDefined(relatedRecordFieldDefinition)) {
-          throw new Error('Could not find related record field definition');
-        }
-
         const updatedManyRecordsArgs = [
           {
             idToUpdate: relatedRecordId,

packages/twenty-front/src/modules/object-record/hooks/useDetachRelatedRecordFromRecord.ts

@@ -9,11 +9,8 @@ import { useUpdateMultipleRecordsManyToOneObjects } from '@/object-record/hooks/
 import { FieldContext } from '@/object-record/record-field/ui/contexts/FieldContext';
 import { assertFieldMetadata } from '@/object-record/record-field/ui/types/guards/assertFieldMetadata';
 import { isFieldRelation } from '@/object-record/record-field/ui/types/guards/isFieldRelation';
-import { getRelatedRecordFieldDefinition } from '@/object-record/utils/getRelatedRecordFieldDefinition';
 import { useContext } from 'react';
 import { FieldMetadataType } from 'twenty-shared/types';
-import { isDefined } from 'twenty-shared/utils';
-
 type useDetachRelatedRecordFromRecordProps = {
   recordObjectNameSingular: string;
   relationTargetGQLfieldName: string;
@@ -69,14 +66,6 @@ export const useDetachRelatedRecordFromRecord = ({
       isFieldRelation,
       fieldDefinition,
     );
-    const relatedRecordFieldDefinition = getRelatedRecordFieldDefinition({
-      fieldDefinition: fieldDefinition,
-      relatedObjectMetadataItem,
-    });
-
-    if (!isDefined(relatedRecordFieldDefinition)) {
-      throw new Error('Could not find related record field definition');
-    }
 
     modifyRecordFromCache({
       objectMetadataItem,

packages/twenty-front/src/modules/object-record/record-field/ui/form-types/components/FormSingleRecordPicker.tsx

@@ -18,7 +18,7 @@ import { css, useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
 import { isNonEmptyString } from '@sniptt/guards';
 import { useCallback, useId } from 'react';
-import { isDefined, isValidUuid } from 'twenty-shared/utils';
+import { CustomError, isDefined, isValidUuid } from 'twenty-shared/utils';
 import { IconChevronDown, IconForbid } from 'twenty-ui/display';
 
 const StyledFormSelectContainer = styled(FormFieldInputInnerContainer)<{
@@ -90,6 +90,13 @@ export const FormSingleRecordPicker = ({
         value: defaultValue || '',
       };
 
+  if (objectNameSingulars.length === 0) {
+    throw new CustomError(
+      'Object is missing while building form single record picker',
+      'FORM_SINGLE_RECORD_PICKER_OBJECT_NAME_SINGULAR_IS_MISSING',
+    );
+  }
+
   const { record: selectedRecord } = useFindOneRecord({
     objectRecordId:
       isDefined(defaultValue) && !isStandaloneVariableString(defaultValue)