Skip to content

Commit 2bcf465

Browse files
committed
Fixes
1 parent 152f972 commit 2bcf465

File tree

3 files changed

+26
-37
lines changed

3 files changed

+26
-37
lines changed

packages/twenty-front/src/modules/debug/components/RecoilDebugObserver.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const formatTitle = (stateName: string) => {
1414
};
1515

1616
export const RecoilDebugObserverEffect = () => {
17-
const isDebugMode = false;
17+
const isDebugMode = process.env.IS_DEBUG_MODE === 'true';
1818

1919
useRecoilTransactionObserver_UNSTABLE(({ snapshot }) => {
2020
if (!isDebugMode) {

packages/twenty-front/src/modules/object-record/record-table/virtualization/components/RecordTableVirtualizedRowTreadmillEffect.tsx

Lines changed: 25 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,30 @@ export const RecordTableVirtualizedRowTreadmillEffect = () => {
245245
],
246246
);
247247

248+
const handleAfterLastScroll = useRecoilCallback(
249+
({ set }) =>
250+
(scrollEvent: Event) => {
251+
deactivateLowDetails();
252+
253+
handleScroll(scrollEvent);
254+
255+
triggerFetchPages();
256+
257+
set(lastScrollMeasurementsCallbackState, []);
258+
},
259+
[
260+
handleScroll,
261+
triggerFetchPages,
262+
deactivateLowDetails,
263+
lastScrollMeasurementsCallbackState,
264+
],
265+
);
266+
267+
const handleAfterLastScrollDebounced = useDebouncedCallback(
268+
handleAfterLastScroll,
269+
LAST_SCROLL_DEBOUNCE_TIME,
270+
);
271+
248272
const handleScrollData = useRecoilCallback(
249273
({ snapshot, set }) =>
250274
(scrollEvent: Event) => {
@@ -304,21 +328,16 @@ export const RecordTableVirtualizedRowTreadmillEffect = () => {
304328
const averageScrollSpeedInRowsPerSecond =
305329
averageScrollSpeedInPixelsPerSecond / (RECORD_TABLE_ROW_HEIGHT + 1);
306330

307-
console.log(averageScrollSpeedInRowsPerSecond);
308-
309331
if (
310332
averageScrollSpeedInRowsPerSecond >
311333
SCROLL_SPEED_THRESHOLD_IN_ROWS_PER_SECOND_TO_ACTIVATE_LOW_DETAILS
312334
) {
313-
// console.log('activate');
314335
activateLowDetails();
315336
handleAfterLastScrollDebounced.cancel();
316337
} else if (
317338
averageScrollSpeedInRowsPerSecond <
318339
SCROLL_SPEED_THRESHOLD_IN_ROWS_PER_SECOND_TO_DEACTIVATE_LOW_DETAILS
319340
) {
320-
console.log('deactivating');
321-
322341
deactivateLowDetailsDebounced();
323342

324343
triggerFetchPages();
@@ -332,34 +351,10 @@ export const RecordTableVirtualizedRowTreadmillEffect = () => {
332351
triggerFetchPages,
333352
activateLowDetails,
334353
deactivateLowDetailsDebounced,
354+
handleAfterLastScrollDebounced,
335355
],
336356
);
337357

338-
const handleAfterLastScroll = useRecoilCallback(
339-
({ set }) =>
340-
(scrollEvent: Event) => {
341-
console.log('after last scroll');
342-
deactivateLowDetails();
343-
344-
handleScroll(scrollEvent);
345-
346-
triggerFetchPages();
347-
348-
set(lastScrollMeasurementsCallbackState, []);
349-
},
350-
[
351-
handleScroll,
352-
triggerFetchPages,
353-
deactivateLowDetails,
354-
lastScrollMeasurementsCallbackState,
355-
],
356-
);
357-
358-
const handleAfterLastScrollDebounced = useDebouncedCallback(
359-
handleAfterLastScroll,
360-
LAST_SCROLL_DEBOUNCE_TIME,
361-
);
362-
363358
const handleScrollEvent = useCallback(
364359
(scrollEvent: Event) => {
365360
handleScrollData(scrollEvent);

packages/twenty-server/src/engine/api/graphql/graphql-query-runner/resolvers/graphql-query-find-many-resolver.service.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,6 @@ export class GraphqlQueryFindManyResolverService extends GraphqlQueryBaseResolve
9494
: { or: cursorArgFilter }) as unknown as ObjectRecordFilter;
9595
}
9696

97-
console.log({
98-
appliedFilters,
99-
});
100-
10197
executionArgs.graphqlQueryParser.applyFilterToBuilder(
10298
queryBuilder,
10399
objectMetadataNameSingular,
@@ -144,8 +140,6 @@ export class GraphqlQueryFindManyResolverService extends GraphqlQueryBaseResolve
144140
.take(limit + 1)
145141
.getMany()) as ObjectRecord[];
146142

147-
console.log({ query: queryBuilder.getQueryAndParameters() });
148-
149143
const { hasNextPage, hasPreviousPage } = getPaginationInfo(
150144
objectRecords,
151145
limit,

0 commit comments

Comments
 (0)