update to provenance trait

Author: molpopgen

src/provenance.rs

@@ -100,7 +100,7 @@ pub trait Provenance: crate::TableAccess {
     /// # Parameters
     ///
     /// * `record`: the provenance record
-    fn add_provenance(&mut self, record: &str) -> crate::TskReturnValue;
+    fn add_provenance(&mut self, record: &str) -> Result<ProvenanceId, TskitError>;
     /// Return an immutable reference to the table, type [`ProvenanceTable`]
     fn provenances(&self) -> ProvenanceTable;
     /// Return an iterator over the rows of the [`ProvenanceTable`].

src/table_collection.rs

@@ -633,7 +633,7 @@ impl crate::traits::NodeListGenerator for TableCollection {}
 
 #[cfg(any(doc, feature = "provenance"))]
 impl crate::provenance::Provenance for TableCollection {
-    fn add_provenance(&mut self, record: &str) -> TskReturnValue {
+    fn add_provenance(&mut self, record: &str) -> Result<crate::ProvenanceId, TskitError> {
         if record.is_empty() {
             return Err(TskitError::ValueError {
                 got: String::from("empty string slice"),
@@ -650,7 +650,7 @@ impl crate::provenance::Provenance for TableCollection {
                 record.len() as tsk_size_t,
             )
         };
-        handle_tsk_return_value!(rv)
+        handle_tsk_return_value!(rv, crate::ProvenanceId::from(rv))
     }
 
     fn provenances(&self) -> crate::provenance::ProvenanceTable {

src/trees.rs

@@ -1135,7 +1135,7 @@ impl crate::traits::NodeListGenerator for TreeSequence {}
 
 #[cfg(any(doc, feature = "provenance"))]
 impl crate::provenance::Provenance for TreeSequence {
-    fn add_provenance(&mut self, record: &str) -> TskReturnValue {
+    fn add_provenance(&mut self, record: &str) -> Result<crate::ProvenanceId, TskitError> {
         if record.is_empty() {
             return Err(TskitError::ValueError {
                 got: String::from("empty string slice"),
@@ -1152,7 +1152,7 @@ impl crate::provenance::Provenance for TreeSequence {
                 record.len() as tsk_size_t,
             )
         };
-        handle_tsk_return_value!(rv)
+        handle_tsk_return_value!(rv, crate::ProvenanceId::from(rv))
     }
 
     fn provenances(&self) -> crate::provenance::ProvenanceTable {