-
Notifications
You must be signed in to change notification settings - Fork 17
Description
Hi, i just tried hanabira, and so far it is pretty good, but some things could be improved.
The user system is still non-existent, but some pages require the user to click the "Login" button to work. (Well, this is obvious for the current build; I'm just mentioning this for note.)
Installation using docker-compose is a bit tricky. I encountered some problems trying to up-ing it, and I need to tweak some parts.
For example, the only required exposed port is 80 from the nginx container; the other containers can communicate with each other without exposing their ports to the host as long as they are under one stack and bridged virtual connection.
I don't understand why you put the nginx conf file separated and must be provided using exposed volume instead of embedding it to the container?
For the dictionary container, it would be nice if instead of reading from the config.json file, it should be able to be set using docker ENV vars. also currently, when deepl API key is not provided, the dictionary container itself would be up, but the server within it is crashed complaining about "deepl key cannot be blank", this would cripled most part of the web-app. It would be nice if the stacks could gracefully handle this, for example, by putting a health-check script in the nginx container to test if its dependencies server is up. Or even better, allow the app to be run without deepl key but with reduced functionality.
It would be nice if there were some kind of toggles, like ENV vars (or later, it might be some kind of admin panel) to disable some features, like disable Korean/Japanese language, disable Youtube section, etc, to reduce the portal clutters, some people may only want to focus to one languages instead of all of the offered. Another example, the "Download" button is unnecessary