fix: Repositories not detected in software-protperties-gtk

BREAKING CHANGES:
- Changes repository `.list` file prefix from `adter-effects:` to `after-effects-`. This has unintended side effect of adding repositories multiple times if you ever run older versions or did run older version of this script.
- Migration: Rename existing list files with prefix `after-effecs:` to `after-efects-`. This shuld be done before running this script.

Author: tprasadtp

after-effects

@@ -18,7 +18,7 @@ readonly SCRIPT=$(basename "$0")
 readonly dir=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
 
 # Version
-readonly AE_VERSION="8.0.0"
+readonly AE_VERSION="8.0.1"
 
 # Handle Use interrupt
 # trap ctrl-c and call ctrl_c()
@@ -1568,7 +1568,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         --file-prefix "spotify" \
         --key-url https://download.spotify.com/debian/pubkey_0D811D58.gpg
 
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/spotify.gpg] http://repository.spotify.com stable non-free #Spotify" > ${SOURCES_FILE_DIR}/after-effects:spotify.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/spotify.gpg] http://repository.spotify.com stable non-free #Spotify" > ${SOURCES_FILE_DIR}/after-effects-spotify.list; then
         log_success "OK"
       else
         log_error "Adding Spotify Repository Failed"
@@ -1586,7 +1586,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         --file-prefix "skype" \
         --key-url https://repo.skype.com/data/SKYPE-GPG-KEY
 
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/skype.gpg] https://repo.skype.com/deb stable main #Skype" > $SOURCES_FILE_DIR/after-effects:skype.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/skype.gpg] https://repo.skype.com/deb stable main #Skype" > ${SOURCES_FILE_DIR}/after-effects-skype.list; then
         log_success "OK"
       else
         log_error "Adding Skype for linux repository failed"
@@ -1603,7 +1603,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         --file-prefix "signal-desktop" \
         --key-url https://updates.signal.org/desktop/apt/keys.asc
 
-      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/signal-desktop.gpg] https://updates.signal.org/desktop/apt xenial main #Signal-for-Desktop"  > ${SOURCES_FILE_DIR}/after-effects:signal.list; then
+      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/signal-desktop.gpg] https://updates.signal.org/desktop/apt xenial main #Signal-for-Desktop"  > ${SOURCES_FILE_DIR}/after-effects-signal.list; then
         log_success "OK"
       else
         log_error "Failed to addd Signal for desktop repository!"
@@ -1639,7 +1639,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         __add_repo_keys --format "asc" \
           --file-prefix "wine-hq" \
           --key-url https://dl.winehq.org/wine-builds/winehq.key
-        if echo "deb [signed-by=${TRUSTED_KEYRINGS_DIR}/wine-hq.gpg] https://dl.winehq.org/wine-builds/${distro_name}/ ${code_name} main #WineHQ" > ${SOURCES_FILE_DIR}/after-effects:winehq.list; then
+        if echo "deb [signed-by=${TRUSTED_KEYRINGS_DIR}/wine-hq.gpg] https://dl.winehq.org/wine-builds/${distro_name}/ ${code_name} main #WineHQ" > ${SOURCES_FILE_DIR}/after-effects-winehq.list; then
           log_success "OK"
         else
           log_error "Adding WineHQ repository failed"
@@ -1670,7 +1670,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
   # Google Cloud SDK
   if [ "$add_gcp_repo" == "true" ]; then
     log_info "Google-Cloud-SDK"
-    if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/google-cloud-packaging.gpg] http://packages.cloud.google.com/apt cloud-sdk main #Google-Cloud-SDK" > ${SOURCES_FILE_DIR}/after-effects:googlecloud.list; then
+    if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/google-cloud-packaging.gpg] http://packages.cloud.google.com/apt cloud-sdk main #Google-Cloud-SDK" > ${SOURCES_FILE_DIR}/after-effects-googlecloud.list; then
       log_success "OK"
     else
       log_error "Adding Google Cloud SDK Repository failed"
@@ -1684,7 +1684,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
 
     if [[ $ARCH == "amd64" ]]; then
       log_info "GCSFUSE"
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/google-cloud-packaging.gpg] http://packages.cloud.google.com/apt gcsfuse-${code_name} main #GCSFUSE" > ${SOURCES_FILE_DIR}/after-effects:gcsfuse.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/google-cloud-packaging.gpg] http://packages.cloud.google.com/apt gcsfuse-${code_name} main #GCSFUSE" > ${SOURCES_FILE_DIR}/after-effects-gcsfuse.list; then
         log_success "OK"
       else
         log_error "Adding GCSFUSE repository failed"
@@ -1712,7 +1712,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
   if [[ ${add_vscode_repo} == "true"  ]]; then
     log_info "VSCode"
     if [[ ${ARCH} == "amd64" ]]; then
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/vscode stable main #Visual-Studio-Code" > ${SOURCES_FILE_DIR}/after-effects:vscode.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/vscode stable main #Visual-Studio-Code" > ${SOURCES_FILE_DIR}/after-effects-vscode.list; then
         log_success "OK"
       else
         log_error "Failed to addd VSCode repository!"
@@ -1730,7 +1730,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
   if [[ ${add_azurecli_repo} == "true"  ]] ; then
     if [[ ${ARCH} == "amd64" ]]; then
       log_info "Azure CLI"
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/azure-cli/ ${code_name} main #Azure CLI" > ${SOURCES_FILE_DIR}/after-effects:azurecli.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/azure-cli/ ${code_name} main #Azure CLI" > ${SOURCES_FILE_DIR}/after-effects-azurecli.list; then
         log_success "OK"
       else
         log_error "Failed to addd Azure CLI repository!"
@@ -1747,7 +1747,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
   if [[ ${add_edge_repo} == "true"  ]] ; then
     if [[ ${ARCH} == "amd64" ]]; then
       log_info "Microsoft Edge"
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/edge stable main #Microsoft Edge" > ${SOURCES_FILE_DIR}/after-effects:edge.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/edge stable main #Microsoft Edge" > ${SOURCES_FILE_DIR}/after-effects-edge.list; then
         log_success "OK"
       else
         log_error "Failed to addd Microsoft Edge repository!"
@@ -1763,7 +1763,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
   if [[ ${add_msteams_repo} == "true"  ]] ; then
     if [[ ${ARCH} == "amd64" ]]; then
       log_info "Microsoft Teams"
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/ms-teams stable main #Microsoft Edge" > ${SOURCES_FILE_DIR}/after-effects:teams.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/microsoft.gpg] https://packages.microsoft.com/repos/ms-teams stable main #Microsoft Edge" > ${SOURCES_FILE_DIR}/after-effects-teams.list; then
         log_success "OK"
       else
         log_error "Failed to addd Microsoft Teams repository!"
@@ -1783,7 +1783,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
       --key-url https://download.docker.com/linux/"${distro_name}"/gpg
     log_debug "Adding Docker(Docker Inc) sources .list"
 
-    if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/docker-ce.gpg] https://download.docker.com/linux/${distro_name}  ${code_name} stable #Docker-Community-Edition" > ${SOURCES_FILE_DIR}/after-effects:docker.list; then
+    if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/docker-ce.gpg] https://download.docker.com/linux/${distro_name}  ${code_name} stable #Docker-Community-Edition" > ${SOURCES_FILE_DIR}/after-effects-docker.list; then
       log_success "OK"
     else
       log_error "Adding Docker-CE repository failed"
@@ -1802,7 +1802,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
     apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys C99B11DEB97541F0 |& log_trace "${_phase_apt_key}" \
    || log_error "Adding Github CLI keys failed"
 
-    if echo "deb https://cli.github.com/packages  ${code_name}  main #GitHub-CLI" > ${SOURCES_FILE_DIR}/after-effects:github.list; then
+    if echo "deb https://cli.github.com/packages  ${code_name}  main #GitHub-CLI" > ${SOURCES_FILE_DIR}/after-effects-github.list; then
       log_success "OK"
     else
       log_error "Adding GH CLi repository failed"
@@ -1820,7 +1820,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         --file-prefix "hashicorp" \
         --key-url https://apt.releases.hashicorp.com/gpg
 
-      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/hashicorp.gpg] https://apt.releases.hashicorp.com ${code_name} main#Hashicorp-Packages" > ${SOURCES_FILE_DIR}/after-effects:hashicorp.list; then
+      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/hashicorp.gpg] https://apt.releases.hashicorp.com ${code_name} main#Hashicorp-Packages" > ${SOURCES_FILE_DIR}/after-effects-hashicorp.list; then
         log_success "OK"
       else
         log_error "Failed to add hashicorp repository"
@@ -1841,7 +1841,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         --file-prefix "bazel" \
         --key-url https://bazel.build/bazel-release.pub.gpg
 
-      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/bazel.gpg] https://storage.googleapis.com/bazel-apt stable jdk1.8 #Bazel" > ${SOURCES_FILE_DIR}/after-effects:bazel.list; then
+      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/bazel.gpg] https://storage.googleapis.com/bazel-apt stable jdk1.8 #Bazel" > ${SOURCES_FILE_DIR}/after-effects-bazel.list; then
         log_success "OK"
       else
         log_error "Failed to add bazel repository"
@@ -1866,7 +1866,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         --file-prefix "gvisor" \
         --key-url https://gvisor.dev/archive.key
 
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/gvisor.gpg] https://storage.googleapis.com/gvisor/releases release main #gVisor-Container-Runtime"  > ${SOURCES_FILE_DIR}/after-effects:gvisor.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/gvisor.gpg] https://storage.googleapis.com/gvisor/releases release main #gVisor-Container-Runtime"  > ${SOURCES_FILE_DIR}/after-effects-gvisor.list; then
         log_success "OK"
       else
         log_error "Adding gVisor repository failed!"
@@ -1891,7 +1891,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
       __add_repo_keys --format "asc" \
         --file-prefix "obs-podman-${code_name}" \
         --key-url https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/${AE_OBS_PREFIX}/Release.key
-      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/obs-podman-${code_name}.gpg] https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/${AE_OBS_PREFIX}/ / #Podman (via OBS)"  > ${SOURCES_FILE_DIR}/after-effects:podman.list; then
+      if echo "deb [arch=$ARCH signed-by=${TRUSTED_KEYRINGS_DIR}/obs-podman-${code_name}.gpg] https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/${AE_OBS_PREFIX}/ / #Podman (via OBS)"  > ${SOURCES_FILE_DIR}/after-effects-podman.list; then
         log_success "OK"
       else
         log_error "Adding Podman repository failed!"
@@ -1919,7 +1919,7 @@ deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main"
         --file-prefix "sublimetext" \
         --key-url https://download.sublimetext.com/sublimehq-pub.gpg
 
-      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/sublimetext.gpg] https://download.sublimetext.com/ apt/stable/ #SublimeText Editor" > ${SOURCES_FILE_DIR}/after-effects:sublimetext.list; then
+      if echo "deb [arch=amd64 signed-by=${TRUSTED_KEYRINGS_DIR}/sublimetext.gpg] https://download.sublimetext.com/ apt/stable/ #SublimeText Editor" > ${SOURCES_FILE_DIR}/after-effects-sublimetext.list; then
         log_success "OK"
       else
         log_error "Failed to add SublimeText repository"

after-effects.asc

@@ -1,16 +1,16 @@
 -----BEGIN PGP SIGNATURE-----
 
-iQIzBAABCgAdFiEE8FV2m9/w2tr5gevHB8IBTKWxN9gFAmCb4/sACgkQB8IBTKWx
-N9hoxQ/8C3xLgD3FhFO/QbF/fo0JiVvugSmMiz6W8QpBAoobNpOjbT1NI53RW+6r
-gDFsbpKsO+jwNNRcUMG5VaWc0cJaHN4e6FLhaIoNcZrrnUypaDSpZKL2oZ4WnB5Z
-PuLWU+wikEomp1igauROV3utw9athPGUPt0kOIU9s7bfV39KqkDScPlIFj7EiETq
-af7mcSk+aAXB2xrkvmnOcuqOnDQT2Gz/4m/lhpuGbHeL31bLWINjPbcKa62GDMDo
-OGeaz2/yRsh2Aj5YCdVtlqGyVKbIrbx8EOj5Dms1aisZ/GylscpqB8AdjIiozYd0
-4vEo1Y3n7eUJFnUwYMWXScTY1O0SC0K1cGHJwF7jzRb3K7v6SpRX8vtqd/sGzm72
-p3Dd5SELMBcfDV9sDNEny3BnR+hDGFkaSbqG0Uila7d1LBls1XOmQt3wbtfYyFAT
-uEypDD0MLS6qsOwsqPCrku8BWCImnqssfeOsEl+AIQlOjW7SEEhcCBI3ZTfdVjQZ
-0+TT8gcsg6E0plmHCLRTSqQ6WFQPDc2IzJw0ATPhdrSOcbstsZ2ocG4XNYzYZJRt
-HArXTFGeO5ZKn9c+3U9HO3PpTCp9IALI/Ip1dQkoOmMK8m6lAH5fMGtbTLN4GG5V
-br51nb/CJTVbpVbbTCCY3EDsDS+3xTLdpkUoSw1WGGCiMgDKFPg=
-=YmYu
+iQIzBAABCgAdFiEE8FV2m9/w2tr5gevHB8IBTKWxN9gFAmClW4cACgkQB8IBTKWx
+N9i6dA//XGH6244VKdNGgBwfNQKZ1+mh0XsModdwjhDcdPrlCN738EKoBH4rK/8F
+CmmVmHHOxxUFMOvbLcLUd/+NkpoTGb0oTGI8s7LaUo5BszTa15hFj3U2ob982mdA
+Qlc4BMUvs3pf+hV43nUtk/sbL70n6PDAaDAuVwOvvdyHrojz2kpgCgGJIbIszE7e
+y+xe6HnTra2BMtGYWnJaUUOhOEp6ON/6mQUrwDhtrKItR21gZb3nrhwa0FLV2g2Z
+NuJMrfDG/mD+BC6F0K1lObGsAAWWguOBDdOR9ve/94ROOn0GGcd/4tFAua+1TSkj
+lSq74d3FynHjXhOcPj74zeh+Gl3L4FsutsMBpFWOXC17pAj3rmE10jRmTK35URUj
++AElLHzRptb30yaRFlneLtXe9XG+bQAClz7UeoWbdUR3AdyAdNqqbCCJ4WcxJR6Q
+D2GAYN+XcXsU7oNulWz0zNwAeJRe9x51uh2BSk1tzDRNTk7gQT6F/vo2Disgj+Yn
+66T/uTiD+ldi6hC1FTLbNuy6Qx+ENWr0SlNXHUUrLxufbkaORRjkfOPOSM2g4Xjn
+Vi83BCFP7T8NkMKPFQzF3DqX9GqWprvFWyBQJbBrc30Ef7rWMP9lJ54JsnqVn8ZM
+5RnfRNQHxvwxiQTTVFHksP+8FjMUusoqwloArXQHlfENF8M/mYQ=
+=R40h
 -----END PGP SIGNATURE-----

config/version.yml

@@ -1,8 +1,8 @@
-# This file is required because of legacy update checks use this file.
+# This file is required because, legacy update checks use this file.
 # Netlify should handle the redirects from get/v3/version endpoints.
-# This is setup in such a way to force user to upgrade the script,
-# without breaking older versions.
-# Updated versions of the script uses GitHub v3 API endpoints.
+# This config is setup in such a way, that user is to forced to
+# upgrade the script, without breaking update check mechanisms.
+# Updated versions of the script uses GitHub v3 releases API.
 version:
   number: 65500
-  name: FORCE-UPDATE-TO-8.0.0-AND-ABOVE
+  name: FORCE-UPDATE-TO-8.0.1-AND-ABOVE

docs/tasks.md

@@ -153,7 +153,7 @@ config:
 
 ## Install Static binaries to /usr/local/bin
 
-This will install binaries `bin.list` or YAML config under `config.install.binaries`.
+This will install binaries in YAML config under `config.install.binaries`.
 
 - **Simulate** option **will** download the package but not install it.
 - Configuration is similar to deb files mentioned above. First part is the URL to the binary file followed by ',' and name of the binary.
@@ -175,7 +175,7 @@ config:
 This will purge Unwanted packages from the system.
 
 - The packages mentioned in `config.purge` in yaml.
-- The format of the purge.list is similar to that of packages, one package per line
+- The format is similar to that of packages, one package per line
 
 !!! warning
     It is necessary to pass command line argument `-d` or  set `config.flags.purge_enabled: true` in config.

tests/local.sh

@@ -119,7 +119,6 @@ function main()
       # turn on trace
       set -x
       docker run --rm \
-        --userns=host \
         "${DOCKER_RUN_ARGS[@]}" \
         -e CI \
         -e GITHUB_ACTIONS \