Skip to content

Commit 872a719

Browse files
committed
helm: tidy BUILD files, move rules to helm subdirectory
1 parent ed1108d commit 872a719

File tree

9 files changed

+26
-35
lines changed

9 files changed

+26
-35
lines changed

BUILD

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -24,31 +24,3 @@ sh_test(
2424
".dummy_test.sh",
2525
],
2626
)
27-
28-
load("@io_bazel_skydoc//stardoc:stardoc.bzl", "stardoc")
29-
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
30-
31-
# package(default_visibility = ["//visibility:public"])
32-
package(default_visibility = ["//visibility:public"])
33-
34-
load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
35-
36-
bzl_library(
37-
38-
name = "skylib_paths",
39-
srcs = ["@bazel_skylib//lib:paths.bzl"],
40-
)
41-
# bzl_library(
42-
# name = "bazel_tools_pkg",
43-
# srcs = ["@bazel_tools//tools:srcs"],
44-
# )
45-
46-
stardoc(
47-
name = "docs",
48-
out = "docs.md",
49-
input = "helm.bzl",
50-
deps = [
51-
":skylib_paths",
52-
# ":bazel_tools_pkg",
53-
],
54-
)

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ all: docs ci
1010

1111
.PHONY: docs
1212
docs: deps
13-
bazel build //:docs && cp bazel-bin/docs.md .
14-
@chmod +w docs.md
13+
bazel build //docs && cp bazel-bin/docs/docs.md docs
14+
@chmod +w docs/docs.md
1515

1616
.PHONY: deps
1717
ifeq ($(UNAME),Darwin)

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This allows you to describe Kubernetes applications in a deterministic manner.
1010

1111
## Documentation
1212

13-
* See [Rule and macro defintions](./docs.md) for macro documentation.
13+
* See [Rule and macro defintions](./docs/docs.md) for macro documentation.
1414

1515
### API
1616

@@ -24,7 +24,7 @@ In your Bazel `WORKSPACE` file add this repository as a dependency:
2424
```
2525
git_repository(
2626
name = "com_github_tmc_rules_helm",
27-
tag = "0.1.0",
27+
tag = "0.2.0",
2828
remote = "https://github.com/tmc/rules_helm.git",
2929
)
3030
```

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load(":repos.bzl", "helm_repositories")
44

55
helm_repositories()
66

7-
load(":buildifier.bzl", "buildifier_repositories")
7+
load("//tools:buildifier.bzl", "buildifier_repositories")
88
buildifier_repositories()
99

1010
# Start stardoc rules

docs/BUILD

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
load("@io_bazel_skydoc//stardoc:stardoc.bzl", "stardoc")
2+
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
3+
4+
package(default_visibility = ["//visibility:public"])
5+
6+
load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
7+
8+
bzl_library(
9+
name = "skylib_paths",
10+
srcs = ["@bazel_skylib//lib:paths.bzl"],
11+
)
12+
13+
stardoc(
14+
name = "docs",
15+
out = "docs.md",
16+
input = "//helm:helm.bzl",
17+
deps = [
18+
":skylib_paths",
19+
],
20+
)

docs.md renamed to docs/docs.md

File renamed without changes.

helm/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
exports_files(["helm.bzl"])

helm.bzl renamed to helm/helm.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ def helm_chart(name, srcs, update_deps = False):
2020
srcs: Source files to include as the helm chart. Typically this will just be glob(["**"]).
2121
update_deps: Whether or not to run a helm dependency update prior to packaging.
2222
"""
23-
format: The format to write the Rat check report in.
24-
visibility: The visibility of this rule.
2523
filegroup_name = name + "_filegroup"
2624
helm_cmd_name = name + "_package.sh"
2725
package_flags = ""
File renamed without changes.

0 commit comments

Comments
 (0)