Remove hypercore table access method

The hypercore table access method was an experiment that did not
show the signals we hoped for so with 2.22 it will no longer be
available. Any upgrade from previous versions with relations using
the hypercore table access method will be blocked.

Author: svenklemm

.github/workflows/linux-32bit-build-and-test.yaml

@@ -59,9 +59,6 @@ jobs:
           compress_bloom_sparse_debug
           compress_qualpushdown_saop
           compression_allocation
-          hypercore_parallel
-          hypercore_vacuum
-          hypercore_vectoragg
           pg_dump
           telemetry
           transparent_decompress_chunk-*

.github/workflows/windows-build-and-test.yaml

@@ -87,7 +87,6 @@ jobs:
       SKIPS: >-
         bgw_db_scheduler
         bgw_db_scheduler_fixed
-        hypercore_vectoragg
         vector_agg_groupagg
         vector_agg_grouping
         vector_agg_text

cmake/ScriptFiles.cmake

@@ -16,14 +16,11 @@ set(PRE_INSTALL_SOURCE_FILES
     pre_install/types.post.sql # Must be before tables.sql
     pre_install/tables.sql
     pre_install/cache.sql
-    pre_install/tam.functions.sql
-    pre_install/tam.sql
     pre_install/insert_data.sql)
 
 # Source files that define functions and need to be rerun in update
 set(PRE_INSTALL_FUNCTION_FILES
     pre_install/types.functions.sql
-    pre_install/tam.functions.sql
     )
 
 # The rest of the source files defining mostly functions

sql/debug_utils.sql

@@ -9,8 +9,3 @@
 CREATE OR REPLACE FUNCTION _timescaledb_debug.extension_state() RETURNS TEXT
 AS '@MODULE_PATHNAME@', 'ts_extension_get_state' LANGUAGE C;
 
-CREATE OR REPLACE FUNCTION _timescaledb_debug.is_compressed_tid(tid) RETURNS BOOL
-AS '@MODULE_PATHNAME@', 'ts_is_compressed_tid' LANGUAGE C STRICT;
-
-GRANT EXECUTE ON FUNCTION _timescaledb_debug.is_compressed_tid TO PUBLIC;
-

sql/maintenance_utils.sql

@@ -35,16 +35,14 @@ CREATE OR REPLACE FUNCTION _timescaledb_functions.create_compressed_chunk(
 CREATE OR REPLACE FUNCTION @[email protected]_chunk(
     uncompressed_chunk REGCLASS,
     if_not_compressed BOOLEAN = true,
-    recompress BOOLEAN = false,
-    hypercore_use_access_method BOOL = NULL
+    recompress BOOLEAN = false
 ) RETURNS REGCLASS AS '@MODULE_PATHNAME@', 'ts_compress_chunk' LANGUAGE C VOLATILE;
 
 -- Alias for compress_chunk above.
 CREATE OR REPLACE PROCEDURE @[email protected]_to_columnstore(
     chunk REGCLASS,
     if_not_columnstore BOOLEAN = true,
-    recompress BOOLEAN = false,
-    hypercore_use_access_method BOOL = NULL
+    recompress BOOLEAN = false
 ) AS '@MODULE_PATHNAME@', 'ts_compress_chunk' LANGUAGE C;
 
 CREATE OR REPLACE FUNCTION @[email protected]_chunk(

sql/policy_api.sql

@@ -52,8 +52,7 @@ CREATE OR REPLACE FUNCTION @[email protected]_compression_policy(
     schedule_interval INTERVAL = NULL,
     initial_start TIMESTAMPTZ = NULL,
     timezone TEXT = NULL,
-    compress_created_before INTERVAL = NULL,
-    hypercore_use_access_method BOOL = NULL
+    compress_created_before INTERVAL = NULL
 )
 RETURNS INTEGER
 AS '@MODULE_PATHNAME@', 'ts_policy_compression_add'
@@ -66,8 +65,7 @@ CREATE OR REPLACE PROCEDURE @[email protected]_columnstore_policy(
     schedule_interval INTERVAL = NULL,
     initial_start TIMESTAMPTZ = NULL,
     timezone TEXT = NULL,
-    created_before INTERVAL = NULL,
-    hypercore_use_access_method BOOL = NULL
+    created_before INTERVAL = NULL
 ) LANGUAGE C AS '@MODULE_PATHNAME@', 'ts_policy_compression_add';
 
 CREATE OR REPLACE FUNCTION @[email protected]_compression_policy(hypertable REGCLASS, if_exists BOOL = false) RETURNS BOOL
@@ -129,11 +127,8 @@ CREATE OR REPLACE FUNCTION timescaledb_experimental.add_policies(
     refresh_start_offset "any" = NULL,
     refresh_end_offset "any" = NULL,
     compress_after "any" = NULL,
-    drop_after "any" = NULL,
-    hypercore_use_access_method BOOL = NULL)
-RETURNS BOOL
-AS '@MODULE_PATHNAME@', 'ts_policies_add'
-LANGUAGE C VOLATILE;
+    drop_after "any" = NULL
+) RETURNS BOOL AS '@MODULE_PATHNAME@', 'ts_policies_add' LANGUAGE C VOLATILE;
 
 /* Remove policies */
 CREATE OR REPLACE FUNCTION timescaledb_experimental.remove_policies(

sql/policy_internal.sql

@@ -51,8 +51,8 @@ _timescaledb_functions.policy_compression_execute(
   verbose_log         BOOLEAN,
   recompress_enabled  BOOLEAN,
   reindex_enabled     BOOLEAN,
-  use_creation_time   BOOLEAN,
-  useam               BOOLEAN = NULL)
+  use_creation_time   BOOLEAN
+)
 AS $$
 DECLARE
   htoid       REGCLASS;
@@ -115,7 +115,7 @@ BEGIN
   LOOP
     BEGIN
       IF chunk_rec.status = bit_compressed OR recompress_enabled IS TRUE THEN
-        PERFORM @[email protected]_chunk(chunk_rec.oid, hypercore_use_access_method => useam);
+        PERFORM @[email protected]_chunk(chunk_rec.oid);
         numchunks_compressed := numchunks_compressed + 1;
       END IF;
     EXCEPTION WHEN OTHERS THEN
@@ -197,7 +197,6 @@ DECLARE
   recompress_enabled  BOOL;
   reindex_enabled     BOOL;
   use_creation_time   BOOL := FALSE;
-  hypercore_use_access_method   BOOL;
 BEGIN
 
   -- procedures with SET clause cannot execute transaction
@@ -239,18 +238,16 @@ BEGIN
     lag_value := compress_after;
   END IF;
 
-  hypercore_use_access_method := jsonb_object_field_text(config, 'hypercore_use_access_method')::bool;
-
   -- execute the properly type casts for the lag value
   CASE dimtype
     WHEN 'TIMESTAMP'::regtype, 'TIMESTAMPTZ'::regtype, 'DATE'::regtype, 'INTERVAL' ::regtype  THEN
-      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::INTERVAL, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time, hypercore_use_access_method);
+      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::INTERVAL, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time);
     WHEN 'BIGINT'::regtype THEN
-      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::BIGINT, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time, hypercore_use_access_method);
+      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::BIGINT, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time);
     WHEN 'INTEGER'::regtype THEN
-      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::INTEGER, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time, hypercore_use_access_method);
+      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::INTEGER, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time);
     WHEN 'SMALLINT'::regtype THEN
-      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::SMALLINT, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time, hypercore_use_access_method);
+      CALL _timescaledb_functions.policy_compression_execute(job_id, htid, lag_value::SMALLINT, maxchunks, verbose_log, recompress_enabled, reindex_enabled, use_creation_time);
   END CASE;
   COMMIT;
 END;

sql/pre_install/tam.functions.sql

@@ -0,0 +1,80 @@
+
+-- block upgrade if hypercore access method is still in use
+DO $$
+BEGIN
+  IF EXISTS(SELECT from pg_class c join pg_am am ON c.relam=am.oid AND am.amname='hypercore') THEN
+    RAISE EXCEPTION 'TimescaleDB does no longer support the hypercore table access method. Convert all tables to heap access method before upgrading.';
+  END IF;
+END
+$$;
+
+DROP OPERATOR CLASS IF EXISTS int4_ops USING hypercore_proxy;
+DROP ACCESS METHOD IF EXISTS hypercore_proxy;
+DROP ACCESS METHOD IF EXISTS hypercore;
+
+DROP FUNCTION IF EXISTS ts_hypercore_proxy_handler;
+DROP FUNCTION IF EXISTS ts_hypercore_handler;
+DROP FUNCTION IF EXISTS _timescaledb_debug.is_compressed_tid;
+
+DROP PROCEDURE IF EXISTS _timescaledb_functions.policy_compression_execute;
+DROP FUNCTION IF EXISTS @[email protected]_compression_policy;
+DROP PROCEDURE IF EXISTS @[email protected]_columnstore_policy;
+DROP FUNCTION IF EXISTS timescaledb_experimental.add_policies;
+DROP FUNCTION IF EXISTS @[email protected]_chunk;
+DROP FUNCTION IF EXISTS @[email protected]_to_columnstore;
+
+CREATE FUNCTION @[email protected]_chunk(
+  uncompressed_chunk REGCLASS,
+  if_not_compressed BOOLEAN = true,
+  recompress BOOLEAN = false
+) RETURNS REGCLASS AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C VOLATILE;
+
+CREATE PROCEDURE @[email protected]_to_columnstore(
+    chunk REGCLASS,
+    if_not_columnstore BOOLEAN = true,
+    recompress BOOLEAN = false
+) AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C;
+
+CREATE OR REPLACE FUNCTION @[email protected]_compression_policy(
+    hypertable REGCLASS,
+    compress_after "any" = NULL,
+    if_not_exists BOOL = false,
+    schedule_interval INTERVAL = NULL,
+    initial_start TIMESTAMPTZ = NULL,
+    timezone TEXT = NULL,
+    compress_created_before INTERVAL = NULL
+)
+RETURNS INTEGER
+AS '@MODULE_PATHNAME@', 'ts_update_placeholder'
+LANGUAGE C VOLATILE;
+
+CREATE PROCEDURE @[email protected]_columnstore_policy(
+    hypertable REGCLASS,
+    after "any" = NULL,
+    if_not_exists BOOL = false,
+    schedule_interval INTERVAL = NULL,
+    initial_start TIMESTAMPTZ = NULL,
+    timezone TEXT = NULL,
+    created_before INTERVAL = NULL
+) LANGUAGE C AS '@MODULE_PATHNAME@', 'ts_update_placeholder';
+
+CREATE FUNCTION timescaledb_experimental.add_policies(
+    relation REGCLASS,
+    if_not_exists BOOL = false,
+    refresh_start_offset "any" = NULL,
+    refresh_end_offset "any" = NULL,
+    compress_after "any" = NULL,
+    drop_after "any" = NULL
+) RETURNS BOOL AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C VOLATILE;
+
+CREATE PROCEDURE _timescaledb_functions.policy_compression_execute(
+  job_id              INTEGER,
+  htid                INTEGER,
+  lag                 ANYELEMENT,
+  maxchunks           INTEGER,
+  verbose_log         BOOLEAN,
+  recompress_enabled  BOOLEAN,
+  reindex_enabled     BOOLEAN,
+  use_creation_time   BOOLEAN
+)
+AS $$ $$ LANGUAGE PLPGSQL;