Improve pending materializations search (#8647)

PR #8607 addressed the
issue when a failed refresh left behind pending materializations (i.e.,
rows in _timescaledb_catalog.continuous_aggs_materialization_ranges).
The patch searched for those pending materializations that had some
overlap with the current refresh's refresh window. However that PR used
the refresh window that was passed as reference to
process_cagg_invalidations_and_refresh and as such, was modified by that
function to match with the invalidated buckets.

This PR changes it to use the original refresh window (from the policy)
so that it is more likely to overlap with the pending materializations
(and more deterministic, since it doesn't depend on the data being
materialized)

Disable-check: force-changelog-file

Author: pnthao

tsl/src/continuous_aggs/refresh.c

@@ -925,6 +925,11 @@ continuous_agg_refresh_internal(const ContinuousAgg *cagg,
 															INVALID_CHUNK_ID,
 															force);
 
+	/* check if we have any pending materializations in our refresh window range,
+	 * if so, we need to process them
+	 * Note that we use the original refresh window range here, not the one that has been processed
+	 * by the refresh function*/
+	refresh_window = *refresh_window_arg;
 	bool has_pending_materializations =
 		continuous_agg_has_pending_materializations(cagg, refresh_window);
 

tsl/test/isolation/expected/cagg_concurrent_refresh.out

@@ -704,7 +704,7 @@ debug_waitpoint_release
 
 step R3_refresh: <... completed>
 step R13_refresh: 
-    CALL refresh_continuous_aggregate('cond_10', 25, 70);
+    CALL refresh_continuous_aggregate('cond_10', 65, 100);
 
 step R6_pending_materialization_ranges: 
     SELECT * FROM pending_materialization_ranges WHERE user_view_name = 'cond_10';

tsl/test/isolation/specs/cagg_concurrent_refresh.spec

@@ -218,9 +218,10 @@ step "R12_refresh"
 session "R13"
 step "R13_refresh"
 {
-    CALL refresh_continuous_aggregate('cond_10', 25, 70);
+    CALL refresh_continuous_aggregate('cond_10', 65, 100);
 }
 
+
 # Refresh that overlaps with R1
 session "R2"
 setup