Make chunk identifiers formatting safe using format

Author: RobAtticus

sql/size_utils.sql

@@ -42,8 +42,8 @@ BEGIN
                FROM (
                SELECT *, total_bytes-index_bytes-COALESCE(toast_bytes,0) AS table_bytes FROM (
                       SELECT
-                      sum(pg_total_relation_size('"' || c.schema_name || '"."' || c.table_name || '"'))::bigint as total_bytes,
-                      sum(pg_indexes_size('"' || c.schema_name || '"."' || c.table_name || '"'))::bigint AS index_bytes,
+                      sum(pg_total_relation_size(format('%%I.%%I', c.schema_name, c.table_name)))::bigint as total_bytes,
+                      sum(pg_indexes_size(format('%%I.%%I', c.schema_name, c.table_name)))::bigint AS index_bytes,
                       sum(pg_total_relation_size(reltoastrelid))::bigint AS toast_bytes
                       FROM
                       _timescaledb_catalog.hypertable h,
@@ -104,8 +104,7 @@ BEGIN
         IF d.partitioning_func IS NULL THEN
            RETURN d.column_name;
         ELSE
-           RETURN d.partitioning_func_schema || '.' || d.partitioning_func
-                  || '(' || d.column_name || ')';
+           RETURN format('%I.%I(%I)', d.partitioning_func_schema, d.partitioning_func, d.column_name);
         END IF;
 END
 $BODY$;
@@ -209,9 +208,9 @@ BEGIN
               total_bytes-index_bytes-COALESCE(toast_bytes,0) AS table_bytes
               FROM (
                SELECT c.id as chunk_id,
-               '"' || c.schema_name || '"."' || c.table_name || '"' as chunk_table,
-               pg_total_relation_size('"' || c.schema_name || '"."' || c.table_name || '"') AS total_bytes,
-               pg_indexes_size('"' || c.schema_name || '"."' || c.table_name || '"') AS index_bytes,
+               format('%%I.%%I', c.schema_name, c.table_name) as chunk_table,
+               pg_total_relation_size(format('%%I.%%I', c.schema_name, c.table_name)) AS total_bytes,
+               pg_indexes_size(format('%%I.%%I', c.schema_name, c.table_name)) AS index_bytes,
                pg_total_relation_size(reltoastrelid) AS toast_bytes,
                array_agg(d.column_name ORDER BY d.interval_length, d.column_name ASC) as partitioning_columns,
                array_agg(d.column_type ORDER BY d.interval_length, d.column_name ASC) as partitioning_column_types,
@@ -308,9 +307,9 @@ BEGIN
               total_bytes-index_bytes-COALESCE(toast_bytes,0) AS table_bytes
               FROM (
                SELECT c.id as chunk_id,
-               '"' || c.schema_name || '"."' || c.table_name || '"' as chunk_table,
-               pg_total_relation_size('"' || c.schema_name || '"."' || c.table_name || '"') AS total_bytes,
-               pg_indexes_size('"' || c.schema_name || '"."' || c.table_name || '"') AS index_bytes,
+               format('%%I.%%I', c.schema_name, c.table_name) as chunk_table,
+               pg_total_relation_size(format('%%I.%%I', c.schema_name, c.table_name)) AS total_bytes,
+               pg_indexes_size(format('%%I.%%I', c.schema_name, c.table_name)) AS index_bytes,
                pg_total_relation_size(reltoastrelid) AS toast_bytes,
                array_agg(d.column_name ORDER BY d.interval_length, d.column_name ASC) as partitioning_columns,
                array_agg(d.column_type ORDER BY d.interval_length, d.column_name ASC) as partitioning_column_types,
@@ -374,7 +373,7 @@ BEGIN
         WHERE c.OID = main_table;
 
         RETURN QUERY
-        SELECT h.schema_name || '.' || ci.hypertable_index_name,
+        SELECT format('%I.%I', h.schema_name, ci.hypertable_index_name),
                sum(pg_relation_size(c.oid))::bigint
         FROM
         pg_class c,