Avoid using total suffix for gauge metrics and apply rate for counters

Latest mixtool linter which relies on grafana-linter pkg is failing when gauge metrics with name ending with `total`[1].

[1] https://github.com/grafana/dashboard-linter/blob/44d415fb6bdc4d8e6585e514c448174d4de1ff02/lint/rule_target_counter_agg.go#L30

Signed-off-by: Arunprasad Rajkumar <[email protected]>

Author: arajkumar

docs/mixin/dashboards/promscale.json

@@ -2274,7 +2274,7 @@
           },
           "editorMode": "code",
           "exemplar": false,
-          "expr": "max(promscale_sql_database_worker_maintenance_job_long_running_total)",
+          "expr": "max(promscale_sql_database_worker_long_running_maintenance_jobs)",
           "interval": "",
           "legendFormat": "total",
           "range": true,
@@ -2496,7 +2496,7 @@
           },
           "editorMode": "code",
           "exemplar": false,
-          "expr": "max(promscale_sql_database_worker_maintenance_job_long_running_total)",
+          "expr": "max(promscale_sql_database_worker_long_running_maintenance_jobs)",
           "interval": "",
           "legendFormat": "total",
           "range": true,
@@ -2670,7 +2670,7 @@
           },
           "editorMode": "code",
           "exemplar": false,
-          "expr": "max(promscale_sql_database_worker_maintenance_job_locks_total)",
+          "expr": "max(promscale_sql_database_worker_maintenance_job_locks)",
           "interval": "",
           "legendFormat": "total",
           "range": true,

pkg/pgmodel/metrics/database/metrics.go

@@ -242,7 +242,7 @@ var metrics = []metricQueryWrap{
 			prometheus.GaugeOpts{
 				Namespace: util.PromNamespace,
 				Subsystem: "sql_database",
-				Name:      "worker_maintenance_job_locks_total",
+				Name:      "worker_maintenance_job_locks",
 				Help:      "Number of locks held by Promscale maintenance workers.",
 			},
 		),
@@ -319,7 +319,7 @@ var metrics = []metricQueryWrap{
 			prometheus.GaugeOpts{
 				Namespace: util.PromNamespace,
 				Subsystem: "sql_database",
-				Name:      "worker_maintenance_job_long_running_total",
+				Name:      "worker_long_running_maintenance_jobs",
 				Help:      "Number of Promscale maintenance workers executing long running queries.",
 			},
 		),