Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Commit 753aed3

Browse files
committed
Stop counting idle processes in metrics
1 parent 84a6bd1 commit 753aed3

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

pkg/pgmodel/metrics/database/metrics.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ var metrics = []metricQueryWrap{
9999
},
100100
),
101101
// Compressed_chunk_id is null for both yet to be compressed and already compressed chunks.
102-
query: `SELECT
102+
query: `SELECT
103103
count(*) FILTER (WHERE dropped=false AND compressed_chunk_id IS NULL)::BIGINT AS chunks_count,
104104
count(*) FILTER (WHERE dropped=false AND compressed_chunk_id IS NOT NULL)::BIGINT AS chunks_compressed_count
105105
FROM _timescaledb_catalog.chunk`,
@@ -144,8 +144,8 @@ var metrics = []metricQueryWrap{
144144
WHERE c.dropped IS FALSE
145145
AND h.compression_state = 1 -- compression_enabled = TRUE
146146
AND (c.status & 1) != 1 -- only check for uncompressed chunks
147-
)
148-
SELECT
147+
)
148+
SELECT
149149
count(*) FILTER(WHERE m.delay_compression_until IS NULL OR m.delay_compression_until < now())::BIGINT AS uncompressed,
150150
count(*) FILTER(WHERE m.delay_compression_until IS NOT NULL AND m.delay_compression_until >= now())::BIGINT AS delayed_compression
151151
FROM chunk_candidates cc
@@ -266,7 +266,8 @@ var metrics = []metricQueryWrap{
266266
COUNT(*) :: BIGINT AS total
267267
FROM pg_stat_activity sa
268268
JOIN pg_locks l ON l.pid = sa.pid
269-
WHERE sa.application_name LIKE 'promscale maintenance%'`,
269+
WHERE sa.application_name LIKE 'promscale maintenance%'
270+
AND sa.state <> 'idle'`,
270271
}, {
271272
metrics: gauges(
272273
prometheus.GaugeOpts{
@@ -358,7 +359,8 @@ var metrics = []metricQueryWrap{
358359
},
359360
),
360361
query: `SELECT coalesce(extract(EPOCH FROM MAX(now() - coalesce(sa.query_start, sa.xact_start))) :: BIGINT, 0)
361-
FROM pg_stat_activity sa WHERE sa.application_name LIKE 'promscale maintenance%'`,
362+
FROM pg_stat_activity sa WHERE sa.application_name LIKE 'promscale maintenance%'
363+
AND sa.state <> 'idle'`,
362364
}, {
363365
metrics: gauges(
364366
prometheus.GaugeOpts{

0 commit comments

Comments
 (0)