Removing chunks_created metrics because it's not computed correctly and

thus not particularly useful.

Author: sumerman

CHANGELOG.md

@@ -22,11 +22,11 @@ We use the following categories for changes:
 - Add cmd flag `web.auth.ignore-path` to skip http paths from authentication [#1637]
 - Add cmd flag `tracing.streaming-span-writer` to enable/disable streaming span writer. It is enabled by default. [#1633].
 - Enable tracing.async-acks by default [#1633].
+- Sizes of maintenance worker backlogs exposed as database metrics on the Promscale dashboard [#1634]
 
 ### Changed
 - Log throughput in the same line for samples, spans and metric metadata [#1643]
-- Sizes of maintenance worker backlogs exposed as database metrics on the Promscale dashboard [#1634]
-- Enable tracing.async-acks by default [#1633]
+- The `chunks_created` metrics was removed. [#1634]
 
 ### Fixed
 - Do not collect telemetry if `timescaledb.telemetry_level=off` [#1612]

pkg/pgmodel/metrics/database/metrics.go

@@ -84,12 +84,6 @@ var metrics = []metricQueryWrap{
 				Name:      "chunks_count",
 				Help:      "Total number of chunks in TimescaleDB currently.",
 			},
-			prometheus.GaugeOpts{
-				Namespace: util.PromNamespace,
-				Subsystem: "sql_database",
-				Name:      "chunks_created",
-				Help:      "Total number of chunks created since creation of database.",
-			},
 			prometheus.GaugeOpts{
 				Namespace: util.PromNamespace,
 				Subsystem: "sql_database",
@@ -100,7 +94,6 @@ var metrics = []metricQueryWrap{
 		// Compressed_chunk_id is null for both yet to be compressed and already compressed chunks.
 		query: `SELECT 
 				count(*) FILTER (WHERE dropped=false AND compressed_chunk_id IS NULL)::BIGINT AS chunks_count,
-				count(*) FILTER (WHERE compressed_chunk_id IS NULL)::BIGINT AS chunks_created,
 				count(*) FILTER (WHERE dropped=false AND compressed_chunk_id IS NOT NULL)::BIGINT AS chunks_compressed_count
 			FROM _timescaledb_catalog.chunk`,
 	}, {

pkg/tests/end_to_end_tests/database_metrics_test.go

@@ -33,8 +33,6 @@ func TestDatabaseMetrics(t *testing.T) {
 		require.Equal(t, float64(0), compressionStatus)
 		numMaintenanceJobs := getMetricValue(t, "worker_maintenance_job")
 		require.Equal(t, float64(0), numMaintenanceJobs)
-		chunksCreated := getMetricValue(t, "chunks_created")
-		require.Equal(t, float64(0), chunksCreated)
 		chunksCount := getMetricValue(t, "chunks_count")
 		require.Equal(t, float64(0), chunksCount)
 		chunksCompressedCount := getMetricValue(t, "chunks_compressed_count")
@@ -56,8 +54,6 @@ func TestDatabaseMetrics(t *testing.T) {
 		require.Equal(t, float64(1), compressionStatus)
 		numMaintenanceJobs = getMetricValue(t, "worker_maintenance_job")
 		require.Equal(t, float64(2), numMaintenanceJobs)
-		chunksCreated = getMetricValue(t, "chunks_created")
-		require.Equal(t, float64(0), chunksCreated)
 		chunksCount = getMetricValue(t, "chunks_count")
 		require.Equal(t, float64(0), chunksCount)
 		chunksCompressedCount = getMetricValue(t, "chunks_compressed_count")
@@ -81,8 +77,6 @@ func TestDatabaseMetrics(t *testing.T) {
 		// Update the metrics again.
 		require.NoError(t, dbMetrics.Update())
 
-		chunksCreated = getMetricValue(t, "chunks_created")
-		require.Equal(t, float64(3), chunksCreated)
 		chunksCount = getMetricValue(t, "chunks_count")
 		require.Equal(t, float64(3), chunksCount)
 		chunksCompressedCount = getMetricValue(t, "chunks_compressed_count")
@@ -126,8 +120,6 @@ func TestDatabaseMetricsAfterCompression(t *testing.T) {
 		require.Equal(t, float64(1), compressionStatus)
 		numMaintenanceJobs := getMetricValue(t, "worker_maintenance_job")
 		require.Equal(t, float64(2), numMaintenanceJobs)
-		chunksCreated := getMetricValue(t, "chunks_created")
-		require.Equal(t, float64(2), chunksCreated)
 		chunksCount := getMetricValue(t, "chunks_count")
 		require.Equal(t, float64(2), chunksCount)
 		chunksCompressedCount := getMetricValue(t, "chunks_compressed_count")
@@ -146,8 +138,6 @@ func TestDatabaseMetricsAfterCompression(t *testing.T) {
 
 		// Update the metrics after compression.
 		require.NoError(t, dbMetrics.Update())
-		chunksCreated = getMetricValue(t, "chunks_created")
-		require.Equal(t, float64(2), chunksCreated)
 		chunksCount = getMetricValue(t, "chunks_count")
 		require.Equal(t, float64(2), chunksCount)
 		chunksCompressedCount = getMetricValue(t, "chunks_compressed_count")