Skip to content

Commit 8ad2efb

Browse files
dmlemeshkotiansivive
authored andcommitted
[ska] relocate platform UI tests (elastic#228741)
## Summary Part of elastic/kibana-team#1503 This PR is mostly about moving FTR functional UI from x-pack/test ``` x-pack/test/functional/apps | - index_management/ | - index_lifecycle_management/ | - ingest_pipeline/ | - lens/ | - logstash/ | - rollup_job/ | - remote_clusters/ | - visualize/ ``` After: ``` x-pack/platform/test/functional/apps | - index_management/ | - index_lifecycle_management/ | - ingest_pipeline/ | - lens/ | - logstash/ | - rollup_job/ | - remote_clusters/ | - visualize/ ```
1 parent 315c754 commit 8ad2efb

File tree

176 files changed

+361
-388
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

176 files changed

+361
-388
lines changed

.buildkite/ftr_platform_stateful_configs.yml

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ disabled:
1818
- x-pack/platform/test/functional_basic/apps/transform/config.base.ts
1919
- x-pack/platform/test/api_integration_basic/config.basic_license.ts
2020
- x-pack/platform/test/ui_capabilities/common/config.ts
21-
- x-pack/platform/test/functional/config.ccs.ts
2221

2322
# QA suites that are run out-of-band
2423
- x-pack/platform/test/stack_functional_integration/configs/config.stack_functional_integration_base.js
@@ -214,21 +213,21 @@ enabled:
214213
- x-pack/platform/test/functional/apps/graph/config.ts
215214
- x-pack/platform/test/functional/apps/grok_debugger/config.ts
216215
- x-pack/platform/test/functional/apps/home/config.ts
217-
- x-pack/test/functional/apps/index_lifecycle_management/config.ts
218-
- x-pack/test/functional/apps/index_management/config.ts
219-
- x-pack/test/functional/apps/ingest_pipelines/config.ts
220-
- x-pack/test/functional/apps/lens/group1/config.ts
221-
- x-pack/test/functional/apps/lens/group2/config.ts
222-
- x-pack/test/functional/apps/lens/group3/config.ts
223-
- x-pack/test/functional/apps/lens/group4/config.ts
224-
- x-pack/test/functional/apps/lens/group5/config.ts
225-
- x-pack/test/functional/apps/lens/group6/config.ts
226-
- x-pack/test/functional/apps/lens/group7/config.ts
227-
- x-pack/test/functional/apps/lens/open_in_lens/tsvb/config.ts
228-
- x-pack/test/functional/apps/lens/open_in_lens/agg_based/config.ts
229-
- x-pack/test/functional/apps/lens/open_in_lens/dashboard/config.ts
216+
- x-pack/platform/test/functional/apps/index_lifecycle_management/config.ts
217+
- x-pack/platform/test/functional/apps/index_management/config.ts
218+
- x-pack/platform/test/functional/apps/ingest_pipelines/config.ts
219+
- x-pack/platform/test/functional/apps/lens/group1/config.ts
220+
- x-pack/platform/test/functional/apps/lens/group2/config.ts
221+
- x-pack/platform/test/functional/apps/lens/group3/config.ts
222+
- x-pack/platform/test/functional/apps/lens/group4/config.ts
223+
- x-pack/platform/test/functional/apps/lens/group5/config.ts
224+
- x-pack/platform/test/functional/apps/lens/group6/config.ts
225+
- x-pack/platform/test/functional/apps/lens/group7/config.ts
226+
- x-pack/platform/test/functional/apps/lens/open_in_lens/tsvb/config.ts
227+
- x-pack/platform/test/functional/apps/lens/open_in_lens/agg_based/config.ts
228+
- x-pack/platform/test/functional/apps/lens/open_in_lens/dashboard/config.ts
230229
- x-pack/platform/test/functional/apps/license_management/config.ts
231-
- x-pack/test/functional/apps/logstash/config.ts
230+
- x-pack/platform/test/functional/apps/logstash/config.ts
232231
- x-pack/platform/test/functional/apps/managed_content/config.ts
233232
- x-pack/platform/test/functional/apps/management/config.ts
234233
- x-pack/platform/test/functional/apps/maps/group1/config.ts
@@ -246,9 +245,9 @@ enabled:
246245
- x-pack/platform/test/functional/apps/ml/memory_usage/config.ts
247246
- x-pack/test/functional/apps/monitoring/config.ts
248247
- x-pack/platform/test/functional/apps/painless_lab/config.ts
249-
- x-pack/test/functional/apps/remote_clusters/config.ts
248+
- x-pack/platform/test/functional/apps/remote_clusters/config.ts
250249
- x-pack/platform/test/functional/apps/reporting_management/config.ts
251-
- x-pack/test/functional/apps/rollup_job/config.ts
250+
- x-pack/platform/test/functional/apps/rollup_job/config.ts
252251
- x-pack/platform/test/functional/apps/saved_objects_management/config.ts
253252
- x-pack/platform/test/functional/apps/saved_query_management/config.ts
254253
- x-pack/platform/test/functional/apps/saved_query_management/config.v2.ts
@@ -264,10 +263,10 @@ enabled:
264263
- x-pack/platform/test/functional/apps/transform/feature_controls/config.ts
265264
- x-pack/platform/test/functional/apps/upgrade_assistant/config.ts
266265
- x-pack/platform/test/functional/apps/user_profiles/config.ts
267-
- x-pack/test/functional/apps/visualize/config.ts
266+
- x-pack/platform/test/functional/apps/visualize/config.ts
268267
- x-pack/platform/test/functional/apps/watcher/config.ts
269268
- x-pack/platform/test/functional/config_security_basic.ts
270-
- x-pack/test/functional/config.ccs.ts
269+
- x-pack/platform/test/functional/config.ccs.ts
271270
- x-pack/platform/test/functional/config.firefox.ts
272271
- x-pack/platform/test/functional/config.upgrade_assistant.ts
273272
- x-pack/platform/test/functional_cloud/config.ts

.buildkite/scripts/steps/artifacts/cloud.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,4 @@ export TEST_BROWSER_HEADLESS=1
9292
export NODE_TLS_REJECT_UNAUTHORIZED=0
9393

9494
echo "--- FTR - Reporting"
95-
node --no-warnings scripts/functional_test_runner.js --config x-pack/test/functional/apps/visualize/config.ts --include-tag=smoke --quiet
95+
node --no-warnings scripts/functional_test_runner.js --config x-pack/platform/test/functional/apps/visualize/config.ts --include-tag=smoke --quiet

.github/CODEOWNERS

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,10 +1256,10 @@ src/platform/plugins/shared/discover/public/context_awareness/profile_providers/
12561256

12571257
# Visualizations
12581258
/x-pack/test/functional/fixtures/kbn_archiver/rollup @elastic/kibana-visualizations # Assigned per the only uses are in lens and tsvb tests
1259-
/x-pack/test/functional/fixtures/kbn_archiver/hybrid_dataview.json @elastic/kibana-visualizations # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/test/functional/apps/visualize/hybrid_visualization.ts#L20
1259+
/x-pack/test/functional/fixtures/kbn_archiver/hybrid_dataview.json @elastic/kibana-visualizations # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/platform/test/functional/apps/visualize/hybrid_visualization.ts#L20
12601260
/x-pack/test/functional/es_archives/pre_calculated_histogram @elastic/kibana-visualizations # Assigned per usages
12611261
/x-pack/test/functional/es_archives/hybrid/rollup @elastic/kibana-visualizations @elastic/search-kibana # Assigned per usage
1262-
/x-pack/test/functional/es_archives/hybrid/logstash @elastic/kibana-visualizations # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/test/functional/apps/visualize/hybrid_visualization.ts#L22
1262+
/x-pack/test/functional/es_archives/hybrid/logstash @elastic/kibana-visualizations # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/platform/test/functional/apps/visualize/hybrid_visualization.ts#L22
12631263
/x-pack/test/functional/es_archives/graph @elastic/kibana-visualizations
12641264
/x-pack/test/functional/es_archives/visualize @elastic/kibana-visualizations
12651265
/src/platform/test/functional/fixtures/kbn_archiver/visualize.json @elastic/kibana-visualizations
@@ -1294,9 +1294,9 @@ src/platform/plugins/shared/discover/public/context_awareness/profile_providers/
12941294
/src/platform/test/accessibility/apps/visualize.ts @elastic/kibana-visualizations
12951295
/x-pack/test/accessibility/apps/group3/graph.ts @elastic/kibana-visualizations
12961296
/x-pack/test/accessibility/apps/group2/lens.ts @elastic/kibana-visualizations
1297-
/x-pack/test/functional/apps/visualize @elastic/kibana-visualizations
1297+
/x-pack/platform/test/functional/apps/visualize @elastic/kibana-visualizations
12981298
/src/plugins/visualize/ @elastic/kibana-visualizations
1299-
/x-pack/test/functional/apps/lens @elastic/kibana-visualizations
1299+
/x-pack/platform/test/functional/apps/lens @elastic/kibana-visualizations
13001300
/x-pack/test/api_integration/apis/lens/ @elastic/kibana-visualizations
13011301
/src/platform/test/functional/apps/visualize/ @elastic/kibana-visualizations
13021302
/x-pack/platform/test/functional/apps/graph @elastic/kibana-visualizations
@@ -1314,7 +1314,7 @@ x-pack/solutions/observability/plugins/observability/server/lib/esql_extensions
13141314

13151315
### Reporting
13161316
/x-pack/platform/test/functional/apps/dashboard/reporting/ @elastic/response-ops
1317-
/x-pack/test/functional/apps/reporting/ @elastic/response-ops
1317+
/x-pack/platform/test/functional/apps/reporting/ @elastic/response-ops
13181318
/x-pack/platform/test/functional/apps/reporting_management/ @elastic/response-ops
13191319
/x-pack/platform/test/examples/screenshotting/ @elastic/response-ops
13201320
/x-pack/test/functional/es_archives/lens/reporting/ @elastic/response-ops
@@ -1802,9 +1802,9 @@ x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security
18021802
/x-pack/platform/test/upgrade/ftr_provider_context.d.ts @elastic/appex-qa
18031803
/x-pack/platform/test/upgrade/config.ts @elastic/appex-qa
18041804
/x-pack/platform/test/functional_basic/ftr_provider_context.d.ts @elastic/appex-qa
1805-
x-pack/test/functional/services/index.ts @elastic/appex-qa
1805+
/x-pack/test/functional/services/index.ts @elastic/appex-qa
18061806
/x-pack/platform/test/functional/services/remote_es/remote_es.ts @elastic/appex-qa
1807-
/x-pack/test/functional/services/random.js @elastic/appex-qa
1807+
/x-pack/platform/test/functional/services/random.ts @elastic/appex-qa
18081808
/x-pack/test/functional/services/index.ts @elastic/appex-qa
18091809
/x-pack/platform/test/functional/services/index.ts @elastic/appex-qa
18101810
/x-pack/test/functional/page_objects/index.ts @elastic/appex-qa
@@ -1953,6 +1953,8 @@ x-pack/test/functional/services/index.ts @elastic/appex-qa
19531953
/x-pack/solutions/observability/test/functional_with_es_ssl/apps/index.ts @elastic/appex-qa
19541954
/x-pack/platform/test/.gitignore @elastic/appex-qa
19551955
/x-pack/solutions/**/test/.gitignore @elastic/appex-qa
1956+
/x-pack/platform/test/functional/services/pipeline_list.ts @elastic/appex-qa
1957+
/x-pack/platform/test/functional/services/pipeline_editor.ts @elastic/appex-qa
19561958

19571959
# Core
19581960
/src/platform/test/api_integration/fixtures/kbn_archiver/management/saved_objects/relationships.json @elastic/kibana-core @elastic/kibana-data-discovery
@@ -2258,7 +2260,7 @@ x-pack/platform/test/functional/page_objects/search_profiler_page.ts @elastic/se
22582260
/x-pack/test/functional/apps/search_playground @elastic/search-kibana
22592261
/x-pack/test_serverless/functional/page_objects/svl_ingest_pipelines.ts @elastic/search-kibana
22602262
/x-pack/platform/test/functional/apps/dev_tools/embedded_console.ts @elastic/search-kibana
2261-
/x-pack/test/functional/apps/ingest_pipelines/feature_controls/ingest_pipelines_security.ts @elastic/search-kibana
2263+
/x-pack/platform/test/functional/apps/ingest_pipelines/feature_controls/ingest_pipelines_security.ts @elastic/search-kibana
22622264
/x-pack/test/functional/page_objects/embedded_console.ts @elastic/search-kibana
22632265
/x-pack/test/functional_enterprise_search/ @elastic/search-kibana
22642266
/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/doc_links @elastic/platform-docs
@@ -2285,17 +2287,17 @@ x-pack/platform/test/functional/page_objects/search_profiler_page.ts @elastic/se
22852287
/x-pack/test/functional/fixtures/kbn_archiver/home/feature_controls/security/security.json @elastic/kibana-management
22862288
/x-pack/test/functional/es_archives/upgrade_assistant @elastic/kibana-management
22872289
/x-pack/platform/test/functional/services/ace_editor.ts @elastic/kibana-management
2288-
/x-pack/test/functional/page_objects/remote_clusters_page.ts @elastic/kibana-management
2290+
/x-pack/platform/test/functional/page_objects/remote_clusters_page.ts @elastic/kibana-management
22892291
/x-pack/platform/test/stack_functional_integration/apps/ccs @elastic/kibana-management
2290-
/x-pack/test/functional/services/data_stream.ts @elastic/kibana-management
2292+
/x-pack/platform/test/functional/services/data_stream.ts @elastic/kibana-management
22912293
/x-pack/platform/test/functional/page_objects/watcher_page.ts @elastic/kibana-management
22922294
/x-pack/platform/test/functional/page_objects/upgrade_assistant_page.ts @elastic/kibana-management
22932295
/x-pack/platform/test/functional/page_objects/snapshot_restore_page.ts @elastic/kibana-management
2294-
/x-pack/test/functional/page_objects/rollup_page.ts @elastic/kibana-management
2295-
/x-pack/test/functional/page_objects/ingest_pipelines_page.ts @elastic/kibana-management
2296+
/x-pack/platform/test/functional/page_objects/rollup_page.ts @elastic/kibana-management
2297+
/x-pack/platform/test/functional/page_objects/ingest_pipelines_page.ts @elastic/kibana-management
22962298
/x-pack/platform/test/functional/page_objects/grok_debugger_page.ts @elastic/kibana-management
22972299
/x-pack/platform/test/functional/page_objects/cross_cluster_replication_page.ts @elastic/kibana-management
2298-
/x-pack/test/functional/fixtures/ingest_pipeline_example_mapping.csv @elastic/kibana-management
2300+
/x-pack/platform/test/functional/fixtures/ingest_pipeline_example_mapping.csv @elastic/kibana-management
22992301
/x-pack/platform/test/functional/apps/snapshot_restore @elastic/kibana-management
23002302
/x-pack/platform/test/functional/apps/painless_lab @elastic/kibana-management
23012303
/x-pack/test_serverless/functional/test_suites/common/spaces/spaces_management.ts @elastic/kibana-management
@@ -2305,12 +2307,12 @@ x-pack/platform/test/functional/page_objects/search_profiler_page.ts @elastic/se
23052307
/src/platform/test/functional/services/management @elastic/kibana-management
23062308
/src/platform/test/functional/services/synthtrace/sythtrace.ts @elastic/kibana-management
23072309
/x-pack/platform/test/functional/apps/cross_cluster_replication @elastic/kibana-management
2308-
/x-pack/test/functional/apps/ingest_pipelines @elastic/kibana-management
2310+
/x-pack/platform/test/functional/apps/ingest_pipelines @elastic/kibana-management
23092311
/x-pack/platform/test/functional/apps/home @elastic/kibana-management
23102312
/x-pack/platform/test/functional/apps/license_management @elastic/kibana-management
23112313
/x-pack/platform/test/functional/page_objects/license_management_page.ts @elastic/kibana-management
23122314
/x-pack/platform/test/functional/apps/management @elastic/kibana-management
2313-
/x-pack/test/functional/apps/remote_clusters @elastic/kibana-management
2315+
/x-pack/platform/test/functional/apps/remote_clusters @elastic/kibana-management
23142316
/x-pack/platform/test/functional/apps/upgrade_assistant @elastic/kibana-management
23152317
/x-pack/platform/test/functional/apps/dev_tools @elastic/kibana-management
23162318
/src/platform/test/plugin_functional/test_suites/management @elastic/kibana-management
@@ -2329,10 +2331,11 @@ x-pack/platform/test/functional/page_objects/search_profiler_page.ts @elastic/se
23292331
/src/platform/test/accessibility/apps/console.ts @elastic/kibana-management
23302332
/x-pack/test/api_integration/services/index_management.ts @elastic/kibana-management
23312333
/x-pack/platform/test/functional/page_objects/index_management_page.ts @elastic/kibana-management
2334+
/x-pack/platform/test/functional/page_objects/index_lifecycle_management_page.ts @elastic/kibana-management
23322335
/x-pack/platform/test/functional/services/grok_debugger.ts @elastic/kibana-management
23332336
/x-pack/platform/test/functional/apps/grok_debugger @elastic/kibana-management
2334-
/x-pack/test/functional/apps/index_lifecycle_management @elastic/kibana-management
2335-
/x-pack/test/functional/apps/index_management @elastic/kibana-management
2337+
/x-pack/platform/test/functional/apps/index_lifecycle_management @elastic/kibana-management
2338+
/x-pack/platform/test/functional/apps/index_management @elastic/kibana-management
23362339
/x-pack/platform/test/functional/apps/watcher @elastic/kibana-management
23372340
/x-pack/platform/test/api_integration/apis/watcher @elastic/kibana-management
23382341
/x-pack/platform/test/api_integration/apis/upgrade_assistant @elastic/kibana-management
@@ -2353,7 +2356,7 @@ x-pack/platform/test/functional/page_objects/search_profiler_page.ts @elastic/se
23532356
/x-pack/platform/test/api_integration/apis/management/ @elastic/kibana-management
23542357
/x-pack/platform/test/api_integration_deployment_agnostic/apis/management/ @elastic/kibana-management
23552358
/x-pack/platform/test/api_integration_deployment_agnostic/apis/painless_lab/ @elastic/kibana-management
2356-
/x-pack/test/functional/apps/rollup_job/ @elastic/kibana-management
2359+
/x-pack/platform/test/functional/apps/rollup_job/ @elastic/kibana-management
23572360
/x-pack/platform/test/api_integration/apis/grok_debugger @elastic/kibana-management
23582361
/x-pack/test/accessibility/apps/group1/advanced_settings.ts @elastic/kibana-management
23592362
/x-pack/test/accessibility/apps/**/grok_debugger.ts @elastic/kibana-management
@@ -2872,8 +2875,8 @@ x-pack/solutions/security/plugins/security_solution/server/lib/security_integrat
28722875
# Logstash
28732876
/x-pack/test/functional/es_archives/logstash/example_pipelines @elastic/logstash
28742877
/x-pack/test/functional/services/pipeline_* @elastic/logstash
2875-
/x-pack/test/functional/page_objects/logstash_page.ts @elastic/logstash
2876-
/x-pack/test/functional/apps/logstash @elastic/logstash
2878+
/x-pack/platform/test/functional/page_objects/logstash_page.ts @elastic/logstash
2879+
/x-pack/platform/test/functional/apps/logstash @elastic/logstash
28772880
/x-pack/platform/test/api_integration/apis/logstash @elastic/logstash
28782881
#CC# /x-pack/platform/plugins/private/logstash/ @elastic/logstash
28792882

x-pack/test/functional/apps/index_lifecycle_management/config.ts renamed to x-pack/platform/test/functional/apps/index_lifecycle_management/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import { FtrConfigProviderContext } from '@kbn/test';
99

1010
export default async function ({ readConfigFile }: FtrConfigProviderContext) {
11-
const functionalConfig = await readConfigFile(require.resolve('../../config.base.js'));
11+
const functionalConfig = await readConfigFile(require.resolve('../../config.base.ts'));
1212

1313
return {
1414
...functionalConfig.getAll(),
File renamed without changes.
File renamed without changes.

x-pack/test/functional/apps/index_lifecycle_management/home_page.ts renamed to x-pack/platform/test/functional/apps/index_lifecycle_management/home_page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
3030
body: {
3131
type: 'fs',
3232
settings: {
33-
// use one of the values defined in path.repo in src/platform/test/functional/config.base.js
33+
// use one of the values defined in path.repo in src/platform/test/functional/config.base.ts
3434
location: '/tmp/',
3535
},
3636
},
File renamed without changes.
File renamed without changes.

x-pack/test/functional/apps/index_management/config.ts renamed to x-pack/platform/test/functional/apps/index_management/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import { FtrConfigProviderContext } from '@kbn/test';
99

1010
export default async function ({ readConfigFile }: FtrConfigProviderContext) {
11-
const functionalConfig = await readConfigFile(require.resolve('../../config.base.js'));
11+
const functionalConfig = await readConfigFile(require.resolve('../../config.base.ts'));
1212

1313
const baseConfig = functionalConfig.getAll();
1414

0 commit comments

Comments
 (0)