Skip to content

Commit 8474603

Browse files
authored
WebGPURenderer: Array-Based RenderTarget Refactor (#1644)
* WebGPURenderer: Array-Based RenderTarget Refactor * Fix
1 parent 6c61700 commit 8474603

File tree

7 files changed

+7
-29
lines changed

7 files changed

+7
-29
lines changed

types/three/src/Three.Core.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ export * from "./core/Object3D.js";
3939
export * from "./core/Raycaster.js";
4040
export * from "./core/RenderTarget.js";
4141
export * from "./core/RenderTarget3D.js";
42-
export * from "./core/RenderTargetArray.js";
4342
export * from "./core/Uniform.js";
4443
export * from "./core/UniformsGroup.js";
4544
export * from "./extras/Controls.js";
@@ -153,7 +152,6 @@ export * from "./textures/CubeTexture.js";
153152
export * from "./textures/Data3DTexture.js";
154153
export * from "./textures/DataArrayTexture.js";
155154
export * from "./textures/DataTexture.js";
156-
export * from "./textures/DepthArrayTexture.js";
157155
export * from "./textures/DepthTexture.js";
158156
export * from "./textures/FramebufferTexture.js";
159157
export * from "./textures/Source.js";

types/three/src/core/RenderTarget.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { Texture } from "../textures/Texture.js";
1111
import { EventDispatcher } from "./EventDispatcher.js";
1212

1313
export interface RenderTargetOptions {
14-
depth?: number | undefined;
1514
wrapS?: Wrapping | undefined;
1615
wrapT?: Wrapping | undefined;
1716
magFilter?: MagnificationTextureFilter | undefined;
@@ -33,6 +32,7 @@ export interface RenderTargetOptions {
3332
*/
3433
samples?: number | undefined;
3534
count?: number | undefined;
35+
depth?: number | undefined;
3636
multiview?: boolean | undefined;
3737
}
3838

types/three/src/core/RenderTargetArray.d.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

types/three/src/renderers/webgpu/nodes/WGSLNodeBuilder.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ export default class WGSLNodeBuilder extends NodeBuilder {
4848
texture: Texture,
4949
textureProperty: string,
5050
uvIndexSnippet: string,
51+
depthSnippet: string | null,
5152
valueSnippet: string,
5253
): string;
5354
isUnfilterable(texture: Texture): boolean;

types/three/src/textures/DepthArrayTexture.d.ts

Lines changed: 0 additions & 14 deletions
This file was deleted.

types/three/src/textures/DepthTexture.d.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export class DepthTexture extends Texture {
2828
* @param minFilter See {@link Texture.minFilter | .minFilter}. Default {@link THREE.NearestFilter}
2929
* @param anisotropy See {@link Texture.anisotropy | .anisotropy}. Default {@link THREE.Texture.DEFAULT_ANISOTROPY}
3030
* @param format See {@link DepthTexture.format | .format}. Default {@link THREE.DepthFormat}
31+
* @param {number} [depth=1] - The depth of the texture.
3132
*/
3233
constructor(
3334
width: number,
@@ -40,6 +41,7 @@ export class DepthTexture extends Texture {
4041
minFilter?: MinificationTextureFilter,
4142
anisotropy?: number,
4243
format?: DepthTexturePixelFormat,
44+
depth?: number,
4345
);
4446

4547
/**
@@ -53,8 +55,8 @@ export class DepthTexture extends Texture {
5355
* Overridden with a record type holding width and height.
5456
* @override
5557
*/
56-
get image(): { width: number; height: number };
57-
set image(value: { width: number; height: number });
58+
get image(): { width: number; height: number; depth: number };
59+
set image(value: { width: number; height: number; depth: number });
5860

5961
/**
6062
* @override

types/three/src/textures/Texture.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ export class Texture extends EventDispatcher<{ dispose: {} }> {
397397
*
398398
* @default false
399399
*/
400-
isTextureArray: boolean;
400+
isArrayTexture: boolean;
401401

402402
/**
403403
* An object that can be used to store custom data about the texture.

0 commit comments

Comments
 (0)