Skip to content

Commit 097cac9

Browse files
authored
Fix Keyframe subclass constructor arguments (#1635)
* Add jsdoc * Update patch and delete jsdoc * Update declarations
1 parent 9d35197 commit 097cac9

File tree

8 files changed

+15
-13
lines changed

8 files changed

+15
-13
lines changed

jsdoc-testing/changes.patch

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,7 @@ index aa0f64d7..a97bcb3a 100644
895895
}
896896
-import { KeyframeTrack } from '../KeyframeTrack.js';
897897
diff --git a/jsdoc-testing/jsdoc/animation/tracks/NumberKeyframeTrack.d.ts b/jsdoc-testing/jsdoc/animation/tracks/NumberKeyframeTrack.d.ts
898-
index f83c955c..d9da4752 100644
898+
index f83c955c..e3a837b0 100644
899899
--- a/jsdoc-testing/jsdoc/animation/tracks/NumberKeyframeTrack.d.ts
900900
+++ b/jsdoc-testing/jsdoc/animation/tracks/NumberKeyframeTrack.d.ts
901901
@@ -1,7 +1,8 @@
@@ -914,11 +914,11 @@ index f83c955c..d9da4752 100644
914914
* @param {(InterpolateLinear|InterpolateDiscrete|InterpolateSmooth)} [interpolation] - The interpolation type.
915915
*/
916916
- constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: (InterpolateLinear | InterpolateDiscrete | InterpolateSmooth));
917-
+ constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: InterpolationModes);
917+
+ constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>, interpolation?: InterpolationModes);
918918
}
919919
-import { KeyframeTrack } from '../KeyframeTrack.js';
920920
diff --git a/jsdoc-testing/jsdoc/animation/tracks/QuaternionKeyframeTrack.d.ts b/jsdoc-testing/jsdoc/animation/tracks/QuaternionKeyframeTrack.d.ts
921-
index 98e4a75e..9829cc69 100644
921+
index 98e4a75e..24a349a7 100644
922922
--- a/jsdoc-testing/jsdoc/animation/tracks/QuaternionKeyframeTrack.d.ts
923923
+++ b/jsdoc-testing/jsdoc/animation/tracks/QuaternionKeyframeTrack.d.ts
924924
@@ -1,7 +1,8 @@
@@ -938,11 +938,11 @@ index 98e4a75e..9829cc69 100644
938938
*/
939939
- constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: (InterpolateLinear | InterpolateDiscrete | InterpolateSmooth));
940940
- InterpolantFactoryMethodSmooth: any;
941-
+ constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: InterpolationModes);
941+
+ constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>, interpolation?: InterpolationModes);
942942
}
943943
-import { KeyframeTrack } from '../KeyframeTrack.js';
944944
diff --git a/jsdoc-testing/jsdoc/animation/tracks/StringKeyframeTrack.d.ts b/jsdoc-testing/jsdoc/animation/tracks/StringKeyframeTrack.d.ts
945-
index 26868e33..2c15769a 100644
945+
index 26868e33..393330b9 100644
946946
--- a/jsdoc-testing/jsdoc/animation/tracks/StringKeyframeTrack.d.ts
947947
+++ b/jsdoc-testing/jsdoc/animation/tracks/StringKeyframeTrack.d.ts
948948
@@ -1,7 +1,7 @@
@@ -955,10 +955,11 @@ index 26868e33..2c15769a 100644
955955
*/
956956
export class StringKeyframeTrack extends KeyframeTrack {
957957
/**
958-
@@ -15,14 +15,4 @@ export class StringKeyframeTrack extends KeyframeTrack {
958+
@@ -14,15 +14,5 @@ export class StringKeyframeTrack extends KeyframeTrack {
959+
* @param {Array<number>} times - A list of keyframe times.
959960
* @param {Array<number>} values - A list of keyframe values.
960961
*/
961-
constructor(name: string, times: Array<number>, values: Array<number>);
962+
- constructor(name: string, times: Array<number>, values: Array<number>);
962963
- /**
963964
- * The default interpolation type of this keyframe track.
964965
- *
@@ -968,10 +969,11 @@ index 26868e33..2c15769a 100644
968969
- DefaultInterpolation: (InterpolateLinear | number | InterpolateSmooth);
969970
- InterpolantFactoryMethodLinear: any;
970971
- InterpolantFactoryMethodSmooth: any;
972+
+ constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>);
971973
}
972974
-import { KeyframeTrack } from '../KeyframeTrack.js';
973975
diff --git a/jsdoc-testing/jsdoc/animation/tracks/VectorKeyframeTrack.d.ts b/jsdoc-testing/jsdoc/animation/tracks/VectorKeyframeTrack.d.ts
974-
index 856db2d5..89a16060 100644
976+
index 856db2d5..a7c734c2 100644
975977
--- a/jsdoc-testing/jsdoc/animation/tracks/VectorKeyframeTrack.d.ts
976978
+++ b/jsdoc-testing/jsdoc/animation/tracks/VectorKeyframeTrack.d.ts
977979
@@ -1,7 +1,8 @@
@@ -990,6 +992,6 @@ index 856db2d5..89a16060 100644
990992
* @param {(InterpolateLinear|InterpolateDiscrete|InterpolateSmooth)} [interpolation] - The interpolation type.
991993
*/
992994
- constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: (InterpolateLinear | InterpolateDiscrete | InterpolateSmooth));
993-
+ constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: InterpolationModes);
995+
+ constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>, interpolation?: InterpolationModes);
994996
}
995997
-import { KeyframeTrack } from '../KeyframeTrack.js';

jsdoc-testing/prepare-jsdoc.sh

100644100755
File mode changed.

jsdoc-testing/update-declarations.sh

100644100755
File mode changed.

jsdoc-testing/update-patch.sh

100644100755
File mode changed.

types/three/src/animation/tracks/NumberKeyframeTrack.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ export class NumberKeyframeTrack extends KeyframeTrack {
1313
* @param {Array<number>} values - A list of keyframe values.
1414
* @param {(InterpolateLinear|InterpolateDiscrete|InterpolateSmooth)} [interpolation] - The interpolation type.
1515
*/
16-
constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: InterpolationModes);
16+
constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>, interpolation?: InterpolationModes);
1717
}

types/three/src/animation/tracks/QuaternionKeyframeTrack.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ export class QuaternionKeyframeTrack extends KeyframeTrack {
1313
* @param {Array<number>} values - A list of keyframe values.
1414
* @param {(InterpolateLinear|InterpolateDiscrete|InterpolateSmooth)} [interpolation] - The interpolation type.
1515
*/
16-
constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: InterpolationModes);
16+
constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>, interpolation?: InterpolationModes);
1717
}

types/three/src/animation/tracks/StringKeyframeTrack.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ export class StringKeyframeTrack extends KeyframeTrack {
1414
* @param {Array<number>} times - A list of keyframe times.
1515
* @param {Array<number>} values - A list of keyframe values.
1616
*/
17-
constructor(name: string, times: Array<number>, values: Array<number>);
17+
constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>);
1818
}

types/three/src/animation/tracks/VectorKeyframeTrack.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ export class VectorKeyframeTrack extends KeyframeTrack {
1313
* @param {Array<number>} values - A list of keyframe values.
1414
* @param {(InterpolateLinear|InterpolateDiscrete|InterpolateSmooth)} [interpolation] - The interpolation type.
1515
*/
16-
constructor(name: string, times: Array<number>, values: Array<number>, interpolation?: InterpolationModes);
16+
constructor(name: string, times: ArrayLike<number>, values: ArrayLike<number>, interpolation?: InterpolationModes);
1717
}

0 commit comments

Comments
 (0)