Create Satellite Lists Plugin #1250

thkruz · 2025-11-17T10:26:31Z

…e lists

This commit adds a new SatelliteListsPlugin that extends the watchlist functionality to support multiple named lists of satellites. Key features include:

Create and manage multiple named satellite lists
Add/remove satellites using 6-digit sccnum
Rename and delete individual lists
Export individual lists as JSON files
Import individual lists from JSON files
Export all lists as a collection
Import collections of lists
Persistent storage in offline mode
Full UI integration with side menu and satellite info box

Files added:

src/plugins/satellite-lists/satellite-lists.ts: Main plugin implementation
test/satellite-lists.test.ts: Unit tests for the plugin

Files modified:

src/engine/utils/persistence-manager.ts: Added SATELLITE_LISTS storage key
src/plugins/plugins.ts: Registered the new plugin
src/plugins/keeptrack-plugins-configuration.ts: Added plugin configuration type
src/settings/default-plugins.ts: Enabled plugin by default

…e lists This commit adds a new SatelliteListsPlugin that extends the watchlist functionality to support multiple named lists of satellites. Key features include: - Create and manage multiple named satellite lists - Add/remove satellites using 6-digit sccnum - Rename and delete individual lists - Export individual lists as JSON files - Import individual lists from JSON files - Export all lists as a collection - Import collections of lists - Persistent storage in offline mode - Full UI integration with side menu and satellite info box Files added: - src/plugins/satellite-lists/satellite-lists.ts: Main plugin implementation - test/satellite-lists.test.ts: Unit tests for the plugin Files modified: - src/engine/utils/persistence-manager.ts: Added SATELLITE_LISTS storage key - src/plugins/plugins.ts: Registered the new plugin - src/plugins/keeptrack-plugins-configuration.ts: Added plugin configuration type - src/settings/default-plugins.ts: Enabled plugin by default

CLAassistant · 2025-11-17T10:26:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thkruz
❌ claude
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-17T10:31:40Z

src/plugins/satellite-lists/satellite-lists.ts

+      this.addSatToCurrentList(id, true);
+    });
+
+    this.sortCurrentList();
+    this.updateCurrentListDisplay();


Persist satellites added via side menu

Adding satellites through the side-menu input never hits persistence: onAddSatellites_ calls addSatToCurrentList(id, true), which skips its internal save, and then exits after sorting/updating the view without calling saveLists(). As a result, satellites added via the UI are lost on refresh/offline reload or export unless some later action (rename/delete/etc.) happens to save the list. Saving the list after the batch add would preserve the new entries.

Useful? React with 👍 / 👎.

Copilot

Pull Request Overview

This pull request introduces a new SatelliteListsPlugin that extends the existing watchlist functionality to support multiple named satellite lists. The plugin allows users to create, manage, import, and export collections of satellites for monitoring.

Key Changes

New plugin implementation with full CRUD operations for satellite lists
Persistent storage support in offline mode using browser storage
UI integration with side menu, satellite info box, and optional top menu notification
JSON import/export functionality for individual lists and collections

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
test/satellite-lists.test.ts	Unit tests for basic plugin functionality including list creation, satellite management, and list operations
src/plugins/satellite-lists/satellite-lists.ts	Main plugin implementation with UI, event handling, persistence, and import/export logic
src/settings/default-plugins.ts	Added plugin configuration to enable SatelliteListsPlugin by default at order 42
src/plugins/plugins.ts	Registered the new plugin in the plugin manager initialization
src/plugins/keeptrack-plugins-configuration.ts	Added TypeScript type definition for plugin configuration
src/engine/utils/persistence-manager.ts	Added SATELLITE_LISTS storage key for offline persistence

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-17T10:32:41Z

src/plugins/satellite-lists/satellite-lists.ts

+
+    selectSatManagerInstance?.selectSat(id);
+  }
+


Missing JSDoc documentation. This public method should have documentation describing its parameters and behavior, especially the optional isMultiAdd parameter.

Suggested change

/**

* Adds a satellite to the currently selected list.

*

* @param {number} id - The NORAD ID of the satellite to add.

* @param {boolean} [isMultiAdd=false] - If true, skips sorting, display update, and saving.

* Used when adding multiple satellites in a batch to avoid redundant operations.

*

* If the satellite is already in the list, a warning is shown and it is not added again.

* When isMultiAdd is false (default), the list is sorted, the display is updated, and the lists are saved.

*/

Copilot · 2025-11-17T10:32:42Z

src/plugins/satellite-lists/satellite-lists.ts

+      ServiceLocator.getColorSchemeManager().calculateColorBuffers(true);
+    }
+  }
+


Missing JSDoc documentation. This public method should have documentation describing its parameter and return value.

Suggested change

/**

* Checks if a satellite with the given ID is present in the current list.

* @param id - The ID of the satellite to check.

* @returns True if the satellite is on the current list, false otherwise.

*/

Copilot · 2025-11-17T10:32:42Z

src/plugins/satellite-lists/satellite-lists.ts

+    ServiceLocator.getLineManager().lines.forEach((line) => {
+      if (line instanceof SensorToSatLine && line.sat.id === id) {
+        line.isGarbage = true;
+      }
+    });


Inefficient loop: This forEach iterates over all lines in the line manager to mark SensorToSatLine instances as garbage. If there are many lines, this could be a performance bottleneck. Consider maintaining a map of satellite ID to lines for more efficient removal, or at least break early if possible.

Suggested change

ServiceLocator.getLineManager().lines.forEach((line) => {

if (line instanceof SensorToSatLine && line.sat.id === id) {

line.isGarbage = true;

}

});

// More efficient: filter only relevant lines and mark as garbage

ServiceLocator.getLineManager().lines

.filter((line) => line instanceof SensorToSatLine && line.sat.id === id)

.forEach((line) => { line.isGarbage = true; });

Copilot · 2025-11-17T10:32:42Z

src/plugins/satellite-lists/satellite-lists.ts

+  private clearAllLists() {
+    const orbitManagerInstance = ServiceLocator.getOrbitManager();
+
+    for (const list of this.lists) {
+      for (const obj of list.satellites) {
+        orbitManagerInstance.removeInViewOrbit(obj.id);
+      }
+    }
+
+    ServiceLocator.getLineManager().lines.forEach((line) => {
+      if (line instanceof SensorToSatLine) {
+        line.isGarbage = true;
+      }
+    });


Inefficient nested loops: This code has O(n*m) complexity where n is the number of lists and m is the average number of satellites per list. When clearing all lists, all lines are marked as garbage for every list, which means lines.forEach is called multiple times unnecessarily. Consider consolidating the line cleanup to happen once after all satellites are processed.

Copilot · 2025-11-17T10:32:43Z

src/plugins/satellite-lists/satellite-lists.ts

+      getEl(this.EL.REMOVE_FROM_LIST)!.style.display = 'block';
+      getEl(this.EL.ADD_TO_LIST)!.style.display = 'none';
+    } else {
+      getEl(this.EL.ADD_TO_LIST)!.style.display = 'block';
+      getEl(this.EL.REMOVE_FROM_LIST)!.style.display = 'none';


Missing null check: getEl(this.EL.REMOVE_FROM_LIST) and getEl(this.EL.ADD_TO_LIST) could return null, but the code uses the non-null assertion operator (!) and directly accesses the style property. This could cause a runtime error if the elements don't exist. Add proper null checks.

Suggested change

getEl(this.EL.REMOVE_FROM_LIST)!.style.display = 'block';

getEl(this.EL.ADD_TO_LIST)!.style.display = 'none';

} else {

getEl(this.EL.ADD_TO_LIST)!.style.display = 'block';

getEl(this.EL.REMOVE_FROM_LIST)!.style.display = 'none';

const removeEl = getEl(this.EL.REMOVE_FROM_LIST);

const addEl = getEl(this.EL.ADD_TO_LIST);

if (removeEl) removeEl.style.display = 'block';

if (addEl) addEl.style.display = 'none';

} else {

const addEl = getEl(this.EL.ADD_TO_LIST);

const removeEl = getEl(this.EL.REMOVE_FROM_LIST);

if (addEl) addEl.style.display = 'block';

if (removeEl) removeEl.style.display = 'none';

Copilot · 2025-11-17T10:32:44Z

src/plugins/satellite-lists/satellite-lists.ts

+      getEl('satellite-lists-current-name')!.textContent = 'No List Selected';
+      getEl('satellite-lists-list')!.innerHTML = '';


Missing null check: getEl('satellite-lists-current-name') and getEl('satellite-lists-list') could return null, but the code uses the non-null assertion operator (!) and directly accesses properties. This could cause a runtime error if the elements don't exist.

Copilot · 2025-11-17T10:32:44Z

src/plugins/satellite-lists/satellite-lists.ts

+    getEl('satellite-lists-current-name')!.textContent = currentList.name;
+
+    let listHtml = '';
+    const catalogManagerInstance = ServiceLocator.getCatalogManager();
+
+    for (const obj of currentList.satellites) {
+      const sat = catalogManagerInstance.getSat(obj.id);
+
+      if (!sat) {
+        continue;
+      }
+
+      listHtml += `
+        <div class="row">
+          <div class="col s3 m3 l3">
+            <span class="sat-sccnum" style="cursor: pointer;">${sat.sccNum}</span>
+          </div>
+          <div class="col s7 m7 l7">
+            <span class="sat-name" data-sat-id="${sat.id || 'Unknown'}" style="cursor: pointer;">${sat.name || 'Unknown'}</span>
+          </div>
+          <div class="col s2 m2 l2 center-align remove-icon">
+            <img class="satellite-list-remove" data-sat-id="${sat.id}" src="${bookmarkRemovePng}" style="cursor: pointer;"></img>
+          </div>
+        </div>`;
+    }
+
+    getEl('satellite-lists-list')!.innerHTML = listHtml;


Missing null check: getEl('satellite-lists-current-name') and getEl('satellite-lists-list') could return null, but the code uses the non-null assertion operator (!). This could cause a runtime error if the elements don't exist.

Copilot · 2025-11-17T10:32:45Z

src/plugins/satellite-lists/satellite-lists.ts

+
+export class SatelliteListsPlugin extends KeepTrackPlugin {
+  readonly id = 'SatelliteListsPlugin';
+  dependencies_ = [];


The dependencies_ property is defined as an empty array, but the plugin uses several other plugins and services (SatInfoBox, SelectSatManager, TopMenu). If these are required dependencies, they should be declared here to ensure proper initialization order.

Suggested change

dependencies_ = [];

dependencies_ = ['SatInfoBox', 'SelectSatManager', 'TopMenu'];

Copilot · 2025-11-17T10:32:45Z

src/plugins/satellite-lists/satellite-lists.ts

+    }
+  }
+
+  updateCurrentListDisplay() {


Missing JSDoc documentation. This public method should have documentation describing what it does, especially since it's a key display update method that could be called from other parts of the codebase.

Copilot · 2025-11-17T10:32:45Z

src/plugins/satellite-lists/satellite-lists.ts

+import { getEl, hideEl, showEl } from '@app/engine/utils/get-el';
+import { isThisNode } from '@app/engine/utils/isThisNode';
+import { PersistenceManager, StorageKey } from '@app/engine/utils/persistence-manager';
+import { BaseObject, CatalogSource, DetailedSatellite } from '@ootk/src/main';


Unused import DetailedSatellite.

Suggested change

import { BaseObject, CatalogSource, DetailedSatellite } from '@ootk/src/main';

import { BaseObject, CatalogSource } from '@ootk/src/main';

sonarqubecloud · 2025-11-18T01:41:46Z

Quality Gate failed

Failed conditions
4.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copilot AI review requested due to automatic review settings November 17, 2025 10:26

Copilot started reviewing on behalf of thkruz November 17, 2025 10:27 View session

Copilot finished reviewing on behalf of thkruz November 17, 2025 10:28

chatgpt-codex-connector bot reviewed Nov 17, 2025

View reviewed changes

Copilot AI reviewed Nov 17, 2025

View reviewed changes

thkruz added 2 commits November 17, 2025 20:34

feat: add satellite lists plugin with UI and localization support

6b3498b

feat: update menu mode to include experimental option

cec13f9

thkruz merged commit dfb9155 into develop Nov 18, 2025
7 of 10 checks passed

thkruz deleted the claude/create-watchlist-plugin-01VFamY8C3rngswJTqjMERo7 branch November 18, 2025 01:38

+  /**
+   * Adds a satellite to the currently selected list.
+   *
+   * @param {number} id - The NORAD ID of the satellite to add.
+   * @param {boolean} [isMultiAdd=false] - If true, skips sorting, display update, and saving.
+   *        Used when adding multiple satellites in a batch to avoid redundant operations.
+   *
+   * If the satellite is already in the list, a warning is shown and it is not added again.
+   * When isMultiAdd is false (default), the list is sorted, the display is updated, and the lists are saved.
+   */

+  /**
+   * Checks if a satellite with the given ID is present in the current list.
+   * @param id - The ID of the satellite to check.
+   * @returns True if the satellite is on the current list, false otherwise.
+   */

-      getEl(this.EL.REMOVE_FROM_LIST)!.style.display = 'block';
-      getEl(this.EL.ADD_TO_LIST)!.style.display = 'none';
-    } else {
-      getEl(this.EL.ADD_TO_LIST)!.style.display = 'block';
-      getEl(this.EL.REMOVE_FROM_LIST)!.style.display = 'none';
+      const removeEl = getEl(this.EL.REMOVE_FROM_LIST);
+      const addEl = getEl(this.EL.ADD_TO_LIST);
+      if (removeEl) removeEl.style.display = 'block';
+      if (addEl) addEl.style.display = 'none';
+    } else {
+      const addEl = getEl(this.EL.ADD_TO_LIST);
+      const removeEl = getEl(this.EL.REMOVE_FROM_LIST);
+      if (addEl) addEl.style.display = 'block';
+      if (removeEl) removeEl.style.display = 'none';

		getEl('satellite-lists-current-name')!.textContent = 'No List Selected';
		getEl('satellite-lists-list')!.innerHTML = '';

	dependencies_ = [];
	dependencies_ = ['SatInfoBox', 'SelectSatManager', 'TopMenu'];

	import { BaseObject, CatalogSource, DetailedSatellite } from '@ootk/src/main';
	import { BaseObject, CatalogSource } from '@ootk/src/main';

Create Satellite Lists Plugin #1250

Create Satellite Lists Plugin #1250

Uh oh!

Conversation

thkruz commented Nov 17, 2025

Uh oh!

CLAassistant commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 18, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Nov 17, 2025 •

edited

Loading