refactor: streamline texture loading and splash behavior

- remove GPU sync (fenceSync/flush) in GlUtils to avoid blocking the main thread
- add GlUtils.getBestTexture helper to select the highest available texture quality
- stop tracking Earth hi-res flags and make useHighestQualityTexture a no-op (always load highest first)
- remove splash-screen wait-for-hires gating and extend image preloading delay from 30s to 3 minutes
- change SkyBox default resolution to MEDIUM and remove forced upgrade listener / pre-create texture
- update texture assets (clouds8k, earthbump8k, skybox16k) and delete mars6k
- adjust splash-screen tests to match new hide behavior
- mark plugins-pro submodule dirty

Author: thkruz

public/textures/clouds8k.jpg

@@ -1,8 +1,8 @@
 import { t7e, TranslationKey } from '@app/locales/keys';
 import { getEl, hideEl, showEl } from '../../engine/utils/get-el';
-import { keepTrackApi } from '../../keepTrackApi';
 import { MobileManager } from './mobileManager';
 
+import { EventBus } from '@app/engine/events/event-bus';
 import { EventBusEvent } from '@app/engine/events/event-bus-events';
 import { html } from '@app/engine/utils/development/formatter';
 import blueMarbleJpg from '@public/img/wallpaper/blue-marble.jpg';
@@ -25,7 +25,6 @@ import satJpg from '@public/img/wallpaper/sat.jpg';
 import sat2Jpg from '@public/img/wallpaper/sat2.jpg';
 import telescopeJpg from '@public/img/wallpaper/telescope.jpg';
 import thuleJpg from '@public/img/wallpaper/thule.jpg';
-import { EventBus } from '@app/engine/events/event-bus';
 
 export abstract class SplashScreen {
   /** An image is picked at random and then if the screen is bigger than 1080p then it loads the next one in the list */
@@ -105,15 +104,6 @@ export abstract class SplashScreen {
   }
 
   static hideSplashScreen() {
-    // Don't wait if we are running Jest
-    if (keepTrackApi.getScene().earth.isUseHiRes && keepTrackApi.getScene().earth.isHiResReady !== true) {
-      setTimeout(() => {
-        SplashScreen.hideSplashScreen();
-      }, 100);
-
-      return;
-    }
-
     MobileManager.checkMobileMode();
 
     if (settingsManager.isMobileModeEnabled) {
@@ -192,13 +182,13 @@ export abstract class SplashScreen {
       loadingDom.style.backgroundRepeat = 'no-repeat';
     }
 
-    // Preload the rest of the images after 30 seconds
+    // Preload the rest of the images after 3 minutes
     setTimeout(() => {
       this.splashScreenImgList_.forEach((img) => {
         const preloadImg = new Image();
 
         preloadImg.src = img;
       });
-    }, 30000);
+    }, 3 * 60 * 1000);
   }
 }

public/textures/earthbump8k.jpg

@@ -101,8 +101,6 @@ export class Earth {
     [EarthCloudTextureQuality.ULTRA]: <WebGLTexture><unknown>null,
   };
   private vaoOcclusion_: WebGLVertexArrayObject;
-  isHiResReady: boolean;
-  isUseHiRes: boolean;
   /** Normalized vector pointing to the sun. */
   lightDirection = <vec3>[0, 0, 0];
   surfaceMesh: Mesh;
@@ -147,14 +145,7 @@ export class Earth {
   }
 
   useHighestQualityTexture(): void {
-    settingsManager.earthDayTextureQuality = EarthDayTextureQuality.HIGH;
-    settingsManager.earthNightTextureQuality = EarthNightTextureQuality.HIGH;
-    settingsManager.earthBumpTextureQuality = EarthBumpTextureQuality.HIGH;
-    settingsManager.earthSpecTextureQuality = EarthSpecTextureQuality.HIGH;
-    settingsManager.earthPoliticalTextureQuality = EarthPoliticalTextureQuality.HIGH;
-    settingsManager.earthCloudTextureQuality = EarthCloudTextureQuality.ULTRA;
-
-    this.initTextures_();
+    // Nothing to do here since we always load the highest quality first
   }
 
   /**

public/textures/mars6k.jpg

@@ -1,5 +1,3 @@
-import { EventBus } from '@app/engine/events/event-bus';
-import { EventBusEvent } from '@app/engine/events/event-bus-events';
 import { GlUtils } from '@app/engine/rendering/gl-utils';
 import { GLSL3 } from '@app/engine/rendering/material';
 import { Mesh } from '@app/engine/rendering/mesh';
@@ -40,7 +38,7 @@ export class SkyBoxSphere {
   private textureGraySkybox_: WebGLTexture;
   mesh: Mesh;
   private isLoaded_ = false;
-  DEFAULT_RESOLUTION = MilkyWayTextureQuality.LOW;
+  DEFAULT_RESOLUTION = MilkyWayTextureQuality.MEDIUM;
   MILKYWAY_SRC_BASE = 'skybox';
   textureMilkyWay: Record<MilkyWayTextureQuality, WebGLTexture> = {
     [MilkyWayTextureQuality.OFF]: <WebGLTexture><unknown>null,
@@ -226,11 +224,6 @@ export class SkyBoxSphere {
     });
     this.mesh.geometry.initVao(this.mesh.program);
 
-    EventBus.getInstance().on(EventBusEvent.onKeepTrackReady, () => {
-      settingsManager.milkyWayTextureQuality = MilkyWayTextureQuality.ULTRA;
-      this.initTextures_();
-    });
-
     this.isLoaded_ = true;
   }
 
@@ -252,7 +245,6 @@ export class SkyBoxSphere {
     sm.milkyWayTextureQuality ??= this.DEFAULT_RESOLUTION;
 
     if (sm.isDrawMilkyWay && !this.textureMilkyWay[sm.milkyWayTextureQuality] && sm.milkyWayTextureQuality !== MilkyWayTextureQuality.OFF) {
-      this.textureMilkyWay[sm.milkyWayTextureQuality] = this.gl_.createTexture();
       GlUtils.initTexture(this.gl_, `${this.getSrc_(this.MILKYWAY_SRC_BASE, sm.milkyWayTextureQuality, 'jpg')}`).then((texture) => {
         this.textureMilkyWay[sm.milkyWayTextureQuality] = texture;
         this.isTexturesReady_ = true;

public/textures/skybox16k.jpg

@@ -109,10 +109,6 @@ export abstract class GlUtils {
       gl.bindTexture(gl.TEXTURE_2D, texture);
       gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGNED_BYTE, imgBitmap);
 
-      // eslint-disable-next-line no-sync
-      gl.fenceSync(gl.SYNC_GPU_COMMANDS_COMPLETE, 0);
-      gl.flush(); // don’t block
-
       if (GlUtils.isPowerOf2(imgBitmap.width) && GlUtils.isPowerOf2(imgBitmap.height)) {
         // power of 2: generate mipmaps and set trilinear filtering + repeat
         gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR_MIPMAP_LINEAR);
@@ -145,6 +141,28 @@ export abstract class GlUtils {
     }
   }
 
+  static getBestTexture(textureMap: Record<string, WebGLTexture>): WebGLTexture {
+    const qualityOrder = [
+      '16k',
+      '8k',
+      '4k',
+      '2k',
+      '1k',
+      '512',
+    ];
+
+    for (const quality of qualityOrder) {
+      const texture = textureMap[quality];
+
+      if (texture) {
+        return texture;
+      }
+    }
+
+    // If no texture is found, return null
+    return null as unknown as WebGLTexture;
+  }
+
   /**
    * Deteremine if a number is a power of 2.
    */

src/app/ui/splash-screen.ts

@@ -26,8 +26,6 @@ describe('SplashScreen_class', () => {
 
   // Tests that the loading screen is resized and hidden after a timeout when running on desktop
   it('test_hide_splash_screen_desktop', () => {
-    keepTrackApi.getScene().earth.isUseHiRes = true;
-    keepTrackApi.getScene().earth.isHiResReady = true;
     SplashScreen.hideSplashScreen();
     // Wait for timers to finish
     jest.advanceTimersByTime(1000);