Skip to content

Commit ce2cefe

Browse files
authored
Update webextension's packages and fix code for Node.js 16 (#96)
1 parent 0ee1f51 commit ce2cefe

File tree

6 files changed

+1619
-2351
lines changed

6 files changed

+1619
-2351
lines changed

.github/workflows/test.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
runs-on: ${{ matrix.os }}
1111
strategy:
1212
matrix:
13-
node-version: [ 18, 20, 22 ]
13+
node-version: [ 16, 18, 20, 22 ]
1414
os: [ ubuntu-latest, windows-latest ]
1515
steps:
1616
- name: checkout
@@ -22,5 +22,11 @@ jobs:
2222
node-version: ${{ matrix.node-version }}
2323
- name: Install
2424
run: yarn install
25+
- name: Build
26+
run: yarn run build
27+
- name: Build webextension (Chrome)
28+
run: npm run dist chrome
29+
if: matrix.node-version == 16
30+
working-directory: packages/webextension
2531
- name: Test
2632
run: yarn test

packages/@textlint/script-compiler/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"devDependencies": {
7575
"@types/mocha": "^10.0.1",
7676
"@types/node": "^18.13.0",
77-
"@types/webpack": "^4.41.26",
77+
"@types/webpack": "^5.28.5",
7878
"mocha": "^8.4.0",
7979
"prettier": "^2.3.0",
8080
"textlint-rule-no-dropping-the-ra": "^3.0.0",

packages/webextension/app/scripts/InstalledApp/pages/EditPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ const useForm = (props: ScriptMetaProps) => {
124124
} catch (error) {
125125
return {
126126
...prevState,
127-
textlintrc: error
127+
textlintrc: error instanceof Error ? error : null
128128
};
129129
}
130130
});

packages/webextension/package.json

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@
1414
"@types/reach__router": "^1.3.6",
1515
"@types/react": "^17.0.0",
1616
"@types/react-dom": "^17.0.0",
17-
"copy-webpack-plugin": "^7.0.0",
18-
"css-loader": "^5.0.1",
17+
"copy-webpack-plugin": "9.0.1",
18+
"css-loader": "^6.11.0",
19+
"path-browserify": "^1.0.1",
1920
"style-loader": "^1.2.1",
20-
"ts-loader": "^8.0.14",
21-
"webextension-toolbox": "^3.0.0",
22-
"webpack": "^4.44.0",
21+
"ts-loader": "^8.4.0",
22+
"webextension-toolbox": "^4.0.3",
23+
"webpack": "5.42.0",
24+
"webpack-sources": "^2.3.0",
2325
"webpack-watched-glob-entries-plugin": "^2.1.9"
2426
},
2527
"dependencies": {

packages/webextension/webextension-toolbox-config.js renamed to packages/webextension/webextension-toolbox.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ module.exports = {
77
// Add typescript loader. supports .ts and .tsx files as entry points
88
config.resolve.extensions.push(".ts");
99
config.resolve.extensions.push(".tsx");
10+
config.resolve.fallback = { path: require.resolve("path-browserify") };
1011
config.entry = GlobEntriesPlugin.getEntries([
1112
path.resolve("app", "*.{js,mjs,jsx,ts,tsx}"),
1213
path.resolve("app", "?(scripts)/*.{js,mjs,jsx,ts,tsx}")

0 commit comments

Comments
 (0)