disable fail fast

Author: ianjennings

.github/workflows/acceptance.yaml

@@ -1,4 +1,4 @@
-name: Linux Tests
+name: Acceptance Tests
 
 on:
   push:
@@ -12,6 +12,7 @@ jobs:
     strategy:
       matrix:
         os: [linux, windows]
+      fail-fast: false
 
     steps:
     - uses: actions/checkout@v4

lib/vitest/hooks.mjs

@@ -20,6 +20,7 @@ import os from 'os';
 import path from 'path';
 import { vi } from 'vitest';
 import TestDriverSDK from '../../sdk.js';
+import { events } from '../../agent/events.js';
 
 /**
  * Set up console spies using Vitest's vi.spyOn to intercept console logs
@@ -103,7 +104,7 @@ function setupConsoleSpy(client, taskId) {
   // Store spies on client for cleanup
   client._consoleSpies = { logSpy, errorSpy, warnSpy, infoSpy };
 
-  console.log(`[testdriver] Console spy set up for task: ${taskId}`);
+  client.emitter.emit(events.log.debug, `Console spy set up for task: ${taskId}`);
 }
 
 /**
@@ -166,9 +167,7 @@ export function TestDriver(context, options = {}) {
   // Priority: test options > plugin options > environment variable > default (linux)
   if (!mergedOptions.os && process.env.TD_OS) {
     mergedOptions.os = process.env.TD_OS;
-    console.log(`[testdriver] Set mergedOptions.os = ${mergedOptions.os} from TD_OS environment variable`);
   }
-  console.log(`[testdriver] Final mergedOptions.os = ${mergedOptions.os}`);
 
   // Extract TestDriver-specific options
   const apiKey = mergedOptions.apiKey || process.env.TD_API_KEY;
@@ -186,21 +185,27 @@ export function TestDriver(context, options = {}) {
   testdriver.__vitestContext = context.task;
   testDriverInstances.set(context.task, testdriver);
 
+  // Log OS detection after testdriver is created
+  if (process.env.TD_OS) {
+    testdriver.emitter.emit(events.log.debug, `Set mergedOptions.os = ${mergedOptions.os} from TD_OS environment variable`);
+  }
+  testdriver.emitter.emit(events.log.debug, `Final mergedOptions.os = ${mergedOptions.os}`);
+  
   // Auto-connect if enabled (default: true)
   const autoConnect = config.autoConnect !== undefined ? config.autoConnect : true;
   const debugConsoleSpy = process.env.TD_DEBUG_CONSOLE_SPY === 'true';
 
   if (autoConnect) {
     testdriver.__connectionPromise = (async () => {
-        console.log('[testdriver] Connecting to sandbox...');
+        testdriver.emitter.emit(events.log.debug, 'Connecting to sandbox...');
         if (debugConsoleSpy) {
           console.log('[DEBUG] Before auth - sandbox.instanceSocketConnected:', testdriver.sandbox?.instanceSocketConnected);
         }
 
         await testdriver.auth();
         await testdriver.connect();
 
-        console.log('[testdriver] ✅ Connected to sandbox');
+        testdriver.emitter.emit(events.log.debug, '✅ Connected to sandbox');
 
         if (debugConsoleSpy) {
           console.log('[DEBUG] After connect - sandbox.instanceSocketConnected:', testdriver.sandbox?.instanceSocketConnected);
@@ -221,8 +226,8 @@ export function TestDriver(context, options = {}) {
           : `touch ${logPath}`;
 
         await testdriver.exec(shell, createLogCmd, 10000, true);
-        console.log('[testdriver] ✅ Created log file:', logPath);
-        
+        testdriver.emitter.emit(events.log.debug, `✅ Created log file: ${logPath}`);
+
         // Add automatic log tracking when dashcam starts
         // Store original start method
 
@@ -234,20 +239,20 @@ export function TestDriver(context, options = {}) {
   // Register cleanup handler with dashcam.stop()
   if (!lifecycleHandlers.has(context.task)) {
     const cleanup = async () => {
-      console.log('[testdriver] Cleaning up TestDriver client...');
+      testdriver.emitter.emit(events.log.debug, 'Cleaning up TestDriver client...');
       try {
         // Stop dashcam if it was started - with timeout to prevent hanging
         if (testdriver._dashcam && testdriver._dashcam.recording) {
           try {
             const dashcamUrl = await testdriver.dashcam.stop();
-            console.log('🎥 Dashcam URL:', dashcamUrl);
+            testdriver.emitter.emit(events.log.debug, `🎥 Dashcam URL: ${dashcamUrl}`);
 
             // Write test result to file for the reporter (cross-process communication)
             // This should happen regardless of whether dashcam succeeded, to ensure platform info is available
             const testId = context.task.id;
-            console.log(`[testdriver] testdriver.os value: ${testdriver.os}`);
+            testdriver.emitter.emit(events.log.debug, `testdriver.os value: ${testdriver.os}`);
             const platform = testdriver.os || 'linux';
-            console.log(`[testdriver] Using platform: ${platform}`);
+            testdriver.emitter.emit(events.log.debug, `Using platform: ${platform}`);
             const absolutePath = context.task.file?.filepath || context.task.file?.name || 'unknown';
             const projectRoot = process.cwd();
             const testFile = absolutePath !== 'unknown'
@@ -271,12 +276,12 @@ export function TestDriver(context, options = {}) {
             };
 
             fs.writeFileSync(testResultFile, JSON.stringify(testResult, null, 2));
-            console.log(`[testdriver] ✅ Wrote test result to ${testResultFile}`);
+            testdriver.emitter.emit(events.log.debug, `✅ Wrote test result to ${testResultFile}`);
 
             // Also register in memory if plugin is available
             if (globalThis.__testdriverPlugin?.registerDashcamUrl) {
               globalThis.__testdriverPlugin.registerDashcamUrl(testId, dashcamUrl, platform);
-              console.log(`[testdriver] ✅ Registered test result in memory for test ${testId}`);
+              testdriver.emitter.emit(events.log.debug, `✅ Registered test result in memory for test ${testId}`);
             }
           } catch (error) {
             // Log more detailed error information for debugging
@@ -306,7 +311,7 @@ export function TestDriver(context, options = {}) {
           testdriver.disconnect(),
           new Promise((resolve) => setTimeout(resolve, 5000)) // 5s timeout for disconnect
         ]);
-        console.log('✅ Client disconnected');
+        testdriver.emitter.emit(events.log.debug, '✅ Client disconnected');
       } catch (error) {
         console.error('Error disconnecting client:', error);
       }

sdk.js

@@ -1102,7 +1102,7 @@ class TestDriverSDK {
 
     // Store os and resolution for API requests
     this.os = options.os || "linux";
-    console.log(`[SDK Constructor] Setting this.os = ${this.os} (from options.os = ${options.os})`);
+    this.emitter.emit(events.log.debug, `Setting this.os = ${this.os} (from options.os = ${options.os})`);
     this.resolution = options.resolution || "1366x768";
 
     // Store newSandbox preference from options
@@ -1270,26 +1270,26 @@ class TestDriverSDK {
 
             await this.exec(shell, createLogCmd, 10000, true);
 
-          console.log('[provision.chrome] Adding web logs to dashcam...');
+          this.emitter.emit(events.log.debug, 'Adding web logs to dashcam...');
           try {
             const urlObj = new URL(url);
             const domain = urlObj.hostname;
             const pattern = `*${domain}*`;
             await this._dashcam.addWebLog(pattern, 'Web Logs');
-            console.log(`[provision.chrome] ✅ Web logs added to dashcam (pattern: ${pattern})`);
+            this.emitter.emit(events.log.debug, `✅ Web logs added to dashcam (pattern: ${pattern})`);
 
             await this._dashcam.addFileLog(logPath, "TestDriver Log");
 
           } catch (error) {
-            console.warn('[provision.chrome] ⚠️  Failed to add web logs:', error.message);
+            this.emitter.emit(events.log.warn, `⚠️  Failed to add web logs: ${error.message}`);
           }
         }
 
         // Automatically start dashcam if not already recording
         if (!this._dashcam || !this._dashcam.recording) {
-          console.log('[provision.chrome] Starting dashcam...');
+          this.emitter.emit(events.log.debug, 'Starting dashcam...');
           await this.dashcam.start();
-          console.log('[provision.chrome] ✅ Dashcam started');
+          this.emitter.emit(events.log.debug, '✅ Dashcam started');
         }
 
         // Set up Chrome profile with preferences
@@ -1345,7 +1345,7 @@ class TestDriverSDK {
           : `cat > "${prefsPath}" << 'EOF'\n${prefsJson}\nEOF`;
 
         await this.exec(shell, writePrefCmd, 10000, true);
-        console.log('[provision.chrome] ✅ Chrome preferences configured');
+        this.emitter.emit(events.log.debug, '✅ Chrome preferences configured');
 
         // Build Chrome launch command
         const chromeArgs = [];
@@ -1384,15 +1384,15 @@ class TestDriverSDK {
           const urlObj = new URL(url);
           const domain = urlObj.hostname;
 
-          console.log(`[provision.chrome] Waiting for domain "${domain}" to appear in URL bar...`);
+          this.emitter.emit(events.log.debug, `Waiting for domain "${domain}" to appear in URL bar...`);
 
           for (let attempt = 0; attempt < 30; attempt++) {
             const result = await this.find(`${domain}`);
 
-            console.log(`[provision.chrome] Checking for domain in URL bar (attempt ${attempt + 1}/30)...`);
+            this.emitter.emit(events.log.debug, `Checking for domain in URL bar (attempt ${attempt + 1}/30)...`);
 
             if (result.found()) {
-              console.log(`[provision.chrome] ✅ Chrome ready at ${url}`);
+              this.emitter.emit(events.log.debug, `✅ Chrome ready at ${url}`);
               break;
             } else {
               await new Promise(resolve => setTimeout(resolve, 1000));
@@ -1451,7 +1451,7 @@ class TestDriverSDK {
 
         // Wait for VS Code to be ready
         await this.focusApplication('Visual Studio Code');
-        console.log('[provision.vscode] ✅ VS Code ready');
+        this.emitter.emit(events.log.debug, '✅ VS Code ready');
       },
 
       /**
@@ -1488,7 +1488,7 @@ class TestDriverSDK {
         }
 
         await this.focusApplication('Electron');
-        console.log('[provision.electron] ✅ Electron app ready');
+        this.emitter.emit(events.log.debug, '✅ Electron app ready');
       },
     };
   }
@@ -1590,11 +1590,11 @@ class TestDriverSDK {
 
     // Ensure this.os reflects the actual sandbox OS (important for vitest reporter)
     // After buildEnv, agent.sandboxOs should contain the correct OS value
-    console.log(`[SDK] After buildEnv: this.agent.sandboxOs = ${this.agent.sandboxOs}, this.os (before) = ${this.os}`);
+    this.emitter.emit(events.log.debug, `After buildEnv: this.agent.sandboxOs = ${this.agent.sandboxOs}, this.os (before) = ${this.os}`);
     if (this.agent.sandboxOs) {
       this.os = this.agent.sandboxOs;
     }
-    console.log(`[SDK] After buildEnv: this.os (after) = ${this.os}`);
+    this.emitter.emit(events.log.debug, `After buildEnv: this.os (after) = ${this.os}`);
 
     // Also ensure sandbox.os is set for consistency
     if (this.agent.sandbox && this.os) {