Skip to content

Conversation

@bsideup
Copy link
Member

@bsideup bsideup commented May 28, 2020

No description provided.

@bsideup bsideup changed the title Upgrade to docker-java 3.2.2-rc1, try Apache HttpClient5 Upgrade to docker-java 3.2.2, try Apache HttpClient5 Jun 1, 2020
@bsideup
Copy link
Member Author

bsideup commented Jun 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jun 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jun 4, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Comment on lines +151 to +156
final DockerClient client = new DelegatingDockerClient(strategy.getClient()) {
@Override
public void close() {
throw new IllegalStateException("You should never close the global DockerClient!");
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@bsideup bsideup marked this pull request as ready for review June 8, 2020 19:34
@bsideup bsideup requested a review from kiview as a code owner June 8, 2020 19:34
@bsideup bsideup added this to the next milestone Jun 9, 2020
@bsideup bsideup merged commit 780b8e3 into master Jun 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the try_apache_httpclient5 branch June 15, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants