Skip to content

Conversation

@rnorth
Copy link
Member

@rnorth rnorth commented Apr 5, 2020

Generate GitHub Actions CI jobs for modules
Refs #2177, #1836

PR 1 of 2: this PR includes a script for generating the CI job configuration, but the script has to be manually run
A future PR should run the generation script automatically as a separate Action and commit changes, so that no manual updates are needed

@rnorth rnorth requested review from bsideup and kiview as code owners April 5, 2020 12:12
@rnorth rnorth force-pushed the generate-github-ci-1 branch from d04e514 to e645c2c Compare April 5, 2020 12:14

generate_preface
generate_job compile "build -x test"
generate_job core "testcontainers:check" compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if shared compile (1 busy worker) actually helps. Have you done some measurements yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, so I removed it 😄

@rnorth
Copy link
Member Author

rnorth commented Apr 5, 2020

Indicative timings:

A fully cached (S3 remote build cache) build: 6m25s

A completely uncached build (with --no-build-cache): 19m56s

For the uncached build, the longest job, and therefore bottleneck is jdbc-test. The core module is approx 14mins.

Therefore I think we could reduce the max build time to ~14mins by splitting up the JDBC testing for each DB into the relevant modules, to take advantage of parallelisation.

Further performance gains could be possible by splitting up the core job, but that may take more effort.

@rnorth rnorth force-pushed the generate-github-ci-1 branch from e3ca0bc to 12bb3bd Compare April 12, 2020 09:02
@rnorth rnorth requested a review from bsideup April 16, 2020 19:41
Copy link
Member Author

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The up-to-date awareness makes this vastly better!

Let's 🚢 !

@rnorth rnorth changed the title Generate GitHub and Azure Pipelines CI Jobs Generate GitHub Actions CI Jobs Apr 18, 2020
@rnorth rnorth changed the title Generate GitHub Actions CI Jobs Generate GitHub Actions CI Jobs automatically Apr 18, 2020
@rnorth rnorth merged commit 1ef6fac into master Apr 18, 2020
@rnorth rnorth deleted the generate-github-ci-1 branch April 18, 2020 09:31
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants