Skip to content

Commit 5121964

Browse files
authored
Move database tests to JUnit Jupiter (#10786)
* Move jdbc-test tests to JUnit Jupiter * Move r2dbc tests to JUnit Jupiter * Move ClickHouse tests to JUnit Jupiter * Move CockroachDB tests to JUnit Jupiter * Move CrateDB tests to JUnit Jupiter * Move Databend tests to JUnit Jupiter * Move DB2 tests to JUnit Jupiter * Move MariaDB tests to JUnit Jupiter * Move MSSQL Server tests to JUnit Jupiter * Move MySQL tests to JUnit Jupiter * Move OceanBase tests to JUnit Jupiter * Move Oracle Free tests to JUnit Jupiter * Move Oracle XE tests to JUnit Jupiter * Move PostgreSQL tests to JUnit Jupiter * Move Presto tests to JUnit Jupiter * Move QuestDB tests to JUnit Jupiter * Move TiDB tests to JUnit Jupiter * Move Timeplus tests to JUnit Jupiter * Move Trino tests to JUnit Jupiter * Move YugabyteDB tests to JUnit Jupiter
1 parent a70dbdd commit 5121964

File tree

76 files changed

+398
-378
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+398
-378
lines changed

modules/clickhouse/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,15 @@ dependencies {
1010
testImplementation project(':testcontainers-jdbc-test')
1111
testRuntimeOnly(group: 'com.clickhouse', name: 'clickhouse-jdbc', version: '0.9.1', classifier: 'all')
1212

13+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'
14+
15+
testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
1316
testImplementation 'org.assertj:assertj-core:3.27.4'
1417
testImplementation 'com.clickhouse:client-v2:0.9.1'
1518
testImplementation testFixtures(project(':testcontainers-r2dbc'))
1619
testRuntimeOnly(group: 'com.clickhouse', name: 'clickhouse-r2dbc', version: '0.9.1', classifier: 'http')
1720
}
21+
22+
test {
23+
useJUnitPlatform()
24+
}

modules/clickhouse/src/test/java/org/testcontainers/clickhouse/ClickHouseContainerTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import com.clickhouse.client.api.Client;
44
import com.clickhouse.client.api.data_formats.ClickHouseBinaryFormatReader;
55
import com.clickhouse.client.api.query.QueryResponse;
6-
import org.junit.Test;
6+
import org.junit.jupiter.api.Test;
77
import org.testcontainers.ClickhouseTestImages;
88
import org.testcontainers.db.AbstractContainerDatabaseTest;
99

@@ -16,10 +16,10 @@
1616
import static org.assertj.core.api.Assertions.assertThat;
1717
import static org.assertj.core.api.Assertions.fail;
1818

19-
public class ClickHouseContainerTest extends AbstractContainerDatabaseTest {
19+
class ClickHouseContainerTest extends AbstractContainerDatabaseTest {
2020

2121
@Test
22-
public void testSimple() throws SQLException {
22+
void testSimple() throws SQLException {
2323
try ( // container {
2424
ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:21.11-alpine")
2525
// }
@@ -34,7 +34,7 @@ public void testSimple() throws SQLException {
3434
}
3535

3636
@Test
37-
public void customCredentialsWithUrlParams() throws SQLException {
37+
void customCredentialsWithUrlParams() throws SQLException {
3838
try (
3939
ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:21.11.2-alpine")
4040
.withUsername("default")
@@ -56,7 +56,7 @@ public void customCredentialsWithUrlParams() throws SQLException {
5656
}
5757

5858
@Test
59-
public void testNewAuth() throws SQLException {
59+
void testNewAuth() throws SQLException {
6060
try (ClickHouseContainer clickhouse = new ClickHouseContainer(ClickhouseTestImages.CLICKHOUSE_24_12_IMAGE)) {
6161
clickhouse.start();
6262

@@ -68,7 +68,7 @@ public void testNewAuth() throws SQLException {
6868
}
6969

7070
@Test
71-
public void testGetHttpMethodWithHttpClient() {
71+
void testGetHttpMethodWithHttpClient() {
7272
ClickHouseContainer clickhouse = new ClickHouseContainer(ClickhouseTestImages.CLICKHOUSE_24_12_IMAGE);
7373
clickhouse.start();
7474
Client client = new Client.Builder()

modules/clickhouse/src/test/java/org/testcontainers/jdbc/clickhouse/ClickhouseJDBCDriverTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
package org.testcontainers.jdbc.clickhouse;
22

3-
import org.junit.runner.RunWith;
4-
import org.junit.runners.Parameterized;
53
import org.testcontainers.jdbc.AbstractJDBCDriverTest;
64

75
import java.util.Arrays;
86
import java.util.EnumSet;
97

10-
@RunWith(Parameterized.class)
11-
public class ClickhouseJDBCDriverTest extends AbstractJDBCDriverTest {
8+
class ClickhouseJDBCDriverTest extends AbstractJDBCDriverTest {
129

13-
@Parameterized.Parameters(name = "{index} - {0}")
1410
public static Iterable<Object[]> data() {
1511
return Arrays.asList(
1612
new Object[][] { //

modules/clickhouse/src/test/java/org/testcontainers/junit/clickhouse/SimpleClickhouseTest.java

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,20 @@
11
package org.testcontainers.junit.clickhouse;
22

3-
import org.junit.Test;
4-
import org.junit.runner.RunWith;
5-
import org.junit.runners.Parameterized;
3+
import org.junit.jupiter.api.Test;
64
import org.testcontainers.ClickhouseTestImages;
75
import org.testcontainers.containers.ClickHouseContainer;
86
import org.testcontainers.db.AbstractContainerDatabaseTest;
9-
import org.testcontainers.utility.DockerImageName;
107

118
import java.sql.ResultSet;
129
import java.sql.SQLException;
1310

1411
import static org.assertj.core.api.Assertions.assertThat;
1512

16-
@RunWith(Parameterized.class)
17-
public class SimpleClickhouseTest extends AbstractContainerDatabaseTest {
18-
19-
private final DockerImageName imageName;
20-
21-
public SimpleClickhouseTest(DockerImageName imageName) {
22-
this.imageName = imageName;
23-
}
24-
25-
@Parameterized.Parameters(name = "{0}")
26-
public static Object[][] data() {
27-
return new Object[][] { //
28-
{ ClickhouseTestImages.CLICKHOUSE_IMAGE },
29-
};
30-
}
13+
class SimpleClickhouseTest extends AbstractContainerDatabaseTest {
3114

3215
@Test
3316
public void testSimple() throws SQLException {
34-
try (ClickHouseContainer clickhouse = new ClickHouseContainer(this.imageName)) {
17+
try (ClickHouseContainer clickhouse = new ClickHouseContainer(ClickhouseTestImages.CLICKHOUSE_IMAGE)) {
3518
clickhouse.start();
3619

3720
ResultSet resultSet = performQuery(clickhouse, "SELECT 1");

modules/cockroachdb/build.gradle

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ description = "Testcontainers :: JDBC :: CockroachDB"
33
dependencies {
44
api project(':testcontainers-jdbc')
55

6-
testImplementation project(':testcontainers-jdbc-test')
76
testRuntimeOnly 'org.postgresql:postgresql:42.7.7'
7+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'
8+
9+
testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
10+
testImplementation project(':testcontainers-jdbc-test')
811
testImplementation 'org.assertj:assertj-core:3.27.4'
912
}
1013

@@ -13,3 +16,7 @@ tasks.japicmp {
1316
"org.testcontainers.containers.CockroachContainer"
1417
]
1518
}
19+
20+
test {
21+
useJUnitPlatform()
22+
}

modules/cockroachdb/src/test/java/org/testcontainers/jdbc/cockroachdb/CockroachDBJDBCDriverTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
package org.testcontainers.jdbc.cockroachdb;
22

3-
import org.junit.runner.RunWith;
4-
import org.junit.runners.Parameterized;
53
import org.testcontainers.jdbc.AbstractJDBCDriverTest;
64

75
import java.util.Arrays;
86
import java.util.EnumSet;
97

10-
@RunWith(Parameterized.class)
11-
public class CockroachDBJDBCDriverTest extends AbstractJDBCDriverTest {
8+
class CockroachDBJDBCDriverTest extends AbstractJDBCDriverTest {
129

13-
@Parameterized.Parameters(name = "{index} - {0}")
1410
public static Iterable<Object[]> data() {
1511
return Arrays.asList(
1612
new Object[][] { //

modules/cockroachdb/src/test/java/org/testcontainers/junit/cockroachdb/SimpleCockroachDBTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.testcontainers.junit.cockroachdb;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44
import org.testcontainers.CockroachDBTestImages;
55
import org.testcontainers.containers.CockroachContainer;
66
import org.testcontainers.db.AbstractContainerDatabaseTest;
@@ -14,14 +14,14 @@
1414
import static org.assertj.core.api.Assertions.assertThat;
1515
import static org.assertj.core.api.Assertions.assertThatThrownBy;
1616

17-
public class SimpleCockroachDBTest extends AbstractContainerDatabaseTest {
17+
class SimpleCockroachDBTest extends AbstractContainerDatabaseTest {
1818
static {
1919
// Postgres JDBC driver uses JUL; disable it to avoid annoying, irrelevant, stderr logs during connection testing
2020
LogManager.getLogManager().getLogger("").setLevel(Level.OFF);
2121
}
2222

2323
@Test
24-
public void testSimple() throws SQLException {
24+
void testSimple() throws SQLException {
2525
try ( // container {
2626
CockroachContainer cockroach = new CockroachContainer("cockroachdb/cockroach:v22.2.3")
2727
// }
@@ -36,7 +36,7 @@ public void testSimple() throws SQLException {
3636
}
3737

3838
@Test
39-
public void testExplicitInitScript() throws SQLException {
39+
void testExplicitInitScript() throws SQLException {
4040
try (
4141
CockroachContainer cockroach = new CockroachContainer(CockroachDBTestImages.COCKROACHDB_IMAGE)
4242
.withInitScript("somepath/init_postgresql.sql")
@@ -51,7 +51,7 @@ public void testExplicitInitScript() throws SQLException {
5151
}
5252

5353
@Test
54-
public void testWithAdditionalUrlParamInJdbcUrl() {
54+
void testWithAdditionalUrlParamInJdbcUrl() {
5555
CockroachContainer cockroach = new CockroachContainer(CockroachDBTestImages.COCKROACHDB_IMAGE)
5656
.withUrlParam("sslmode", "disable")
5757
.withUrlParam("application_name", "cockroach");
@@ -70,7 +70,7 @@ public void testWithAdditionalUrlParamInJdbcUrl() {
7070
}
7171

7272
@Test
73-
public void testWithUsernamePasswordDatabase() throws SQLException {
73+
void testWithUsernamePasswordDatabase() throws SQLException {
7474
try (
7575
CockroachContainer cockroach = new CockroachContainer(
7676
CockroachDBTestImages.FIRST_COCKROACHDB_IMAGE_WITH_ENV_VARS_SUPPORT
@@ -92,7 +92,7 @@ public void testWithUsernamePasswordDatabase() throws SQLException {
9292
}
9393

9494
@Test
95-
public void testAnExceptionIsThrownWhenImageDoesNotSupportEnvVars() {
95+
void testAnExceptionIsThrownWhenImageDoesNotSupportEnvVars() {
9696
CockroachContainer cockroachContainer = new CockroachContainer(
9797
CockroachDBTestImages.COCKROACHDB_IMAGE_WITH_ENV_VARS_UNSUPPORTED
9898
);
@@ -111,7 +111,7 @@ public void testAnExceptionIsThrownWhenImageDoesNotSupportEnvVars() {
111111
}
112112

113113
@Test
114-
public void testInitializationScript() throws SQLException {
114+
void testInitializationScript() throws SQLException {
115115
String sql =
116116
"USE postgres; \n" +
117117
"CREATE TABLE bar (foo VARCHAR(255)); \n" +

modules/cratedb/build.gradle

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,15 @@ description = "Testcontainers :: JDBC :: CrateDB"
33
dependencies {
44
api project(':testcontainers-jdbc')
55

6-
testImplementation project(':testcontainers-jdbc-test')
76
testRuntimeOnly 'org.postgresql:postgresql:42.7.7'
7+
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.0'
8+
9+
testImplementation 'org.junit.jupiter:junit-jupiter:5.13.4'
10+
testImplementation project(':testcontainers-jdbc-test')
811

912
compileOnly 'org.jetbrains:annotations:26.0.2'
1013
}
14+
15+
test {
16+
useJUnitPlatform()
17+
}

modules/cratedb/src/test/java/org/testcontainers/jdbc/cratedb/CrateDBJDBCDriverTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
package org.testcontainers.jdbc.cratedb;
22

3-
import org.junit.runner.RunWith;
4-
import org.junit.runners.Parameterized;
53
import org.testcontainers.jdbc.AbstractJDBCDriverTest;
64

75
import java.util.Arrays;
86
import java.util.EnumSet;
97

10-
@RunWith(Parameterized.class)
11-
public class CrateDBJDBCDriverTest extends AbstractJDBCDriverTest {
8+
class CrateDBJDBCDriverTest extends AbstractJDBCDriverTest {
129

13-
@Parameterized.Parameters(name = "{index} - {0}")
1410
public static Iterable<Object[]> data() {
1511
return Arrays.asList(
1612
new Object[][] {

modules/cratedb/src/test/java/org/testcontainers/junit/cratedb/SimpleCrateDBTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.testcontainers.junit.cratedb;
22

3-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
44
import org.testcontainers.CrateDBTestImages;
55
import org.testcontainers.cratedb.CrateDBContainer;
66
import org.testcontainers.db.AbstractContainerDatabaseTest;
@@ -12,14 +12,14 @@
1212

1313
import static org.assertj.core.api.Assertions.assertThat;
1414

15-
public class SimpleCrateDBTest extends AbstractContainerDatabaseTest {
15+
class SimpleCrateDBTest extends AbstractContainerDatabaseTest {
1616
static {
1717
// Postgres JDBC driver uses JUL; disable it to avoid annoying, irrelevant, stderr logs during connection testing
1818
LogManager.getLogManager().getLogger("").setLevel(Level.OFF);
1919
}
2020

2121
@Test
22-
public void testSimple() throws SQLException {
22+
void testSimple() throws SQLException {
2323
try ( // container {
2424
CrateDBContainer cratedb = new CrateDBContainer("crate:5.2.5")
2525
// }
@@ -34,7 +34,7 @@ public void testSimple() throws SQLException {
3434
}
3535

3636
@Test
37-
public void testCommandOverride() throws SQLException {
37+
void testCommandOverride() throws SQLException {
3838
try (
3939
CrateDBContainer cratedb = new CrateDBContainer(CrateDBTestImages.CRATEDB_TEST_IMAGE)
4040
.withCommand("crate -C discovery.type=single-node -C cluster.name=testcontainers")
@@ -48,7 +48,7 @@ public void testCommandOverride() throws SQLException {
4848
}
4949

5050
@Test
51-
public void testExplicitInitScript() throws SQLException {
51+
void testExplicitInitScript() throws SQLException {
5252
try (
5353
CrateDBContainer cratedb = new CrateDBContainer(CrateDBTestImages.CRATEDB_TEST_IMAGE)
5454
.withInitScript("somepath/init_cratedb.sql")

0 commit comments

Comments
 (0)