Skip to content

Commit 4df12fc

Browse files
committed
Make container a @rule again by moving initialization into contructor
1 parent 885df86 commit 4df12fc

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

core/src/test/java/org/testcontainers/containers/wait/internal/InternalCommandPortListeningCheckTest.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.google.common.collect.ImmutableSet;
44
import org.junit.After;
55
import org.junit.Before;
6+
import org.junit.Rule;
67
import org.junit.Test;
78
import org.junit.runner.RunWith;
89
import org.junit.runners.Parameterized;
@@ -16,9 +17,6 @@
1617
@RunWith(Parameterized.class)
1718
public class InternalCommandPortListeningCheckTest {
1819

19-
@Parameterized.Parameter
20-
public String dockerfile;
21-
2220
@Parameterized.Parameters(name = "{index} - {0}")
2321
public static Iterable<Object[]> data() {
2422
return asList(
@@ -29,20 +27,14 @@ public static Iterable<Object[]> data() {
2927
});
3028
}
3129

30+
@Rule
3231
public GenericContainer container;
3332

34-
@Before
35-
public void setUp() {
33+
public InternalCommandPortListeningCheckTest(String dockerfile) {
3634
container = new GenericContainer(new ImageFromDockerfile()
3735
.withFileFromClasspath("Dockerfile", dockerfile)
3836
.withFileFromClasspath("nginx.conf", "internal-port-check-dockerfile/nginx.conf")
3937
);
40-
container.start();
41-
}
42-
43-
@After
44-
public void tearDown() {
45-
container.stop();
4638
}
4739

4840
@Test

0 commit comments

Comments
 (0)