Skip to content

Commit 1aad405

Browse files
committed
Uses clickhouse/clickhouse-server as Docker Image in ClickHouseProvider
1 parent 2707f31 commit 1aad405

File tree

7 files changed

+11
-9
lines changed

7 files changed

+11
-9
lines changed

modules/clickhouse/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ dependencies {
99

1010
testImplementation project(':jdbc-test')
1111
testRuntimeOnly(group: 'com.clickhouse', name: 'clickhouse-jdbc', version: '0.7.0', classifier: 'http')
12+
testImplementation 'org.apache.httpcomponents.client5:httpclient5:5.4.1'
1213
testImplementation 'org.assertj:assertj-core:3.26.3'
1314
testImplementation testFixtures(project(':r2dbc'))
1415
testRuntimeOnly(group: 'com.clickhouse', name: 'clickhouse-r2dbc', version: '0.7.0', classifier: 'http')

modules/clickhouse/src/main/java/org/testcontainers/clickhouse/ClickHouseContainer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
*/
2222
public class ClickHouseContainer extends JdbcDatabaseContainer<ClickHouseContainer> {
2323

24-
private static final String NAME = "clickhouse";
24+
public static final String NAME = "clickhouse";
2525

26-
static final String CLICKHOUSE_CLICKHOUSE_SERVER = "clickhouse/clickhouse-server";
26+
public static final String CLICKHOUSE_CLICKHOUSE_SERVER = "clickhouse/clickhouse-server";
2727

2828
private static final DockerImageName CLICKHOUSE_IMAGE_NAME = DockerImageName.parse(CLICKHOUSE_CLICKHOUSE_SERVER);
2929

modules/clickhouse/src/main/java/org/testcontainers/containers/ClickHouseProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.testcontainers.containers;
22

3+
import org.testcontainers.clickhouse.ClickHouseContainer;
34
import org.testcontainers.utility.DockerImageName;
45

56
public class ClickHouseProvider extends JdbcDatabaseContainerProvider {
@@ -11,6 +12,6 @@ public boolean supports(String databaseType) {
1112

1213
@Override
1314
public JdbcDatabaseContainer newInstance(String tag) {
14-
return new ClickHouseContainer(DockerImageName.parse(ClickHouseContainer.IMAGE).withTag(tag));
15+
return new ClickHouseContainer(DockerImageName.parse(ClickHouseContainer.CLICKHOUSE_CLICKHOUSE_SERVER).withTag(tag));
1516
}
1617
}

modules/clickhouse/src/test/java/org/testcontainers/ClickhouseTestImages.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
import org.testcontainers.utility.DockerImageName;
44

55
public interface ClickhouseTestImages {
6-
DockerImageName CLICKHOUSE_IMAGE = DockerImageName.parse("clickhouse/clickhouse-server:21.9.2-alpine");
6+
DockerImageName CLICKHOUSE_IMAGE = DockerImageName.parse("clickhouse/clickhouse-server:24.8.12.28");
77
}

modules/clickhouse/src/test/java/org/testcontainers/clickhouse/ClickHouseContainerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class ClickHouseContainerTest extends AbstractContainerDatabaseTest {
1212

1313
@Test
1414
public void testSimple() throws SQLException {
15-
try (ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:21.9.2-alpine")) {
15+
try (ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:24.8.12.28")) {
1616
clickhouse.start();
1717

1818
ResultSet resultSet = performQuery(clickhouse, "SELECT 1");
@@ -25,7 +25,7 @@ public void testSimple() throws SQLException {
2525
@Test
2626
public void customCredentialsWithUrlParams() throws SQLException {
2727
try (
28-
ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:21.9.2-alpine")
28+
ClickHouseContainer clickhouse = new ClickHouseContainer("clickhouse/clickhouse-server:24.8.12.28")
2929
.withUsername("test")
3030
.withPassword("test")
3131
.withDatabaseName("test")

modules/clickhouse/src/test/java/org/testcontainers/clickhouse/ClickHouseR2DBCDatabaseContainerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ protected ConnectionFactoryOptions getOptions(ClickHouseContainer container) {
1212

1313
@Override
1414
protected String createR2DBCUrl() {
15-
return "r2dbc:tc:clickhouse:///db?TC_IMAGE_TAG=21.9.2-alpine";
15+
return "r2dbc:tc:clickhouse:///db?TC_IMAGE_TAG=24.8.12.28";
1616
}
1717

1818
@Override
1919
protected ClickHouseContainer createContainer() {
20-
return new ClickHouseContainer("clickhouse/clickhouse-server:21.9.2-alpine");
20+
return new ClickHouseContainer("clickhouse/clickhouse-server:24.8.12.28");
2121
}
2222
}

modules/clickhouse/src/test/java/org/testcontainers/junit/clickhouse/SimpleClickhouseTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import org.junit.runner.RunWith;
55
import org.junit.runners.Parameterized;
66
import org.testcontainers.ClickhouseTestImages;
7-
import org.testcontainers.containers.ClickHouseContainer;
7+
import org.testcontainers.clickhouse.ClickHouseContainer;
88
import org.testcontainers.db.AbstractContainerDatabaseTest;
99
import org.testcontainers.utility.DockerImageName;
1010

0 commit comments

Comments
 (0)