Skip to content

Commit 41da7a9

Browse files
committed
fix #30, among other things
1 parent d2db9f1 commit 41da7a9

File tree

4 files changed

+18
-1
lines changed

4 files changed

+18
-1
lines changed

Changes

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
Revision history for Playwright
22

3+
0.006 2021-04-12 TEODESIAN
4+
- Prevent $? from bubbling up in our destructor and invalidating program exit code by localizing $? in quit()
5+
- Add a link to the Playwright slack in the documentation.
6+
37
0.005 2021-03-24 TEODESIAN
48
[BUG FIXES]
59
- Prevent double destroy in the event of quit() being called

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,8 @@ dzil listdeps --missing | sudo cpanm
4949
Actually running stuff:
5050

5151
`perl -Ilib example.pl`
52+
53+
## Questions?
54+
Hop into the playwright slack, and check out the #playwright-perl channel therein.
55+
I'm watching that space and should be able to answer your questions.
56+
https://aka.ms/playwright-slack

dist.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name = Playwright
2-
version = 0.005
2+
version = 0.006
33
author = George S. Baugh <[email protected]>
44
license = MIT
55
copyright_holder = Troglodyne LLC

lib/Playwright.pm

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ All the classes mentioned there will correspond to a subclass of the Playwright
7070
7171
See example.pl for a more thoroughly fleshed-out display on how to use this module.
7272
73+
=head3 Questions?
74+
75+
Feel free to join the Playwright slack server, as there is a dedicated #playwright-perl channel which I, the module author, await your requests in.
76+
L<https://aka.ms/playwright-slack>
77+
7378
=head3 Why this documentation does not list all available subclasses and their methods
7479
7580
The documentation and names for the subclasses of Playwright follow the spec strictly:
@@ -422,6 +427,9 @@ sub quit ($self) {
422427
# This should also prevent the waitpid below from deadlocking due to two processes waiting on the same pid.
423428
return unless $$ == $self->{parent};
424429

430+
# Make sure we don't mash the exit code of things like prove
431+
local $?;
432+
425433
$self->{killed} = 1;
426434
print "Attempting to terminate server process...\n" if $self->{debug};
427435
Playwright::Util::request( 'GET', 'shutdown', $self->{port}, $self->{ua} );

0 commit comments

Comments
 (0)