-
Notifications
You must be signed in to change notification settings - Fork 2k
[tfjs-node] replace deprecated utils #8425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 |
|
+1 |
|
@mattsoulanille can you review this? The fix looks correct and it blocks being able to use tfjs-node on Node >=23. |
|
any news on this? |
|
Same thing, on node 23 (and above) this is absolutely needed. Is there a reason for it not being merged ? |
|
+1 |
|
Thanks! We're currently changing our CI config, so I've run this locally to verify it passes. |
|
why is this still not released? Added this to my project: // nice hack to support tensorflow, if (!util.isArray) { |
after been marked as deprecated in node 22, node 23 removed nearly all its
util.is*functions. so using the node backend in 23 fails quite loudly with some "TypeError: util_1.isNullOrUndefined is not a function".this PR replace the few places where theses functions were used with node's recommended fixes. or with nullish-coalescing where appropriate.