Update linters

Author: awln-temporal

chasm/registrable_component.go

@@ -69,6 +69,7 @@ func WithSearchAttributes(searchAttributes []*SearchAttribute) RegistrableCompon
 			alias := sa.GetAlias()
 
 			if existingKey, exists := aliasToKey[alias]; exists {
+				//nolint:forbidigo // panic is appropriate during component registration setup
 				panic(fmt.Sprintf(
 					"duplicate search attribute alias %q: keys %q and %q both map to the same alias",
 					alias,

chasm/registry_test.go

@@ -37,7 +37,7 @@ func (s *RegistryTestSuite) TestRegistry_RegisterComponents_WithSearchAttributes
 	lib := chasm.NewMockLibrary(ctrl)
 	lib.EXPECT().Name().Return("TestLibrary").AnyTimes()
 
-	s.T().Run("successful registration with valid search attributes", func(t *testing.T) {
+	s.Run("successful registration with valid search attributes", func() {
 		boolKey := chasm.NewSearchAttributeBoolByIndex("MyBoolKey", 1)
 		timeKey := chasm.NewSearchAttributeTimeByIndex("MyTimeKey", 1)
 
@@ -54,14 +54,14 @@ func (s *RegistryTestSuite) TestRegistry_RegisterComponents_WithSearchAttributes
 
 		r := chasm.NewRegistry(s.logger)
 		err := r.Register(lib)
-		require.NoError(t, err)
+		s.NoError(err)
 	})
 
-	s.T().Run("no panic with valid keys", func(t *testing.T) {
+	s.Run("no panic with valid keys", func() {
 		// Creating valid keys should not panic
 		boolKey := chasm.NewSearchAttributeBoolByIndex("MyBoolKey", 1)
 
-		require.NotPanics(t, func() {
+		s.NotPanics(func() {
 			chasm.NewRegistrableComponent[*chasm.MockComponent](
 				"Component1",
 				chasm.WithSearchAttributes([]*chasm.SearchAttribute{
@@ -71,12 +71,12 @@ func (s *RegistryTestSuite) TestRegistry_RegisterComponents_WithSearchAttributes
 		})
 	})
 
-	s.T().Run("panic on duplicate alias", func(t *testing.T) {
+	s.Run("panic on duplicate alias", func() {
 		// Both keys trying to use the same alias - should panic
 		boolKey1 := chasm.NewSearchAttributeBoolByAlias("MyBoolKey1", "DuplicateAlias")
 		boolKey2 := chasm.NewSearchAttributeBoolByAlias("MyBoolKey2", "DuplicateAlias")
 
-		require.Panics(t, func() {
+		s.Panics(func() {
 			chasm.NewRegistrableComponent[*chasm.MockComponent](
 				"Component1",
 				chasm.WithSearchAttributes([]*chasm.SearchAttribute{

chasm/search_attribute.go

@@ -64,19 +64,22 @@ func ResolveFieldName(valueType enumspb.IndexedValueType, index int) string {
 	}
 }
 
-// Getter methods for SearchAttribute
+// GetKey returns the search attribute key.
 func (s *SearchAttribute) GetKey() string {
 	return s.key
 }
 
+// GetAlias returns the search attribute alias (field name).
 func (s *SearchAttribute) GetAlias() string {
 	return s.alias
 }
 
+// GetValueType returns the indexed value type.
 func (s *SearchAttribute) GetValueType() enumspb.IndexedValueType {
 	return s.valueType
 }
 
+// GetValue returns the search attribute value.
 func (s *SearchAttribute) GetValue() any {
 	return s.value
 }