TEP-0075: Add examples with object params and results #5144
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| apiVersion: tekton.dev/v1beta1 | ||
| kind: Task | ||
| metadata: | ||
| name: mock-clone-task | ||
| spec: | ||
| params: | ||
| - name: arg | ||
| type: object | ||
| properties: | ||
| url: | ||
| type: string | ||
| commit: | ||
| type: string | ||
| steps: | ||
| - name: mock-clone-git | ||
| image: bash | ||
| args: [ | ||
| "echo", | ||
| "--url=$(params.arg.url)", | ||
| "--commit=$(params.arg.commit)" | ||
| ] | ||
| --- | ||
| apiVersion: tekton.dev/v1beta1 | ||
| kind: Pipeline | ||
| metadata: | ||
| name: mock-clone-pipeline | ||
| spec: | ||
| params: | ||
| - name: gitrepo | ||
| properties: | ||
| url: {} | ||
| commit: {} | ||
| tasks: | ||
| - name: mock-clone | ||
| params: | ||
| - name: arg | ||
| value: $(params.gitrepo[*]) | ||
| taskRef: | ||
| name: mock-clone-task | ||
| --- | ||
| apiVersion: tekton.dev/v1beta1 | ||
| kind: PipelineRun | ||
| metadata: | ||
| generateName: pipelinerun-object-param- | ||
| spec: | ||
| params: | ||
| - name: gitrepo | ||
| value: | ||
| url: abc.com | ||
| commit: sha123 | ||
| pipelineRef: | ||
| name: mock-clone-pipeline | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| apiVersion: tekton.dev/v1beta1 | ||
| kind: TaskRun | ||
| metadata: | ||
| generateName: object-param-result- | ||
| spec: | ||
| params: | ||
| - name: gitrepo | ||
| value: | ||
| url: "xyz.com" | ||
| commit: "sha123" | ||
| taskSpec: | ||
| params: | ||
| - name: gitrepo | ||
| type: object | ||
| properties: | ||
| url: {type: string} | ||
| commit: {type: string} | ||
| results: | ||
| - name: object-results | ||
| type: object | ||
| properties: | ||
| IMAGE_URL: {type: string} | ||
| IMAGE_DIGEST: {type: string} | ||
| steps: | ||
| - name: echo-object-params | ||
| image: bash | ||
| args: [ | ||
| "echo", | ||
| "--url=$(params.gitrepo.url)", | ||
| "--commit=$(params.gitrepo.commit)" | ||
| ] | ||
| - name: write-object-result | ||
| image: bash:latest | ||
| script: | | ||
| #!/usr/bin/env bash | ||
| echo -n "{\"IMAGE_URL\":\"ar.com\", \"IMAGE_DIGEST\":\"sha234\"}" > $(results.object-results.path) | ||
|
There was a problem hiding this comment. Do you mind adding another reference to a object param key to replace |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at
examples/v1beta1/pipelineruns/alpha/pipeline-emitting-results.yamltogether, I realize another example is missing is that: a task is using a previous task's results in the params as a whole. Example with object keys: https://github.com/tektoncd/pipeline/blob/main/examples/v1beta1/pipelineruns/task_results_example.yaml and https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#passing-one-tasks-results-into-the-parameters-or-when-expressions-of-anotherThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the example for object param only. Object result (i.e. using a previous task's object result) example is in the file /pipeline-object-results.yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG!