Add tests, fix a few bugs

Author: bterlson

bin/run.js

@@ -9,12 +9,19 @@ const argv = require('../lib/cli.js').argv;
 const validator = require('../lib/validator.js');
 const Rx = require('rx');
 const util = require('util');
-const simpleReporter = require('../lib/reporters/simple.js');
 const resultsEmitter = require('../lib/resultsEmitter.js');
 const agentPool = require('../lib/agentPool.js');
 const test262Finder = require('../lib/findTest262.js');
 const scenariosForTest = require('../lib/scenarios.js');
 
+let reporter;
+if (fs.existsSync('lib/reporters/' + argv.reporter + '.js')) {
+  reporter = require('../lib/reporters/' + argv.reporter + '.js');
+} else {
+  console.error(`Reporter ${argv.reporter} not found.`);
+  process.exit(1);
+}
+
 let includesDir = argv.includesDir;
 let test262Dir = argv.test262Dir;
 
@@ -34,7 +41,7 @@ const results = rawResults.map(function (test) {
   return test;
 });
 const resultEmitter = resultsEmitter(results);
-simpleReporter(resultEmitter);
+reporter(resultEmitter);
 
 function printVersion() {
     var p = require(path.resolve(__dirname, "..", "package.json"));

lib/agentPool.js

@@ -24,7 +24,7 @@ function makePool(agents, hostType, hostArgs, hostPath) {
   pool.runTest = function (record) {
     const agent = record[0];
     const test = record[1];
-    return agent.evalScript(test.contents)
+    return agent.evalScript(test.contents, { async: true })
     .then(result => {
       pool.onNext(agent);
       test.rawResult = result;

lib/cli.js

@@ -11,9 +11,10 @@ const yargv = yargs
   .nargs('threads', 1)
   .default('threads', 1)
   .alias('threads', 't')
-  .describe('reporter', 'select a reporter to use (simple, json, or tap)')
+  .describe('reporter', 'select a reporter to use (simple or json)')
   .nargs('reporter', 1)
   .alias('reporter', 'r')
+  .default('reporter', 'simple')
   .help('help')
   .alias('help', 'h')
   .example('test262-harness path/to/test.js')

lib/reporters/json.js

@@ -0,0 +1,25 @@
+'use strict';
+
+function jsonReporter(results) {
+  let started = false;
+
+  results.on('start', function () {
+    console.log('[');
+  });
+
+  results.on('end', function () { 
+    console.log(']');
+  });
+
+  results.on('test end', function (test) {
+    if (started) {
+      process.stdout.write(',');
+    } else {
+      started = true;
+    }
+
+    console.log(JSON.stringify(test));
+  });
+}
+
+module.exports = jsonReporter;

lib/resultsEmitter.js

@@ -3,10 +3,15 @@
 const EventEmitter = require('events');
 
 function resultsEmitter(results) {
+  let started = false;
   const emitter = new EventEmitter();
-  emitter.emit('start');
   results.forEach(
     function (test) {
+      if (!started) {
+        emitter.emit('start');
+        started = true;
+      }
+
       emitter.emit('test end', test);
 
       if (test.result.pass) {

package.json

@@ -11,9 +11,8 @@
     "test": "node_modules/.bin/tape test/test.js"
   },
   "dependencies": {
-    "async": "^2.0.0-rc.6",
     "eshost": "^3.0.0",
-    "glob": "~4.0.3",
+    "glob": "^7.0.5",
     "rx": "^4.1.0",
     "test262-compiler": "^1.0.0",
     "yargs": "^4.7.1"
@@ -28,6 +27,6 @@
   ],
   "devDependencies": {
     "rimraf": "^2.5.3",
-    "tape": "^3.0.3"
+    "tape": "^3.6.1"
   }
 }

test/collateral/async.js

@@ -1,8 +1,11 @@
 /*---
 description: Async test
-note: Will only work in hosts with setTimeout...
+expected:
+  pass: true
 ---*/
 
-process.nextTick(function() {
-    $DONE()
-})
+var p = new Promise(function(resolve) {
+  resolve();
+});
+
+p.then($DONE, $DONE);

test/collateral/asyncNegative.js

@@ -1,6 +1,8 @@
 /*---
 description: Async test
 negative: RangeError
+expected:
+  pass: true
 ---*/
 
 process.nextTick(function() {

test/collateral/bothStrict.js

@@ -1,6 +1,8 @@
 /*---
 description: Should test in both modes
 negative: ReferenceError
+expected:
+  pass: true
 ---*/
 var strict;
 try { x = 1; strict = false;} catch(e) { strict = true }

test/collateral/error.js

@@ -1,5 +1,8 @@
 /*---
 description: Fails by calling $ERROR
+expected:
+  pass: false
+  message: failure message
 ---*/
 
 $ERROR('failure message');