Skip to content

Commit c5f3b36

Browse files
pewsheenWu Yu Wei
andauthored
Bump gtk version 0.15 -> 0.16 (#851)
* Update to gtk 0.16 and webkit2gtk 4.1 * chore: update dependencies to fit gtk 0.16 * fix(example): menu should create after event loop created (gtk::init) * chore: add changelog * chore: update Cargo dependencies version * Update CI * Update README.md Co-authored-by: Wu Yu Wei <[email protected]>
1 parent 0a3e007 commit c5f3b36

File tree

7 files changed

+21
-15
lines changed

7 files changed

+21
-15
lines changed

.changes/bump-gtk-version.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"wry": minor
3+
---
4+
5+
**Breaking Change:** Bump webkit2gtk to 0.19. This will use webkit2gtk-4.1 as dependency from now on. Also Bump gtk version: 0.15 -> 0.16.

.changes/config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"getPublishedVersion": "cargo search ${ pkg.pkg } --limit 1 | sed -nE 's/^[^\"]*\"//; s/\".*//1p'",
1111
"prepublish": [
1212
"sudo apt-get update",
13-
"sudo apt-get install -y libgtk-3-dev libgtksourceview-3.0-dev webkit2gtk-4.0 libayatana-appindicator3-dev",
13+
"sudo apt-get install -y libgtk-3-dev libgtksourceview-3.0-dev webkit2gtk-4.1 libayatana-appindicator3-dev",
1414
"cargo install cargo-audit --features=fix",
1515
{
1616
"command": "cargo generate-lockfile",

.github/workflows/bench.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
run: |
4747
python -m pip install --upgrade pip
4848
sudo apt-get update
49-
sudo apt-get install -y webkit2gtk-4.0 libgtksourceview-3.0-dev libayatana-appindicator3-dev xvfb
49+
sudo apt-get install -y webkit2gtk-4.1 libgtksourceview-3.0-dev libayatana-appindicator3-dev xvfb
5050
wget https://github.com/sharkdp/hyperfine/releases/download/v1.11.0/hyperfine_1.11.0_amd64.deb
5151
sudo dpkg -i hyperfine_1.11.0_amd64.deb
5252
pip install memory_profiler

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
if: contains(matrix.platform.target, 'gnu')
3030
run: |
3131
sudo apt-get update
32-
sudo apt-get install -y webkit2gtk-4.0 libgtksourceview-3.0-dev libayatana-appindicator3-dev
32+
sudo apt-get install -y webkit2gtk-4.1 libgtksourceview-3.0-dev libayatana-appindicator3-dev
3333
3434
- name: install webview2 (windows only)
3535
if: contains(matrix.platform.target, 'windows')

Cargo.toml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ serde = { version = "1.0", features = [ "derive" ] }
4141
serde_json = "1.0"
4242
thiserror = "1.0"
4343
url = "2.3"
44-
tao = { version = "0.16.0", default-features = false, features = [ "serde" ] }
44+
tao = { version = "0.17.0", default-features = false, features = [ "serde" ] }
4545
http = "0.2.8"
4646

4747
[dev-dependencies]
@@ -51,13 +51,13 @@ dirs = "4.0.0"
5151
base64 = "0.13.1"
5252

5353
[target."cfg(any(target_os = \"linux\", target_os = \"dragonfly\", target_os = \"freebsd\", target_os = \"openbsd\", target_os = \"netbsd\"))".dependencies]
54-
webkit2gtk = { version = "0.18.2", features = [ "v2_22" ] }
55-
webkit2gtk-sys = "0.18"
56-
gio = "0.15"
57-
glib = "0.15"
58-
gtk = "0.15"
59-
gdk = "0.15"
60-
soup2 = "0.2"
54+
webkit2gtk = { version = "0.19.1", features = [ "v2_38" ] }
55+
webkit2gtk-sys = "0.19.1"
56+
gio = "0.16"
57+
glib = "0.16"
58+
gtk = "0.16"
59+
gdk = "0.16"
60+
soup3 = "0.3"
6161

6262
[target."cfg(target_os = \"windows\")".dependencies]
6363
webview2-com = "0.19.1"

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Tao uses [gtk-rs](https://gtk-rs.org/) and its related libraries for window crea
8080
#### Arch Linux / Manjaro:
8181

8282
```bash
83-
sudo pacman -S webkit2gtk
83+
sudo pacman -S webkit2gtk-4.1
8484
sudo pacman -S libappindicator-gtk3 # For tray feature
8585
```
8686

@@ -89,7 +89,7 @@ The `libayatana-indicator` package can be installed from the Arch User Repositor
8989
#### Debian / Ubuntu:
9090

9191
```bash
92-
sudo apt install libwebkit2gtk-4.0-dev
92+
sudo apt install libwebkit2gtk-4.1-dev
9393
# For tray feature, choose one of following package
9494
sudo apt install libayatana-appindicator3-dev
9595
sudo apt install libappindicator3-dev
@@ -98,7 +98,7 @@ sudo apt install libappindicator3-dev
9898
#### Fedora
9999

100100
```bash
101-
sudo dnf install gtk3-devel webkit2gtk3-devel
101+
sudo dnf install gtk3-devel webkit2gtk4.1-devel
102102
# For tray feature
103103
sudo dnf install libappindicator-gtk3-devel
104104
```

examples/menu.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ fn main() -> wry::Result<()> {
2323
webview::WebViewBuilder,
2424
};
2525

26+
let event_loop = EventLoop::new();
27+
2628
let mut menu = MenuBar::new();
2729
let mut file_menu = MenuBar::new();
2830
file_menu.add_native_item(tao::menu::MenuItem::Cut);
@@ -45,7 +47,6 @@ fn main() -> wry::Result<()> {
4547
);
4648
menu.add_submenu("File", true, file_menu);
4749

48-
let event_loop = EventLoop::new();
4950
let window = WindowBuilder::new()
5051
.with_title("Custom Protocol")
5152
.with_menu(menu)

0 commit comments

Comments
 (0)