File tree Expand file tree Collapse file tree 2 files changed +7
-2
lines changed Expand file tree Collapse file tree 2 files changed +7
-2
lines changed Original file line number Diff line number Diff line change 3636
3737 # Reset this number to 0 on major V8 upgrades.
3838 # Increment by one for each non-official patch applied to deps/v8.
39- 'v8_embedder_string' : '-node.9 ' ,
39+ 'v8_embedder_string' : '-node.10 ' ,
4040
4141 ##### V8 defaults for Node.js #####
4242
Original file line number Diff line number Diff line change @@ -206,14 +206,19 @@ namespace base {
206206// base::is_trivially_copyable will differ for these cases.
207207template <typename T>
208208struct is_trivially_copyable {
209- #if V8_CC_MSVC
209+ #if V8_CC_MSVC || (__GNUC__ == 12 && __GNUC_MINOR__ <= 2)
210210 // Unfortunately, MSVC 2015 is broken in that std::is_trivially_copyable can
211211 // be false even though it should be true according to the standard.
212212 // (status at 2018-02-26, observed on the msvc waterfall bot).
213213 // Interestingly, the lower-level primitives used below are working as
214214 // intended, so we reimplement this according to the standard.
215215 // See also https://developercommunity.visualstudio.com/content/problem/
216216 // 170883/msvc-type-traits-stdis-trivial-is-bugged.html.
217+ //
218+ // GCC 12.1 and 12.2 are broken too, they are shipped by some stable Linux
219+ // distributions, so the same polyfill is also used.
220+ // See
221+ // https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc
217222 static constexpr bool value =
218223 // Copy constructor is trivial or deleted.
219224 (std::is_trivially_copy_constructible<T>::value ||
You can’t perform that action at this time.
0 commit comments