remove electron-context-menu dep and do lightweight context menus directly

Author: szTheory

package.json

@@ -26,7 +26,6 @@
 		"compile": "electron-webpack"
 	},
 	"dependencies": {
-		"electron-context-menu": "^0.15.0",
 		"electron-unhandled": "^3.0.0",
 		"node-exiftool": "^2.3.0",
 		"source-map-support": "^0.5.19",

src/main/context_menu.ts

@@ -0,0 +1,30 @@
+import { app, Menu, MenuItem, BrowserWindow } from "electron";
+
+function menu(canCopy: boolean): Menu {
+	const menu = new Menu();
+
+	if (canCopy) {
+		menu.append(
+			new MenuItem({
+				label: "Copy",
+				role: "copy",
+				visible: canCopy,
+				enabled: canCopy
+			})
+		);
+	}
+	menu.append(new MenuItem({ label: "Select All", role: "selectAll" }));
+	return menu;
+}
+
+export function setupContextMenu(): void {
+	app.on("browser-window-created", (event: Event, win: BrowserWindow) => {
+		win.webContents.on(
+			"context-menu",
+			(_event: Event, params: Electron.ContextMenuParams) => {
+				const isTextSelected = params.selectionText.trim().length > 0;
+				menu(params.editFlags.canCopy && isTextSelected).popup();
+			}
+		);
+	});
+}

src/main/init.ts

@@ -1,5 +1,5 @@
 import { app, BrowserWindow } from "electron";
-import contextMenu from "electron-context-menu";
+import { setupContextMenu } from "./context_menu";
 import unhandled from "electron-unhandled";
 
 import packageJson from "../../package.json";
@@ -10,12 +10,6 @@ function setupErrorHandling(): void {
 	unhandled();
 }
 
-// context menu (copy/paste/etc)
-function setupContextMenu(): void {
-	// TODO: manually build this out and remove electron-context-menu
-	contextMenu();
-}
-
 function setupUserModelId(): void {
 	app.setAppUserModelId(packageJson.build.appId);
 }

src/renderer/drag.ts

@@ -18,14 +18,6 @@ function respondToDragOverEvent(event: DragEvent): void {
 	event.stopPropagation();
 }
 
-document.addEventListener("drop", event => {
-	respondToDropEvent(event);
-});
-
-document.addEventListener("dragover", event => {
-	respondToDragOverEvent(event);
-});
-
 function filePaths({ fileList }: { fileList: FileList }): string[] {
 	let paths = [];
 	for (const file of fileList) {
@@ -34,3 +26,13 @@ function filePaths({ fileList }: { fileList: FileList }): string[] {
 
 	return paths;
 }
+
+export function setupDragAndDrop() {
+	document.addEventListener("drop", event => {
+		respondToDropEvent(event);
+	});
+
+	document.addEventListener("dragover", event => {
+		respondToDragOverEvent(event);
+	});
+}

src/renderer/index.ts

@@ -10,8 +10,16 @@ if (isDev && module.hot) {
 import "../styles/index.scss";
 
 // app
-require("../renderer/drag");
-require("../renderer/menu_select_files");
+import { setupDragAndDrop } from "./drag";
+import { setupSelectFilesMenu } from "./menu_select_files";
 
-// SETUP ERROR HANDLING
-unhandled();
+function setup() {
+	// setup app
+	setupDragAndDrop();
+	setupSelectFilesMenu();
+
+	// report unhandled errors
+	unhandled();
+}
+
+setup();

src/renderer/menu_select_files.ts

@@ -2,6 +2,8 @@ import { ipcRenderer } from "electron";
 import { selectFiles } from "./select_files";
 import { EVENT_FILE_OPEN_ADD_FILES } from "../main/menu_file_open";
 
-ipcRenderer.on(EVENT_FILE_OPEN_ADD_FILES, (event, filePaths) => {
-	selectFiles({ filePaths: filePaths });
-});
+export function setupSelectFilesMenu() {
+	ipcRenderer.on(EVENT_FILE_OPEN_ADD_FILES, (event, filePaths) => {
+		selectFiles({ filePaths: filePaths });
+	});
+}

yarn.lock

@@ -2171,14 +2171,6 @@ cli-truncate@^0.2.1:
     slice-ansi "0.0.4"
     string-width "^1.0.1"
 
-cli-truncate@^2.0.0:
-  version "2.0.0"
-  resolved "https://registry.yarnpkg.com/cli-truncate/-/cli-truncate-2.0.0.tgz#68ff6aaa53b203b52ad89b8b1a80f1f61ad1e1d5"
-  integrity sha512-C4hp+8GCIFVsUUiXcw+ce+7wexVWImw8rQrgMBFsqerx9LvvcGlwm6sMjQYAEmV/Xb87xc1b5Ttx505MSpZVqg==
-  dependencies:
-    slice-ansi "^2.1.0"
-    string-width "^4.1.0"
-
 cli-width@^2.0.0:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/cli-width/-/cli-width-2.2.0.tgz#ff19ede8a9a5e579324147b0c11f0fbcbabed639"
@@ -3024,15 +3016,6 @@ electron-builder@^22.2.0:
     update-notifier "^3.0.1"
     yargs "^15.0.2"
 
-electron-context-menu@^0.15.0:
-  version "0.15.1"
-  resolved "https://registry.yarnpkg.com/electron-context-menu/-/electron-context-menu-0.15.1.tgz#30d776ff889f220de688bde762870d5fcf9c83c2"
-  integrity sha512-+uiTR8c/GKT1D4jxkV5GGEuAJz+RJGFJmdCXD3yIzhQ6BwpjEC99F9DqJJfTzHK1P3R5sxiZ7qoSNvg/3dBgzw==
-  dependencies:
-    cli-truncate "^2.0.0"
-    electron-dl "^1.2.0"
-    electron-is-dev "^1.0.1"
-
 electron-devtools-installer@^2.2.4:
   version "2.2.4"
   resolved "https://registry.yarnpkg.com/electron-devtools-installer/-/electron-devtools-installer-2.2.4.tgz#261a50337e37121d338b966f07922eb4939a8763"
@@ -3043,15 +3026,6 @@ electron-devtools-installer@^2.2.4:
     rimraf "^2.5.2"
     semver "^5.3.0"
 
-electron-dl@^1.2.0:
-  version "1.14.0"
-  resolved "https://registry.yarnpkg.com/electron-dl/-/electron-dl-1.14.0.tgz#1466f1b945664ca3d784268307c2b935728177bf"
-  integrity sha512-4okyei42a1mLsvLK7hLrIfd20EQzB18nIlLTwBV992aMSmTGLUEFRTmO1MfSslGNrzD8nuPuy1l/VxO8so4lig==
-  dependencies:
-    ext-name "^5.0.0"
-    pupa "^1.0.0"
-    unused-filename "^1.0.0"
-
 electron-is-dev@^1.0.1:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/electron-is-dev/-/electron-is-dev-1.1.0.tgz#b15a2a600bdc48a51a857d460e05f15b19a2522c"
@@ -3757,21 +3731,6 @@ express@^4.17.1:
     utils-merge "1.0.1"
     vary "~1.1.2"
 
-ext-list@^2.0.0:
-  version "2.2.2"
-  resolved "https://registry.yarnpkg.com/ext-list/-/ext-list-2.2.2.tgz#0b98e64ed82f5acf0f2931babf69212ef52ddd37"
-  integrity sha512-u+SQgsubraE6zItfVA0tBuCBhfU9ogSRnsvygI7wht9TS510oLkBRXBsqopeUG/GBOIQyKZO9wjTqIu/sf5zFA==
-  dependencies:
-    mime-db "^1.28.0"
-
-ext-name@^5.0.0:
-  version "5.0.0"
-  resolved "https://registry.yarnpkg.com/ext-name/-/ext-name-5.0.0.tgz#70781981d183ee15d13993c8822045c506c8f0a6"
-  integrity sha512-yblEwXAbGv1VQDmow7s38W77hzAgJAO50ztBLMcUyUBfxv1HC+LGwtiEN+Co6LtlqT/5uwVOxsD4TNIilWhwdQ==
-  dependencies:
-    ext-list "^2.0.0"
-    sort-keys-length "^1.0.0"
-
 extend-shallow@^2.0.1:
   version "2.0.1"
   resolved "https://registry.yarnpkg.com/extend-shallow/-/extend-shallow-2.0.1.tgz#51af7d614ad9a9f610ea1bafbb989d6b1c56890f"
@@ -6130,7 +6089,7 @@ miller-rabin@^4.0.0:
     bn.js "^4.0.0"
     brorand "^1.0.1"
 
-[email protected], mime-db@^1.28.0:
+[email protected]:
   version "1.42.0"
   resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.42.0.tgz#3e252907b4c7adb906597b4b65636272cf9e7bac"
   integrity sha512-UbfJCR4UAVRNgMpfImz05smAXK7+c+ZntjaA26ANtkXLlOe947Aag5zdIcKQULAiF9Cq4WxBi9jUs5zkA84bYQ==
@@ -6295,11 +6254,6 @@ mkdirp@^0.5.0, mkdirp@^0.5.1, mkdirp@^0.5.3:
   dependencies:
     minimist "^1.2.5"
 
-modify-filename@^1.1.0:
-  version "1.1.0"
-  resolved "https://registry.yarnpkg.com/modify-filename/-/modify-filename-1.1.0.tgz#9a2dec83806fbb2d975f22beec859ca26b393aa1"
-  integrity sha1-mi3sg4Bvuy2XXyK+7IWcoms5OqE=
-
 move-concurrently@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/move-concurrently/-/move-concurrently-1.0.1.tgz#be2c005fda32e0b29af1f05d7c4b33214c701f92"
@@ -7478,11 +7432,6 @@ punycode@^2.1.0:
   resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec"
   integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A==
 
-pupa@^1.0.0:
-  version "1.0.0"
-  resolved "https://registry.yarnpkg.com/pupa/-/pupa-1.0.0.tgz#9a9568a5af7e657b8462a6e9d5328743560ceff6"
-  integrity sha1-mpVopa9+ZXuEYqbp1TKHQ1YM7/Y=
-
 [email protected]:
   version "6.7.0"
   resolved "https://registry.yarnpkg.com/qs/-/qs-6.7.0.tgz#41dc1a015e3d581f1621776be31afb2876a9b1bc"
@@ -8423,13 +8372,6 @@ [email protected]:
     faye-websocket "^0.10.0"
     uuid "^3.0.1"
 
-sort-keys-length@^1.0.0:
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/sort-keys-length/-/sort-keys-length-1.0.1.tgz#9cb6f4f4e9e48155a6aa0671edd336ff1479a188"
-  integrity sha1-nLb09OnkgVWmqgZx7dM2/xR5oYg=
-  dependencies:
-    sort-keys "^1.0.0"
-
 sort-keys@^1.0.0:
   version "1.1.2"
   resolved "https://registry.yarnpkg.com/sort-keys/-/sort-keys-1.1.2.tgz#441b6d4d346798f1b4e49e8920adfba0e543f9ad"
@@ -9277,14 +9219,6 @@ unset-value@^1.0.0:
     has-value "^0.3.1"
     isobject "^3.0.0"
 
-unused-filename@^1.0.0:
-  version "1.0.0"
-  resolved "https://registry.yarnpkg.com/unused-filename/-/unused-filename-1.0.0.tgz#d340880f71ae2115ebaa1325bef05cc6684469c6"
-  integrity sha1-00CID3GuIRXrqhMlvvBcxmhEacY=
-  dependencies:
-    modify-filename "^1.1.0"
-    path-exists "^3.0.0"
-
 upath@^1.1.1:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/upath/-/upath-1.2.0.tgz#8f66dbcd55a883acdae4408af8b035a5044c1894"