Refactor code-style

Author: wooorm

lib/atom.js

@@ -7,7 +7,7 @@
  * @typedef {import('./types.js').Entry} Entry
  */
 
-import {URL} from 'url'
+import {URL} from 'node:url'
 import {u} from 'unist-builder'
 import {x} from 'xastscript'
 import {bcp47Normalize as normalize} from 'bcp-47-normalize'
@@ -22,27 +22,32 @@ import {toAuthor, toDate} from './util.js'
  * @returns {Root}
  */
 export function atom(channel, data) {
-  var now = new Date()
+  const now = new Date()
   /** @type {Channel} */
-  var meta = channel || {title: null, url: null}
+  const meta = channel || {title: null, url: null}
   /** @type {Array.<Element>} */
-  var items = []
-  var index = -1
+  const items = []
+  let index = -1
   /** @type {number} */
-  var offset
+  let offset
   /** @type {Array.<Element>} */
-  var children
+  let children
   /** @type {Entry} */
-  var datum
+  let datum
   /** @type {string} */
-  var url
+  let url
   /** @type {Author} */
-  var author
+  let author
   /** @type {Enclosure} */
-  var enclosure
+  let enclosure
 
-  if (meta.title == null) throw new Error('Expected `channel.title` to be set')
-  if (meta.url == null) throw new Error('Expected `channel.url` to be set')
+  if (meta.title === undefined || meta.title === null) {
+    throw new Error('Expected `channel.title` to be set')
+  }
+
+  if (meta.url === undefined || meta.url === null) {
+    throw new Error('Expected `channel.url` to be set')
+  }
 
   url = new URL(meta.url).href
 
@@ -111,11 +116,11 @@ export function atom(channel, data) {
         children.push(x('link', {href: url}), x('id', url))
       }
 
-      if (datum.published != null) {
+      if (datum.published !== undefined && datum.published !== null) {
         children.push(x('published', toDate(datum.published).toISOString()))
       }
 
-      if (datum.modified != null) {
+      if (datum.modified !== undefined && datum.modified !== null) {
         children.push(x('updated', toDate(datum.modified).toISOString()))
       }
 

lib/rss.js

@@ -7,7 +7,7 @@
  * @typedef {import('./types.js').Entry} Entry
  */
 
-import {URL} from 'url'
+import {URL} from 'node:url'
 import {u} from 'unist-builder'
 import {x} from 'xastscript'
 import {bcp47Normalize as normalize} from 'bcp-47-normalize'
@@ -22,33 +22,38 @@ import {toAuthor, toDate} from './util.js'
  * @returns {Root}
  */
 export function rss(channel, data) {
-  var now = new Date()
+  const now = new Date()
   /** @type {Channel} */
-  var meta = channel || {title: null, url: null}
+  const meta = channel || {title: null, url: null}
   /** @type {Array.<Element>} */
-  var items = []
-  var index = -1
+  const items = []
+  let index = -1
   /** @type {boolean} */
-  var atom
+  let atom
   /** @type {number} */
-  var offset
+  let offset
   /** @type {Array.<Element>} */
-  var children
+  let children
   /** @type {Entry} */
-  var datum
+  let datum
   /** @type {string} */
-  var lang
+  let lang
   /** @type {string} */
-  var copy
+  let copy
   /** @type {string} */
-  var url
+  let url
   /** @type {Author} */
-  var author
+  let author
   /** @type {Enclosure} */
-  var enclosure
+  let enclosure
 
-  if (meta.title == null) throw new Error('Expected `channel.title` to be set')
-  if (meta.url == null) throw new Error('Expected `channel.url` to be set')
+  if (meta.title === undefined || meta.title === null) {
+    throw new Error('Expected `channel.title` to be set')
+  }
+
+  if (meta.url === undefined || meta.url === null) {
+    throw new Error('Expected `channel.url` to be set')
+  }
 
   items.push(
     x('title', String(meta.title)),
@@ -123,15 +128,15 @@ export function rss(channel, data) {
         )
       }
 
-      if (datum.published != null) {
+      if (datum.published !== undefined && datum.published !== null) {
         children.push(
           // @ts-ignore `toGTMString` is exactly what we need.
           x('pubDate', toDate(datum.published).toGMTString()),
           x('dc:date', toDate(datum.published).toISOString())
         )
       }
 
-      if (datum.modified != null) {
+      if (datum.modified !== undefined && datum.modified !== null) {
         children.push(x('dc:modified', toDate(datum.modified).toISOString()))
       }
 

package.json

@@ -75,19 +75,7 @@
     "prettier": true,
     "rules": {
       "complexity": "off",
-      "eqeqeq": [
-        "error",
-        "always",
-        {
-          "null": "ignore"
-        }
-      ],
-      "no-eq-null": "off",
-      "no-var": "off",
-      "prefer-arrow-callback": "off",
-      "unicorn/explicit-length-check": "off",
-      "unicorn/numeric-separators-style": "off",
-      "unicorn/prefer-node-protocol": "off"
+      "unicorn/explicit-length-check": "off"
     }
   },
   "remarkConfig": {

readme.md

@@ -44,15 +44,15 @@ Say we have the following module, `example.js`
 import {atom, rss} from 'xast-util-feed'
 import {toXml} from 'xast-util-to-xml'
 
-var channel = {
+const channel = {
   title: 'NYT > Top Stories',
   url: 'https://www.nytimes.com',
   feedUrl: 'https://rss.nytimes.com/services/xml/rss/nyt/HomePage.xml',
   lang: 'en',
   author: 'The New York Times Company'
 }
 
-var data = [
+const data = [
   {
     title: 'Senate Balances Impeachment Trial With an Incoming President',
     url: